From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FDACC04FFE for ; Tue, 14 May 2024 20:49:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD7FE8D004A; Tue, 14 May 2024 16:49:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAE328D000D; Tue, 14 May 2024 16:49:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4EDF8D004A; Tue, 14 May 2024 16:49:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A5C778D000D for ; Tue, 14 May 2024 16:49:50 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 56B6F160D42 for ; Tue, 14 May 2024 20:49:50 +0000 (UTC) X-FDA: 82118192940.10.2536809 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf06.hostedemail.com (Postfix) with ESMTP id 133F818000A for ; Tue, 14 May 2024 20:49:47 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mKTR+aaK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=k9frE569; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mKTR+aaK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=k9frE569; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715719788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G8/TImExnPcn0/P4PnWsqrauOrC1YnmySZaU3kuuKQg=; b=wMqLi6XoxFkEw6pvXave9f4UssXo+OLGIuY7Yn+MTVceBN0KH4FfTbEnzp7Qmt5xxkcIup Ie+uaAQSjb7QODA8DIRUVJtvGrx1myzJR9lbscmw3/P/NpvOFzyW6wAWHtKH5Kao82B+Q/ nKeAepyQDWquk5k10B8ViKw0kDHQ6Sc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mKTR+aaK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=k9frE569; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mKTR+aaK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=k9frE569; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715719788; a=rsa-sha256; cv=none; b=RMqxyylRg0BH8lc8stQaGfP9zXkdZ6t5czK89ctydCvMZ/ytXBwTxvRQczg8EIiTibV4v9 0929D3vf7qXs6gi2JJ/GU4VQSTHmJO4+qtCnKnzsqowtqy5Vy5wdxZtK/D1jA7tw86dVfB pfeK5+eBfxcmI3naYy0qNGvJM5IKeNI= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 862361FB6C; Tue, 14 May 2024 20:49:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715719786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G8/TImExnPcn0/P4PnWsqrauOrC1YnmySZaU3kuuKQg=; b=mKTR+aaKzODX7Bm5w+mkknOuaO+jQQbCeLDym0is6AC8PmHYyN73dBi0/hYTnEDofuxj8I Kx6PgXdk12mRN2ld6Yd4E5D27Hlf5mWPJFCGPgE+QXWp915yIRKXeXXDemrCc4ZBJYCb1k WOoKWXyX5jM/nzSiNnnqm5xz7ai09fQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715719786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G8/TImExnPcn0/P4PnWsqrauOrC1YnmySZaU3kuuKQg=; b=k9frE569ZnCt5JYUlUd2v5N4OV51TvkKRoEmTpdpMQ2eEuLOUzTKFZAGFr82Xh1MKEl6Qr 0iBt6+BWhUaPkCDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715719786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G8/TImExnPcn0/P4PnWsqrauOrC1YnmySZaU3kuuKQg=; b=mKTR+aaKzODX7Bm5w+mkknOuaO+jQQbCeLDym0is6AC8PmHYyN73dBi0/hYTnEDofuxj8I Kx6PgXdk12mRN2ld6Yd4E5D27Hlf5mWPJFCGPgE+QXWp915yIRKXeXXDemrCc4ZBJYCb1k WOoKWXyX5jM/nzSiNnnqm5xz7ai09fQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715719786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G8/TImExnPcn0/P4PnWsqrauOrC1YnmySZaU3kuuKQg=; b=k9frE569ZnCt5JYUlUd2v5N4OV51TvkKRoEmTpdpMQ2eEuLOUzTKFZAGFr82Xh1MKEl6Qr 0iBt6+BWhUaPkCDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 92F761372E; Tue, 14 May 2024 20:49:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id F3YiIWnOQ2aMJAAAD6G6ig (envelope-from ); Tue, 14 May 2024 20:49:45 +0000 Date: Tue, 14 May 2024 22:49:44 +0200 From: Oscar Salvador To: =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= Cc: Alexandre Ghiti , Albert Ou , David Hildenbrand , Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org, =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Andrew Bresticker , Chethan Seshadri , Lorenzo Stoakes , Santosh Mamila , Sivakumar Munnangi , Sunil V L , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 4/8] riscv: mm: Add memory hotplugging support Message-ID: References: <20240514140446.538622-1-bjorn@kernel.org> <20240514140446.538622-5-bjorn@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240514140446.538622-5-bjorn@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 133F818000A X-Stat-Signature: 41r55kehcf4ngo8jnbsmcc69gokjwgth X-HE-Tag: 1715719787-858490 X-HE-Meta: U2FsdGVkX18oqjcP3zVgKaQsJyA/8p2XcyI49l5wCHlP6jGibbcGxoWL+cld9dmHUzJCQPLm4UOJOz7/j42WkS/9FhV0qDTSgd9OtlPLWZqg8Pkeha+yufw9DAiyu5ivbIk5hB/z1gQH4oUnKUvOqTSo2CaKOihKcE01HXomhsK/sG/JM+gsIpW1fjgAF5xIqY0UOt+Bzb27o0s4J9dsgUuws0AJibVJZXPvDIaaWyLZqojMEPd+EqnstJ5H/aaWizS2kQo+OPpq0Sq9VCWrb74K+A4vfTRUYL/XRVg1KBD+u8b55iu3T4bHE9jW+jpinOh77ox5e7ljxF60hRl1XOJ3omnvehrgly2VhSYd2oyEofgZWZRUQgdFFbFFOVWiys+wl/nVECQrXiWvESS54twhnwYVCxja9IxmaPJIgOwhxytVU2lKExBSy91gLNp59fmLpf2bVMJVwbG0T2UjIP33ppj3BHP3dp+NKekwK6Col5X7k4DOEG42womN802fPGrj0anfW0+6fXkM7OLjrLiDyT/wHMpOtZkxU/wWjr7ZnBKMBrcgiDKyNqxsuZ50anmHHUzz1x07kEFwU4NMi+LQtw55vBRXZA6E9uwKXhaTNQ7QGEF4yKZwLxU1NuNPBCnikmpPH1KF9tKDZsrWxN9p7xN+8lHeqcEidvpySQhDsOqHCSLdUFMETrQbeEqDhI/M0T4HoeXx9sbhadbsiF/uuzBHY2vEDktKvrsQNvyK5kLQ9CMgMpgZsAvHW5qhdafUDDskFU1RpV9rbpk3rj1gPb9ARwziBHoRqWFRU0CWneo4+pdEJ2qzSYOm8tubBWq/lA4V191XE33yxFLVzW5PWKlbUWB3XPSdKkuQRC9WiN8APuf0T7kWMNXEWg3u0lLeWgAVQrOYM8RKbRSwaMfvjTS1YdxoTRk7Eut+/k4mntzk+Sn0ds5iVrhEVJNxelg017E3InpFmmbo2uF dJ7J6dx8 ZXxy7JrPtiwg5vrc5n14KuZ6CKNVzRnZ8J7bZl4wmmFP7+FD43HAcXljgfldcs+rUUDG77d9BuBO1gu9EsSSvVycTcB9m77DfHN7s4uy3KEjhMKwEEZRd9Axdv6Sxv9EgiJ1a3cJk4EJgeTi3YZMc3gBOX2scJzpUuNw8PUX5l6B26JfYRYIGkUubqdE9R0IFj6ybwr3BrfFUOxw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 04:04:42PM +0200, Björn Töpel wrote: > +static void __meminit free_vmemmap_storage(struct page *page, size_t size, > + struct vmem_altmap *altmap) > +{ > + if (altmap) > + vmem_altmap_free(altmap, size >> PAGE_SHIFT); > + else > + free_pages((unsigned long)page_address(page), get_order(size)); David already pointed this out, but can check arch/x86/mm/init_64.c:free_pagetable(). You will see that we have to do some magic for bootmem memory (DIMMs which were not hotplugged but already present) > +#ifdef CONFIG_SPARSEMEM_VMEMMAP > +void __ref vmemmap_free(unsigned long start, unsigned long end, struct vmem_altmap *altmap) > +{ > + remove_pgd_mapping(start, end, true, altmap); > +} > +#endif /* CONFIG_SPARSEMEM_VMEMMAP */ > +#endif /* CONFIG_MEMORY_HOTPLUG */ I will comment on the patch where you add support for hotplug and the dependency, but on a track in LSFMM today, we decided that most likely we will drop memory-hotplug support for !CONFIG_SPARSEMEM_VMEMMAP environments. So, since you are adding this plain fresh, please consider to tight the hotplug dependency to CONFIG_SPARSEMEM_VMEMMAP. As a bonus, you will only have to maintain one flavour of functions. -- Oscar Salvador SUSE Labs