From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FD03C04FFE for ; Tue, 14 May 2024 15:21:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFFF66B0309; Tue, 14 May 2024 11:21:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAF9D6B030A; Tue, 14 May 2024 11:21:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B78126B030B; Tue, 14 May 2024 11:21:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 95D916B0309 for ; Tue, 14 May 2024 11:21:23 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 229F81A10E6 for ; Tue, 14 May 2024 15:21:23 +0000 (UTC) X-FDA: 82117365246.14.F95B521 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf29.hostedemail.com (Postfix) with ESMTP id 49C12120019 for ; Tue, 14 May 2024 15:21:20 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=K0X5DxtQ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf29.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715700080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zp/ZA/wPWSCpzR8DINVVcEwRJoZy8bTPv9U2MBOhkyM=; b=bwsL+JFci9yLr2YnaN0gQBHwjx5ssQiLmCDqA/5+rJtcA//l1FyKBwwgZpe6eHqKJ+7JVE xI+b088GE6gLxfoAxLfsOrJrJV05P1NAdG/jR419VdB+SbyCVrOP+eqIra1UKAJtYJqFRU d9cOFzfjrV8SQySy4XnrkcH2OYrfQIs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=K0X5DxtQ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf29.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715700080; a=rsa-sha256; cv=none; b=jk1HxdKmtlTvCggyBB4lLf9AyG6p4WR5JMECiirzVuSuHEXteG2E7IA3n+FI5Wn6MTswb8 Yu5/ZokZKlI4T0eB4fl7VpEYG1OFvvSrFnYA+LBycC6jadPDR07W3K4VRtORjXF39MYb+Y H0o+h97Ubyq1tNGHKu0ApsRuJSTsxkg= Date: Tue, 14 May 2024 08:21:12 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715700078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zp/ZA/wPWSCpzR8DINVVcEwRJoZy8bTPv9U2MBOhkyM=; b=K0X5DxtQL08E3oWIAIjNc7psXoKc+nD1muSUTmbD3yU+iapQASGca7tK62/pJP0vxHnc3j LkzuW8GdiYHx6wnaWlp2rcVRQUWBqMaa3u6Pa/o032bgDTD4FGzqZfUFQgW3Qq53VXO8v4 Yp5K7cKvGuKlIniFkjWCvWLSPbJeSIc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Michal Hocko Cc: Xiu Jianfeng , hannes@cmpxchg.org, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] memcg: don't handle event_list for v2 when offlining Message-ID: References: <20240514131106.1326323-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 49C12120019 X-Stat-Signature: ar3eh36p9ojrmqn75qzda95ak63ph5s3 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1715700080-635104 X-HE-Meta: U2FsdGVkX18on7mEEExJXlRmGzPQc7Tb+Nvy0ZMhVDJymJRyjpjPR/UVXBkmvpOXL68lmYdzWQ9zb9P2Ms8xYkUR26yGf52oVoNgaa5J805jpmUQeN2g73qqahBYXV5SkD++nTe0Ojoo0c7vCneS+aNvfusLhnD0XbAwZZHnToP/921oaNjrgDCRRc4CztZkQz8+o2AuSumtA+sTbkqqjwpUHPECmpBGqIRc8Xx3LU05nudoqyVqjkEr4WghvkZ2RC9KDlUESokhRzT3DoiO/pwq3/nw+QKNaOJAmzJHk66vm9rLYwPj+kgfHauJKqAQe+zy8NSI9XRq1OldOvcd+WrM4J/mDDVba2oeqeMxYNCQsecaC27yeJWCRI5RiH84wsHkwc6E/WaoXClGM4fUr8lquxH+5pkgYSt4QvrAFHQAKu97dO+PJTvaxmdMgCNKM21GmNSMhUGZxGLFi5d7IsY88+u9nAubEDPX/qoRL1dGNIjwib/SFZFQQCRbAhAUGvBboGE0Y/32YXOjLo/eviT2aE9iDPRQZqxguuaOSVGaxSh/4mf9SFoJ2B24RAx1mcI4DzsHoOXNhflvvCZvuxf68X3xdtVpSWySa2vpGbbnwvDIAetKPl+ivL1MKhKRHdeGNorTCJFE3BFaCI76h4G/jn3/K34p5IvK38dPsYLifUHnsd+bnbjWdPlx4sdDWPI4tfmp9H1MDdYqm2vRTcU8VGr49MjO6i0AjTN+7Im0wORD3wHw3+3CmWii3dil8hy0Ej7PIMAaXbDePSmSvtaSAF28uKPJaF2IZpqDEwstTVOPQD6E03X7KzVP+dMOJpQjA1KBLjxf/7RzC92XavzQDAbfpgfiNHTDQybedPxvXPNHGg4aaZ5fZAaPTHijtf81hjTznAuGubIYYPi9sKsv97IP2HIBklRZRduJ/iPD1MuRFGtiMh5zyBmcOJXrfNHnqT2DWK5KSlH39dz NSThrMWi mjuA1ksPifvbMzMDfhtBtPHHGlslktm582RwBbNqmnGG9DFNoyX4CfX94JHfNJMne2t24XaxHCplMIuVGH6BWuo1rvMIVkqn8Tnv7N65wwmX+xt9/1zNDgUvNJDEHyu/MR+bf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000514, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 04:09:58PM +0200, Michal Hocko wrote: > On Tue 14-05-24 13:11:06, Xiu Jianfeng wrote: > > The event_list for memcg is only valid for v1 and not used for v2, > > so it's unnessesary to handle event_list for v2. > > You are right but the code as is works just fine. The list will be > empty. It is true that we do not need to take event_list_lock lock but > nobody should be using this lock anyway. Also the offline callback is > not particularly hot path. So why do we want to change the code? +1 to that. Plus this code will be moved to a separate function in mm/memcontrol-v1.c and luckily can be compiled out entirely for users who don't need the cgroup v1 support. Thanks!