From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01FF6C25B10 for ; Mon, 13 May 2024 18:33:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 735B88D0009; Mon, 13 May 2024 14:33:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BEBA8D0001; Mon, 13 May 2024 14:33:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5603C8D0009; Mon, 13 May 2024 14:33:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 38E028D0001 for ; Mon, 13 May 2024 14:33:59 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B24A6A0261 for ; Mon, 13 May 2024 18:33:58 +0000 (UTC) X-FDA: 82114221756.12.9EDB3C7 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf22.hostedemail.com (Postfix) with ESMTP id D49FDC0003 for ; Mon, 13 May 2024 18:33:56 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=nSlVosFG; dmarc=none; spf=pass (imf22.hostedemail.com: domain of debug@rivosinc.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715625236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zIieT11BAyr5eCbucIfDMPYSpqd8uK7xxfWKvzozEyI=; b=lU1zRZZ+gPhnKK9mGzf3Gj3FpLtMW5/CBvsVy9X2nDipJLB5D3QFRAR9CJe8aUX70hR4yN riGve0Ey0CEUJV/9NXVT4PC/kIqdwfYk229uyIQKilkgXR6Y2MmXPqYBWBWktnN/j+g7Je jHArUE421ww6jleyHcSod/CDmpScH5w= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=nSlVosFG; dmarc=none; spf=pass (imf22.hostedemail.com: domain of debug@rivosinc.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715625236; a=rsa-sha256; cv=none; b=5Z5d1fcuKCogZGQ5wMtu7YyPK0UHlKZ38RhjT21z7OxE+R5OKd40cuTEQtw9bPLOcvQY2s XwthFhTn1oBiIQ7MTbTJOh1SM16bQrGjln33i80pTCREKiKqv27NX6SPKzJNP9dYU6mRip TPsVnt3fK4wM3vlj9uuPr9LwspfIxY0= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1ee954e0aa6so35776845ad.3 for ; Mon, 13 May 2024 11:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1715625236; x=1716230036; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zIieT11BAyr5eCbucIfDMPYSpqd8uK7xxfWKvzozEyI=; b=nSlVosFGYkrPzzwj9OXpw/9bl7PPR91rNOyCxze2Tog+/Q5lqb6PbzcIGW5PlXRw9c rMmVgyK/MSF42Kvr3YRL5U4KThwdMystUEkvMHfv+VAUoRU/6DWKTKEiEM7RjU1h57G3 KsCE1G4P9cfDjZgAoYVrVE1FRQMB8SXpRAGgLzIXrPicNGDjYLaZUyhaQiX3Y1oWLPwA GX2exi/LWFT5+QAeJrybUyYLuV9LncoTmvoJORZVrYNDh1qxAUSecy1Ydffo9mhVk779 co6ZZ5L5dBEqCFED6HWajalidR1O7AIyjSTO4kSPc5KOJw6ylw9x1iQN+SSrYzrYbYzx ppFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715625236; x=1716230036; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zIieT11BAyr5eCbucIfDMPYSpqd8uK7xxfWKvzozEyI=; b=qxY+/I/2pa+LvFuAtthRWeE6WetQgzg0o8R0gx5W10STclecdx07FI96uT1BqD8mGZ /OPXO7Vmd+bldEIdhiND8cvH6Q0t5r1ci+f5UczkfL03u5e3aT88dn8wKw8wms+xRdjO vbiSsMMovB96rfeXo5UnoWGyZuKZXXejjZzugCzBikSTSMoqv2iBaEcDXztH2pW9vDFS rhCuU+RKMMv109WRURDDgDY1QkBQQCBO8JnW49FyE76Yt2DApyFfpm2d/ZlPyhXolCZK xgH2xU0KrOR4Z/SR2FVZS61TmQrK4psyAI2ZsybjMqvCCPlVNIxM7ydWYANCGpLnJxrz yNNw== X-Forwarded-Encrypted: i=1; AJvYcCVBykpBzEm5NdRglcp4a4JNIUf9helAHjXB+0s8OHw5Fnb4ZcJHK2uaF7Uj9paV+37F3ZyDYA3J103n1xH87WFYEE0= X-Gm-Message-State: AOJu0YyZWlJujrzNmTn+7+Z67CHMzFiveJy3Vq/C1XFjiCdHV497BJsH KqHBTs7HM49xPtPcwbJIQJXvr0WwmFtxGGTeoTBE/D74+S58+nhQR6Q3zhtX3bc= X-Google-Smtp-Source: AGHT+IFnbLXicXE+Y/UKuSVClJLtlfBWO7CdnrEkpjnDppDvuoBtNhLdA/briBDaFchoAw9tI2ob0A== X-Received: by 2002:a17:902:f68e:b0:1e4:c07b:a8e0 with SMTP id d9443c01a7336-1ef441a76fcmr123301465ad.66.1715625235664; Mon, 13 May 2024 11:33:55 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf32b4dsm84209665ad.137.2024.05.13.11.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 11:33:55 -0700 (PDT) Date: Mon, 13 May 2024 11:33:50 -0700 From: Deepak Gupta To: Charlie Jenkins Cc: paul.walmsley@sifive.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, samuel.holland@sifive.com, conor@kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, corbet@lwn.net, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, shuah@kernel.org, brauner@kernel.org, andy.chiu@sifive.com, jerry.shih@sifive.com, hankuan.chen@sifive.com, greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, dbarboza@ventanamicro.com, sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org, vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de, bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name, maskray@google.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il, alx@kernel.org, david@redhat.com, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io, deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com Subject: Re: [PATCH v3 02/29] riscv: define default value for envcfg for task Message-ID: References: <20240403234054.2020347-1-debug@rivosinc.com> <20240403234054.2020347-3-debug@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D49FDC0003 X-Stat-Signature: f5ohcj8syit39htpqmxb618j5fg56hoo X-HE-Tag: 1715625236-352273 X-HE-Meta: U2FsdGVkX193E+QufrGjNVLok6UrOEx3mw/6Y3s7I1qfqMkigK2jbiuY9AJIamJAW/j0txEnQXEFvfU1QN/gaATi/9Szx5gw6xyxKrurlMrg3lIgU9vFi2r/j08lO3looAntIxAhdSEtCspboGmP5rkGZZqPDNw2LNknUuOMLAET/cItrKq4SXD0DrcL260J/4SsxTSbEtTeiopInf/Sx6jRrCSF0yGD8WdurrSbYOUZkJozVbJu5wCXZ8r8HMGsH+aOcA/3UKH9GWPuoYh6AushcVFL42fjwHWHf/11wEnzbkzEyTw8FJKMZFPpUwgxW4kJZAKrdsTOra9hgQvL9LTt2MmeDrAYJjy0b4SNkDgaroHhWFkSRf2R5RD+0S3Z1jYfsU1b8gmF4+yL75JEBvR23gV15chlkOpF/5MIgcv/YyQ+KDIOsCRzsiWoyzYBkG+01eEY/o7OgaUMaiHonOE34zDgtHxF1E+/+hkMW3FvyZeACR/0oRTYV38ke7kFbt362xGgTq2ktayDuDdVTQBkXuYQB7/4YAHPIUing+kokhlymN4TZ+jeJvIUq9DPmhEnZbppDHN3FPDms8zT6nPbUqJZP2Mj5taUzchT0ewhnmic286lKdDJT952QsjVleaitefhZJSAkv0CFY/aihp1G+CzyD8bpqebJiXWmxSrd3JUKILr5VXZwyj4bN4AMXnKHL4hum1y3B2HIM2IVrWxlsI/AGPWJSVpGml0YiMRNiDaZ2E/fskxyHcm7ZNH3Hs51duNwZf42TzTOJ4wzTbVMc+RLMB3Pqtx5ikeoFbjfWXlnoc3u6iwL6UniYAt+6KoUC4z/p3zoSYnhg6ZBDYBKn3d/Lfx3c8J1d/jOCjhsF0cSRusb0WWCnn+sbuxN0XesONLc8V3AjfjJkx3Zq0ETzRbSktOODhyjP7abmaW6gvq+QWAsX2V06pLVq9xadaLL6Xx0a7NMdwoGjd d62aFDOc /pD8HUeDvxrMhD01QwdwhtHIrT0XIBM4Lf4zrz10KFCdLPs4uthxchSZejxN/O1w+Tg0GTuIgc6AvpmLOhjTKcwSGcXo4MHvwt7QuUHkgkT53DIM5S/4jB/w6C14mefp7xtXeGhXSxqp4WB+NrKmy9d6AZTjG5poj2ujMMrKmpCFJGqWsBnFtJLsZGRiDJyp7UbCwjFjQ7mqVY3q67H5OsT5q7szglfSJx9O5leHVGxkT+U4g3RXGdLCuF3LzXX1CjL5ea73AgwqKqT2GVVS8QknRVqBsjMPJnt5xtsopesiCI6ezfWEYP6fOXFUkZqrW/4E/uXjdLdHrliJJChIKrNPpt0MDP2yK7O5H0aEPG9juMHz73x4791qcVUSv36bWrKjY3Qy8ysIgAxDvrM+35vOL492qqXUFHXYijOFW8rl5M80e+meEKn5ETq2Qo5Qvn1Q5TeyTp6xhEAwXsiM/Ru7nnqDcbyXUx03l8L0kZJQht7mU9frFUr3PS0aE5Nb8iCOnA8wmL85FHUwsJn/ixLuerYLtduVWgjqX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 10, 2024 at 03:33:36PM -0700, Charlie Jenkins wrote: >On Wed, Apr 03, 2024 at 04:34:50PM -0700, Deepak Gupta wrote: >> Defines a base default value for envcfg per task. By default all tasks >> should have cache zeroing capability. Any future base capabilities that >> apply to all tasks can be turned on same way. >> >> Signed-off-by: Deepak Gupta >> --- >> arch/riscv/include/asm/csr.h | 2 ++ >> arch/riscv/kernel/process.c | 6 ++++++ >> 2 files changed, 8 insertions(+) >> >> diff --git a/arch/riscv/include/asm/csr.h b/arch/riscv/include/asm/csr.h >> index 2468c55933cd..bbd2207adb39 100644 >> --- a/arch/riscv/include/asm/csr.h >> +++ b/arch/riscv/include/asm/csr.h >> @@ -202,6 +202,8 @@ >> #define ENVCFG_CBIE_FLUSH _AC(0x1, UL) >> #define ENVCFG_CBIE_INV _AC(0x3, UL) >> #define ENVCFG_FIOM _AC(0x1, UL) >> +/* by default all threads should be able to zero cache */ >> +#define ENVCFG_BASE ENVCFG_CBZE >> >> /* Smstateen bits */ >> #define SMSTATEEN0_AIA_IMSIC_SHIFT 58 >> diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c >> index 92922dbd5b5c..d3109557f951 100644 >> --- a/arch/riscv/kernel/process.c >> +++ b/arch/riscv/kernel/process.c >> @@ -152,6 +152,12 @@ void start_thread(struct pt_regs *regs, unsigned long pc, >> else >> regs->status |= SR_UXL_64; >> #endif >> + /* >> + * read current envcfg settings, AND it with base settings applicable >> + * for all the tasks. Base settings should've been set up during CPU >> + * bring up. >> + */ >> + current->thread_info.envcfg = csr_read(CSR_ENVCFG) & ENVCFG_BASE; > >This needs to be gated on xlinuxenvcfg. You're right. This csr read should be gated on xlinuxenvcfg. Will fix it. > >- Charlie > >> } >> >> void flush_thread(void) >> -- >> 2.43.2 >>