From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B8DC25B10 for ; Mon, 13 May 2024 17:33:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92F166B02B7; Mon, 13 May 2024 13:33:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DEE36B02B8; Mon, 13 May 2024 13:33:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A6B76B02B9; Mon, 13 May 2024 13:33:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5DA2C6B02B7 for ; Mon, 13 May 2024 13:33:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1EB9BA01B5 for ; Mon, 13 May 2024 17:33:43 +0000 (UTC) X-FDA: 82114069926.16.21A1533 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf09.hostedemail.com (Postfix) with ESMTP id 4062B140002 for ; Mon, 13 May 2024 17:33:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=sjYgJFAk; spf=pass (imf09.hostedemail.com: domain of debug@rivosinc.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715621621; a=rsa-sha256; cv=none; b=WhpNlZ9hxWlRmbhrxpk8E6I3PgzT3Y1WBISX4QtPvJwB55BhhoEaRTmh0lKGIWLf4xbAGT VlPcGYkS9QQYNzD2rECL9gUVKTMFmIIRcggpFe6Xa8IPlVwtnO0MocAxvhkysB0H4cBvgF Bb8QHPkIg1/33gGJHyWIuvT6Rzf2NY8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=sjYgJFAk; spf=pass (imf09.hostedemail.com: domain of debug@rivosinc.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715621621; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pNmfAcSQRV/kelva/h+PHsNWBp57DY+kk0TmAOrYUcA=; b=qVDZWU0zJ0Lxi0WqNBwO0e+TJ84ylGWBoEEaAnkkSsWs5w4tHKpvIw6DulrMMa8VCI+RRV zyAjS9dTes8gzIaD2w/1DE1K8u/rEsxKcrjtFKFneChl+b2D8LVh7OXRYxfFy206RC9b4b ZbYMis4xeBdK0gvG3IoLSUVB6r6qTE0= Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-61c4ebd0c99so3009168a12.0 for ; Mon, 13 May 2024 10:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1715621620; x=1716226420; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pNmfAcSQRV/kelva/h+PHsNWBp57DY+kk0TmAOrYUcA=; b=sjYgJFAkbPctaUynmKfsyuOAhtN015q+gW/vW2x6mw4An2yB3+YeUQwOKC4qLV/nnh 8mhzXZSaddicT8mw/zd/lah4P1Sk+eigJZdoexyBtmK1nFZ3KrDUjll4oleSQsbqF3kE z9ErHaGfipBdYUHUs7kXrqrDul0rRBEykmKSlxjN8oX6kupYe/P9Do7yPGNhy5AS2iZ6 edmhSVxod/eZkaFQ5uPi/5NOYhaTWxoEcr52Tx/KDa+htnxV4yxPQNnZmSx1YV+F9T4s lVkXmhA9RbAktDRNZnSVojkJi5Mzsdl1c9TObiceekU/IPQp+n3OttU8O6ofiyndEOdu AXsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715621620; x=1716226420; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pNmfAcSQRV/kelva/h+PHsNWBp57DY+kk0TmAOrYUcA=; b=WSU0h+hjpZcArl/6Dfs777JY4q7S6W/NGHKqtd5OvOxGBLBi0iG3kTfh6W202Fr/eS 4o7tS6Q0baH+ZUOWdY0j0IppqKs9xCljZbpcjKLvkjDjbu5SVhqGf//GiLPF68BkQ5ma NG42ES6fJ1V8RGwBh3eDkYB8QnvmmKoKlDwTI9SJaPUuv38ah8j5BkaCXQ0elQIEx+ap WNAGdlDp9g+H2V4l2Cyb1Bcy2ywTWHrI8vnnbAzt+lrDNeuO/MBsJgMRM1juS1IqWlL4 zaXyDyp0Fxqvvc7FzH1KAxFDs/4bN/064j3RKyUsM5uEGBoxGxZCv6MiKlloe2AQT55/ qwBg== X-Forwarded-Encrypted: i=1; AJvYcCUBvVeFZfZOTj8wiQ7Rvyj1KjnaDBSZNhRyeF3xXPWUgTshRo9j3YS25sr/CaaqK3NdDJr6lZyNMLFxrmZu6zlyhQE= X-Gm-Message-State: AOJu0YzDYhT2q6X2SHz98d4Ifk8xHw8uV9tiQLsdtYGXaRaCIMW1d6QW bh9UydTHGmwZHsL9e9A2KMJTmfJMHqimq1MPmmNb137q3iFpmSzWwaQSOh7Gr+o= X-Google-Smtp-Source: AGHT+IEusspRKWgMqzxIHo3LjzZ32dPe15H5hiGbuRyTZXAqW+i0ka0qC7uUI7zx+K2rXL0puSVXpQ== X-Received: by 2002:a17:902:6b44:b0:1e2:81c1:b35e with SMTP id d9443c01a7336-1ef43f4e417mr123656285ad.54.1715621620059; Mon, 13 May 2024 10:33:40 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0b9d4733sm81989285ad.54.2024.05.13.10.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 10:33:39 -0700 (PDT) Date: Mon, 13 May 2024 10:33:34 -0700 From: Deepak Gupta To: Alexandre Ghiti Cc: paul.walmsley@sifive.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, bjorn@rivosinc.com, alexghiti@rivosinc.com, samuel.holland@sifive.com, conor@kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, corbet@lwn.net, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, shuah@kernel.org, brauner@kernel.org, andy.chiu@sifive.com, jerry.shih@sifive.com, hankuan.chen@sifive.com, greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com, charlie@rivosinc.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, dbarboza@ventanamicro.com, sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org, vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de, bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name, maskray@google.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il, alx@kernel.org, david@redhat.com, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io, deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com Subject: Re: [PATCH v3 12/29] riscv mmu: teach pte_mkwrite to manufacture shadow stack PTEs Message-ID: References: <20240403234054.2020347-1-debug@rivosinc.com> <20240403234054.2020347-13-debug@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4062B140002 X-Stat-Signature: 7395zp4xmieurnmj3b5z13ab3jx93qa8 X-HE-Tag: 1715621621-926253 X-HE-Meta: U2FsdGVkX18TzfdlZhqtbp6Z4NkvXyoB1sUdo8bZ64jCl07ljZ//sUZeR5FslRSRsC4GrBA8UQMSV3kbRgZXTEvwxYTRQgg8+uX2MhV7jUAzB35YEMYktn7E2FiOydpF/PRv7MgJYFZAgbjVSN9G+GE9p63qQPFHPqYafst/CgBLRRSCPPFGyPYga9C/0F7fsmLSr/H21DyM2zUNEjH71xiuY6RrMnhytIRvkp0McFqE3qyh0apubmvFRp9EGHJ3cO0DJKbYEzifBgjETV5Lck5Mr6ymjtEju5vl8SKO7sryuKsPeVm3iZQE9TgcM+xrE/sXoGtcrlk6g6K5i7qj4CcKBnvd/nOL71hNH2w1mI5iuu9HK3JqMIdggGdEaxuQ5tVLUwFmGD3mHwzXg2o/qQzDkV36IlYI2CAhwSV5p2TpwPbIz6n8cUMGLTICYHKLzuLvOSTy53PgPhg2xuJBhIWTnKL3XM0dybK2PSdxfYGKJw2CAqrmvG4uhCAc0b8kjOuXA3iOtbtnfme4GTsWkGpCNMbx8+Y9OHMn/r3MN4Y/VV98hA8n5sPCPFMyhtGPQ004m5S/ytpXfSrjYuAL+WjHSy5qzUdJslaXIyE6jIAf+VTIHh/4K6YnbFxoz+4RuoT+KbTEymzekhlRD5MaaT+0rR+Me/lVVS05c+s5ticBNScV41yd8txmj9FUtvHW0LqZX+CCZgItVnQqeHkXhi8ry+2aKx5r8X9EsUvLXmG4rbJUj6EnFcbXXmFG4evr2ost/y1+xQkbe7CV3h/xaocY8q2pWBPzF2sB78yie3yFElHcCO0UKjAKLNSDGvXYEVKEQE/ZnlQxqnF+oqHKlyNb+FXZ8VGglOhwB7C0T2216xay55hHsme/6P+8NEShxquPIHcuamSqiP9j6iToFOnOW48tjj5B616oMzPK+1fwEWVEKOSVDbu4fMCz9y8F3nEENaN14+nprUvB8r3 oIjo8fzW GirGD9vY8kgqlu+dvW4y6ZEoulCjB1ocZx5aBHx0TF/zn3EKQiO7Pk3jzm45QwETtYZFgymknlA+vtNvUXvWSPDpTdYALWFINn7gcc0TrVVF+uyS54Xl7Rt22QynL3G9/4k+SPFhQcGp16uCdT/KZOLrfUwHbUR72bDKSDCHWGIxPeXBkGmN3t6ntfkZrLFcbTFeg1U+8HirjYPgqNN9GtMs6Geg/LIdn6CM6PDiS0YUS1Hwg10TDlQy/OsLBxt+A7oo30m3OQh57sgZFktarzzp7m7tIDqh1wVHXdOZzmDCcrMB01iLZtl+1K6bEYBVwRUf1MqcLXFCuCN65S93t1R6yq6Bu24AnMyJUiyZXY4Svhz7lnM56ncjKGxvlr+LbhvgRu0gwxIxWgHuMmVkanDcgpfo1WHOeONXMNHFwDkLiweTlb15Di6NiEspcfDX/WO4hvu5XyvZtRH09KdxZHkE7YxPJCimyCLg/cOf6BxIHFJOfKH/30MkUKjzmqKMMzaylihwsJXLiZWpDbWb2JoLRxD6WvV9EldM55uGl9NrE/0sJa616LFq7kdQ/lHb6Ca4KGGeJqIFxM4I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 12, 2024 at 06:28:59PM +0200, Alexandre Ghiti wrote: > >On 04/04/2024 01:35, Deepak Gupta wrote: >>pte_mkwrite creates PTEs with WRITE encodings for underlying arch. >>Underlying arch can have two types of writeable mappings. One that can be >>written using regular store instructions. Another one that can only be >>written using specialized store instructions (like shadow stack stores). >>pte_mkwrite can select write PTE encoding based on VMA range (i.e. >>VM_SHADOW_STACK) >> >>Signed-off-by: Deepak Gupta >>--- >> arch/riscv/include/asm/pgtable.h | 7 +++++++ >> arch/riscv/mm/pgtable.c | 21 +++++++++++++++++++++ >> 2 files changed, 28 insertions(+) >> >>diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h >>index 6362407f1e83..9b837239d3e8 100644 >>--- a/arch/riscv/include/asm/pgtable.h >>+++ b/arch/riscv/include/asm/pgtable.h >>@@ -403,6 +403,10 @@ static inline pte_t pte_wrprotect(pte_t pte) >> /* static inline pte_t pte_mkread(pte_t pte) */ >>+struct vm_area_struct; >>+pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma); >>+#define pte_mkwrite pte_mkwrite >>+ >> static inline pte_t pte_mkwrite_novma(pte_t pte) >> { >> return __pte(pte_val(pte) | _PAGE_WRITE); >>@@ -694,6 +698,9 @@ static inline pmd_t pmd_mkyoung(pmd_t pmd) >> return pte_pmd(pte_mkyoung(pmd_pte(pmd))); >> } >>+pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma); >>+#define pmd_mkwrite pmd_mkwrite >>+ >> static inline pmd_t pmd_mkwrite_novma(pmd_t pmd) >> { >> return pte_pmd(pte_mkwrite_novma(pmd_pte(pmd))); >>diff --git a/arch/riscv/mm/pgtable.c b/arch/riscv/mm/pgtable.c >>index ef887efcb679..c84ae2e0424d 100644 >>--- a/arch/riscv/mm/pgtable.c >>+++ b/arch/riscv/mm/pgtable.c >>@@ -142,3 +142,24 @@ pmd_t pmdp_collapse_flush(struct vm_area_struct *vma, >> return pmd; >> } >> #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ >>+ >>+pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) >>+{ >>+ if (vma_is_shadow_stack(vma->vm_flags)) >>+ return pte_mkwrite_shstk(pte); >>+ >>+ pte = pte_mkwrite_novma(pte); > > >I would directly return pte_mkwrite_novma(pte) instead of assigning pte. noted. > > >>+ >>+ return pte; >>+} >>+ >>+pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) >>+{ >>+ if (vma_is_shadow_stack(vma->vm_flags)) >>+ return pmd_mkwrite_shstk(pmd); >>+ >>+ pmd = pmd_mkwrite_novma(pmd); > > >Ditto here. noted here too. > > >>+ >>+ return pmd; >>+} >>+ > > >Otherwise: > >Reviewed-by: Alexandre Ghiti > >Thanks, > >Alex >