From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 543D3C25B78 for ; Mon, 13 May 2024 10:08:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEA116B00EE; Mon, 13 May 2024 06:08:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9A9B6B00EF; Mon, 13 May 2024 06:08:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 989AC6B00F0; Mon, 13 May 2024 06:08:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 79BB86B00EE for ; Mon, 13 May 2024 06:08:08 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2B43D140D35 for ; Mon, 13 May 2024 10:08:08 +0000 (UTC) X-FDA: 82112947056.10.8154444 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf27.hostedemail.com (Postfix) with ESMTP id 1E5914001F for ; Mon, 13 May 2024 10:08:05 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=malat-biz.20230601.gappssmtp.com header.s=20230601 header.b=SdVbZAkQ; dmarc=none; spf=none (imf27.hostedemail.com: domain of oss@malat.biz has no SPF policy when checking 209.85.218.43) smtp.mailfrom=oss@malat.biz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715594886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eT1dRZo/tR6HlQgQV2+V7tOU20M1zZCAIJKmRMSOZZI=; b=Xh14pwn5Q8T6L5kSfcPYJGW6jvrcmwJ+kQbH6rIBbvKN09JTZPiGqe7x3uHktrPUPOM3A+ 2ZtKTR4KdnLW8y1JPYD2VcF11hDTx22SltKJG5gLvfMlRPZWrO+SsEZh2xiVLy+tJO91U5 5iAU65wel9eAokBCUB2Ostg5W2piUCc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=malat-biz.20230601.gappssmtp.com header.s=20230601 header.b=SdVbZAkQ; dmarc=none; spf=none (imf27.hostedemail.com: domain of oss@malat.biz has no SPF policy when checking 209.85.218.43) smtp.mailfrom=oss@malat.biz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715594886; a=rsa-sha256; cv=none; b=p9i2P+bBLr7RjqJ1qulK1oSX1NkC11dZZvYc7OopH0HEKzsRXcJv7UPiQabE6210k1SzXH imbDffhsIsRVhEEpsxBjUM0CsXZBeL/9eUetdDJzKyVOszRzpBaER38gaPefzkk9a/3wko yd9gqIa7aIjC6KCPK3XTx/mB2zTgMIw= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a59a387fbc9so1059222966b.1 for ; Mon, 13 May 2024 03:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=malat-biz.20230601.gappssmtp.com; s=20230601; t=1715594884; x=1716199684; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eT1dRZo/tR6HlQgQV2+V7tOU20M1zZCAIJKmRMSOZZI=; b=SdVbZAkQ24dFbyiLo/S8kfaLKRl48a9bsC47qaie+6zN6hRd/4vEpijR+PQ4LOT7US L8xMfVrjtU0UaX3SB+De/gTQ07mto/cuOiGnCqWMLP2qycAJ8trlWySroki1WWjzSI97 XX3vOGFEd0HOyErgpoZLT6WqVR0GN1rbr39mijNGCbOt2OjYK8qxuQ+2IanMzcpFx+Ss nrxfvHnEAPAjEBGmfK9DRT+GJxl+H+wurppRF+ySaSN1HbPlZcfZP0gdh0fbvvjXhIl1 2FT+i26ZBD+lC9vZAfU0iHk6qdPaJEBnrtNphtNKfAWWVP1ep62kBtQ0b+YG8MT4h/VB w7cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715594884; x=1716199684; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eT1dRZo/tR6HlQgQV2+V7tOU20M1zZCAIJKmRMSOZZI=; b=lElH3BrDA7qSKFMXQOcJsfjiytOo1YYEGQNnZzVfmq3TbpRXOHfq7NDH8pJK0g77GG l6A5q4ICIq9gZONFQ07/q2hkrFG2QMelxgA14ZzsVvdFuLz2fhKCsGKYT9PX0kKmFJWX 5AuWUUjss4sbbeLei+vYoE2+wwrhxrouFB6NlfjNXHgdVZesSXSVRsipQw/PiVVODSYy u/7HflqassNVbEkz5I70MJEKGgyptmQ2psI7JqfnJTAcXpYiZWYb93VOcfhdv7pCE83N GauHDC6TkOU6oGfJV0cCdR2jzNRpaqCfOHfnDfIcq4REZqj4pR3zTr1GK4ZOnVwSrhVb krZg== X-Gm-Message-State: AOJu0YxPijfJpp0iMilAJ4N9kXtYCZpwhdi4MNpcPG5+8+TPzaFUaxEW QD1X9f3+qHx1v/8AOlwua24t24/Gpk7GO+lvulLfSyGT54aHSiKp/9r/azCvYw== X-Google-Smtp-Source: AGHT+IFdpEx8kz0RiOcSLxpp6W14pHBH4GnyHDpk7ayUcbU2Vc/hoHTU7RmJyQgJ3ZVgn6I9F7i/1w== X-Received: by 2002:a17:906:f809:b0:a59:d063:f5f5 with SMTP id a640c23a62f3a-a5a2d681271mr546989766b.70.1715594884216; Mon, 13 May 2024 03:08:04 -0700 (PDT) Received: from ntb.petris.klfree.czf ([193.86.118.65]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a1781d4bdsm571562066b.9.2024.05.13.03.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 03:08:03 -0700 (PDT) Date: Mon, 13 May 2024 12:01:15 +0200 From: Petr Malat To: Andrew Morton Cc: linux-mm@kvack.org Subject: Re: [PATCH] tools/mm: allow filtering and culling by module in page_owner_sort Message-ID: References: <20240508094507.685475-1-oss@malat.biz> <20240508111007.f3e7e81c1e7c9ebe97fa9f2f@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240508111007.f3e7e81c1e7c9ebe97fa9f2f@linux-foundation.org> X-Rspamd-Queue-Id: 1E5914001F X-Stat-Signature: arm41wpktoupb5rrwztqbz8m5ajtix4o X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1715594885-675498 X-HE-Meta: U2FsdGVkX1/GKqSFvzEPG8YYs11eHE0nC76DukwbxylfAyRAiK+aUFa8Dd6yymxt4TwPA6vSXvKB/n636ej0aJmrVqixLBQ1yHJ/uLOpP7GWj/IHnIvBN9u+jtgdb/ZS+mhrA615Mxn6LEMfawmoXIVyaiSEbs1p6lijn3DkZVjGabEnYbc6lO7d0ZBLAd9HU/+cWR8F+KAp/4u7Nb6TkYt96Nc+2qDrx1rSbQuUn0twD6ILxfsWsJwF2LBYyrOAgcsvrKe5L3gcaNsY9QJIJgBqiE/MATN3pZrneMobHLW5QRVK1T7qdY0yL/b5si7BKKi5EBwiIOskDdinnbvtaA4TwCh7Os1SeCBZ6lLdrgFguIpeGC8wtmyHXAiP2OtLnC+t0qvZt+UWTOoFiFae2m4UaD6G4SheqbPRBcZoBt3zKqIYlk56Vg5ZCYEjd796nT8/WGFAKgUZEtUXXlj7wbXlQTWtZ2WoqdChOGoQb4UtqoXUOv8FuY4BI4nlU8u9Lx/+T3Y+XYnwKbbhqGl42UcDB/VGi1Io2atZFsjv0peXDgj1+4y2ZoHg5iy5Z1ZFliBG83KPRkTWhIfX8KgJtqPWJ7O9ArUDwyLpCnXmhV/3rw9wVk0lTE3chYQ+Bq66uKzfqKGFP4EnCc27xbaxe4rD2jel73AjWW0Ij1eQAVqGt8otwZ1x2Pbtk62NMXDkMB10P0Eeim8ozYcTnIPH7BF+7/AQP5zHn9e3ZQwfIA4ci5itwLQV86KLafGh7aMvYXwaKFeAmHu50nJf/AZz/x8nqSWi/2OsBiNLHVTylB+EG0JMKB78u5XUKJaTPUFsB9H8dwD5Wj8yymBJBOKgrZEtWv/QkjF32Qwhp/YOxEVPhDyAsisgSQ5PjCu5tmqSSOgPJUh32XUfm6oGit+ef6mLaPySCaU716jJBQg/LeWGQSPzoDG11yg9ho0rd6xNuqbvWi+MBOvetMe7Fng IgzSbrwa xuMxehNghgbl8CZZ5hm1Dr2ARUd5Pf2xurLCipZoDjzHjYpao3t3UbTL6HdzskjBhFPE5vXRFZRtDf9d2HDXpzm5WoNQrTnTsORktLgMMhVtF7+mxwuMDEumpPSWidC6j9cfgNWH1fWJDmknCaPnNdoEt4Bsbvgef2yWa9rL+u089mqtgYDtvToWNgVc9vOGWbfvPiDtXXvplnfg0T/diEljvBVG0rdgkuLnORz80POTBjQ2WRyvqKs7AlfnZZRj9ocj8pqD6833lgmtmpOLunXHQ7kpkNrNLT2p7JYrj/Hahk8exhwIOvkBTMUB19c4H8c721Vh/nIQJIQBI7Ss37iRm4LLUa8t5jQzJ2ykHScb0Ha9vP8NMn/aUE/88jZBXCbN10Wutta+Z8L12OXXVun6y40vby4Dcvv7cE/xZgTBg0hualS7mXqQYmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000031, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, On Wed, May 08, 2024 at 11:10:07AM -0700, Andrew Morton wrote: > On Wed, 8 May 2024 11:45:07 +0200 Petr Malat wrote: > > > Extend page_owner_sort filtering and culling features to work with module > > names as well. The top most module is used. > > I'm not sure what this means. Perhaps providing some sample output > would be helpful. page_owner_sort -m --cull module generates output like this: 412434 times, 509515 pages, module: vmlinux 56476 times, 325647 pages, module: rvu_nicpf 4226 times, 4581 pages, module: nfsd 2061 times, 2062 pages, module: mvcpss 278 times, 874 pages, module: rvu_nicvf 125 times, 854 pages, module: mmc_block 473 times, 638 pages, module: dtbo_loader 126 times, 588 pages, module: rvu_af 185 times, 362 pages, module: rvu_cptvf 74 times, 340 pages, module: clk_port ... where one can see how much memory was allocated by every module, for example rvu_nicpf (ethernet) allocated 325647 pages in total. > > > Fix regex error handling, failure labels were one step shifted. > > Again, showing us the before and after effects would aid understanding. According to the regfree manual page, regfree takes "precompiled pattern buffer" as its argument, so if regcomp(preg, pattern, flags) fails, regfree(preg) should not be called, because preg doesn't contain "precompiled pattern buffer". BR, Petr