From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74F50C25B75 for ; Thu, 23 May 2024 15:59:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA2956B0088; Thu, 23 May 2024 11:59:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2B5C6B0089; Thu, 23 May 2024 11:59:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA62B6B008A; Thu, 23 May 2024 11:59:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A354B6B0088 for ; Thu, 23 May 2024 11:59:35 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1AE59406D3 for ; Thu, 23 May 2024 15:59:35 +0000 (UTC) X-FDA: 82150120710.19.340F663 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id E3D93120017 for ; Thu, 23 May 2024 15:59:32 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EkuI6ESz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716479973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SFW+xu7QNxeGwrYT708qIRdLA+B0NE1DkW6W5XAywxE=; b=Y5/j5+1JUIE1CW+YvFG9f+3AMhaDqBNSJ/LDESX0fs6Gf6Pl6/n8HNHI9S/Job6QToHUix HmXNFF5gT5tjvwE/o/0/JxlMmLO+TYrJ75ErCHETgpnfehJdyUbZs9qXApLQGX9xlWz6M5 lhxAcsjQDcknxPNmP0Rq5tqUKc2s0i8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EkuI6ESz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716479973; a=rsa-sha256; cv=none; b=cw2hIv02XaM2BeX8q6XSrcXYaOuxrLYGBG+mGNNU+jTBKeROeew5rvzmDe9b+gHoG04X/x K3lKPjKrpXugFnJByHUWmT7RqfPYNQHPq5TeG7hd33gqfdaWM8ZQD26Q41Bks82ZcEP/z5 TUQZDfVWc0+L7/y2sCxnodFW+mKLp1Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716479972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SFW+xu7QNxeGwrYT708qIRdLA+B0NE1DkW6W5XAywxE=; b=EkuI6ESz7UcfwyCxWXp89lrkSYMtteJFdGnEcweqJ0OXNBlkqJTZoJYmhbvDFibLuGAVNB 08+BhOZpDBnvos+pyPa5DsW7eWT6W426V/C1vOS73gGjzxJ2QF/1p1UyVgy3ybu3KpGOxU 4fux0G42jdjatF1f3mmeORNRosp3Hgc= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-g3nSw6OxN4-WMmYbAJphDg-1; Thu, 23 May 2024 11:59:30 -0400 X-MC-Unique: g3nSw6OxN4-WMmYbAJphDg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6a0dc98ce3fso294746d6.3 for ; Thu, 23 May 2024 08:59:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716479970; x=1717084770; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SFW+xu7QNxeGwrYT708qIRdLA+B0NE1DkW6W5XAywxE=; b=S9ZwGLQmzK/zd6R+/aXD4DLTNZJmbSBj7Z7ovRolVBug8cEvQ1nPTmXsiAODmdkXwg BCBtWJ11A/5wyTXz6h/mSFlhU3xAjwMuVKa11qaN+ClNmGsUk4LF3mctyPxa/BzlC+8+ NCQfvGQ5p6rEaxMZAPc2LA0+wKROZf5hD6J0Gr0KeeMt3Xgxu4QNtc4V9TZMxwSah9CP x+79hmsaP6EV+na3h19kJys/szeZ3Z0cY4KvhSQ+Uh3tyUiu9KyR5Ra2Xww0rzJeomIw l0twMHUrLzZYi/0yr1RHk0JJabOGRu9jE7irJlhdBjKl7vsSw3kTISbSjVftdPjFZdSX yq0A== X-Forwarded-Encrypted: i=1; AJvYcCXgsyohdZBT/ajXsUWUrKwAqwMHew1MCLuB2GOX/eWzV8aSBTMb0Z6f+MK3+3Rg8MWMLv88aJwmfxIVzPHz6XHBQmU= X-Gm-Message-State: AOJu0Yyz6pKSTn/e25a1kOACewBuNTQa2jvLLBMW5IXVUL2RXQr+BnSI kC2N1hNo62S0Fc1VTGSnEiNQcOFfEWfb6xoAH8oNS8taR7hujZgLGNwh7PR3uc7DE4bVyPQvXrG RUjWps08ONOGnDvBZiM753SRL/iFcFZoWEq+v94eJM5rt0UwI X-Received: by 2002:a05:6214:2484:b0:69b:1c5c:28fb with SMTP id 6a1803df08f44-6ab7f19ec6amr55473186d6.0.1716479969634; Thu, 23 May 2024 08:59:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfEZ/MxR7kXEObGm96kXld53lPLAn57DT2wv2+Ejd7pVHUF2vvfPDOcD/zLRIDa0eVAMCLMw== X-Received: by 2002:a05:6214:2484:b0:69b:1c5c:28fb with SMTP id 6a1803df08f44-6ab7f19ec6amr55472786d6.0.1716479968823; Thu, 23 May 2024 08:59:28 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6a15f17960csm144178206d6.25.2024.05.23.08.59.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 08:59:28 -0700 (PDT) Date: Thu, 23 May 2024 11:59:25 -0400 From: Peter Xu To: Oscar Salvador Cc: Axel Rasmussen , Andrew Morton , Andy Lutomirski , "Aneesh Kumar K.V" , Borislav Petkov , Christophe Leroy , Dave Hansen , David Hildenbrand , "H. Peter Anvin" , Helge Deller , Ingo Molnar , "James E.J. Bottomley" , John Hubbard , Liu Shixin , "Matthew Wilcox (Oracle)" , Michael Ellerman , Muchun Song , "Naveen N. Rao" , Nicholas Piggin , Peter Zijlstra , Suren Baghdasaryan , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org Subject: Re: [PATCH v2 1/1] arch/fault: don't print logs for pte marker poison errors Message-ID: References: <20240510182926.763131-1-axelrasmussen@google.com> <20240510182926.763131-2-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: E3D93120017 X-Stat-Signature: j1a5hmcxmhw6su1qp5o17rx9jc8q6935 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716479972-509570 X-HE-Meta: U2FsdGVkX1+JVPV/5eI7ZDU51INAvrcci0BOOAeiCJqbG8jBUZsHLtGolqCT0S7cgEeocHU24TK0CdsXZZDoti5FJaY7VuwqLu6uwB82qJHADFYBIy04QFxArV0dQi3/T+LjOz7gYLeYWC+VIENpN9U/p+rEm/pKOkxsGPQ+vwkVkcBl1yJy9BCWzCZKFZtA/TmuRifRkAPSfwsHLjNSvWA0A491xGSLr+MQDIhg9ozBz+hHwTAvDuK8Tyqa4yfFu61MfP6aBYG0GMZpZhttX10zlUXucMgpXtzbnZUxSg+1rziqoQTQWQN1yJoM0IICOg889fMLByvj3kdyAEE3sT79IvA5OH/A2Q30xCe4tF0+0XhHVQ/X4xUHMXkWXhYgk66fBmAOtIyRl28alEEQbdXtAelXBRrEq2PDOaVHwxXtVhB6tmIOfF+LOtMQ+RxNr86mK5YwtKl9XrVGVaeSb+J7vNyo4LD/erjVkPZDrplPQuIrFxGujbLmbFn/cX6K/ZfAkBCcBFRvnfeQR8K56nnok4I431s1qb0EAIOx/brmknMHa9YCwZydoXruXj51KQ/keDlZnjzVxMafJxSxV7HGn2LAtuppWJjoIaSuOltuPQNwclrhv2DLrLwiLeqAptOvv/wXu6WfBk0HiJtV/+ft+LDrM4JQrVB9sxztAth0jVXjRXXnmNn6SvWd0H10GQVzzjaShcOIzcLp2efzZRPm45vXEKcNXVYZLLqEOTgmciZxUWykwu/gwOBVZFGpt9TyDCATBBX8Dt77wa6A+bhI89ALoRO73m+wqYnkBADevITTwElBGhcGueBcLGfyZBwoc1r9AZSdeqeo4m6hdrNNdihyrh9Fq/r2Y3WBKsWA2x3HByObK550n0RWBz9GdhqyoYdFCxMK+7iyPNvIzFnbcR73FYnx66tVR6bz6rga2VjSaYQ7kr6Xok4pzva7uYaB6kX9MnUbdvtbuQY NT9fJsVL 3HMCdl6XwEaZWIA5B9goo2Ayg8uazu+uwbh78UFwBAe840ctLvC1Xvc1A+5KRPO5BBeUCvUDeRQN2L0jEr7OdbiU3z628N2VKcNNae0fGpmGj2pPWxx2M4ROLyC/6Jq626m/OGhO3cqq1ShOYKb6v2+1c4+cnxCXoTd6c6KDiHuTiVu7ZizBt3DRTFor/1jptUjz30yKTym6NdBaD5yxEmNRVfcEV+jX/YUtu4e8pPhvYn+QpMbk7xhu1A6sMIM95d3epQofgBjwse9eKJA/noa+2TBFvb5nXZFVgjXGlq4lGDyJsVfp7eA8xERxCbHuwG/+MZxH9XsSCCja0CCCNVfBYzyRUX9smu+vvFW1YKo57a7k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 23, 2024 at 05:08:29AM +0200, Oscar Salvador wrote: > On Wed, May 22, 2024 at 05:46:09PM -0400, Peter Xu wrote: > > > Now, ProcessB still has the page mapped, so upon re-accessing it, > > > it will trigger a new MCE event. memory-failure code will see that this > > > > The question is why accessing that hwpoison entry from ProcB triggers an > > MCE. Logically that's a swap entry and it should generate a page fault > > rather than MCE. Then in the pgfault hanlder we don't need that encoded > > pfn as we have vmf->address. > > It would be a swap entry if we reach try_to_umap_one() without trouble. > Then we have the code that converts it: > > ... > if (PageHWPoison(p)) > pteval = swp_entry_to_pte(make_hwpoison_entry(subpage)); > set_{huge_}pte_at > ... > > But maybe we could only do that for ProcA, while ProcB failed to do that, > which means that for ProcA that is a hwpoisoned-swap-entry, but ProcB still > has this page mapped as usual, so if ProcB re-access it, that will not > trigger a fault (because the page is still mapped in its pagetables). But in that case "whether encode pfn in hwpoison swap entry" doesn't matter either.. as it's not yet converted to a swap entry, so the pfn is there. Thanks, -- Peter Xu