From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FFA1C25B75 for ; Thu, 23 May 2024 15:01:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14FF46B0095; Thu, 23 May 2024 11:01:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1009C6B0098; Thu, 23 May 2024 11:01:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F09D16B0099; Thu, 23 May 2024 11:01:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D215F6B0095 for ; Thu, 23 May 2024 11:01:57 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1DF4E806C7 for ; Thu, 23 May 2024 15:01:57 +0000 (UTC) X-FDA: 82149975474.21.6E5C476 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id AACA618003C for ; Thu, 23 May 2024 15:01:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="dsR/erEG"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716476512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C47CMV7BCY5zFNRQ+97R48oDZgI05ZqpTDENm9qdftg=; b=l29zwgn0MrZE/G/m50IAi96VURqvCxMpUKhpLhLx6GhsWtXVckc4FdIpUbsrMTjxuxeAh6 G5OR8afv7AjKfHjIir+FvJZoNKLeLKMeDjS0l8sna2RUdfu4IyAG6U4DOJf50NbInlF1l/ /QmGPa09oYVhoARBl1XRL+ce0UK4+mY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="dsR/erEG"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716476512; a=rsa-sha256; cv=none; b=ADiOXTa4oPnnDU6lNrd2lEbRQdYkDxBuGFYb8/P7ZC6OednrVDe+oK5naMZfY+w1NRSjnQ 5yOybLAlTw8rXDyqWRjpT3qE8sm6VIszScr7DOfT1vTYlowjuEj3RMUM2bMuhU9g4wCHSm Mag8LTMcd4TDAbXKzjrxOyZWPgZFjhs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A23DB62853; Thu, 23 May 2024 15:01:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08F92C32781; Thu, 23 May 2024 15:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716476511; bh=vjt+cmVcTd/Pb33Pdy5i3IcyArhpy6Hbpole/X6gRcQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dsR/erEGWqTrpUYgBr8bhaGLVokjd8cGzstRgXhQ2zvCED20LY5mA0MnJl4aB4HJc La4XclaMTB3PLF5t0NJgcHpcBikZatrx9W4WY9ygCpu1jkJvp4V89pXQqDXr566CAL gTkjCgb0GVECIIBAC7rE9Vcc1BNWnE1kQBSn89vMljOj6PktOdWsJ4kFOSyrO2FQOr YJRZELiVBmkHdkK9xYQW0SBB5IY9tYW95xCXMJLE7tBB8hjy9m3a/szl7vBydpvJgo 1cI8r/UjUvpLRpRRJc65nGhaaJ0KJTCyhyGWqb4hhOTwLwf4mJQ8SN2F9cBm49eRrj 334Kp8GdszKmQ== Date: Thu, 23 May 2024 17:59:57 +0300 From: Mike Rapoport To: Eric Chanudet Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrew Morton , Baoquan He , Michael Ellerman , Nick Piggin , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2] mm/mm_init: use node's number of cpus in deferred_page_init_max_threads Message-ID: References: <20240522203758.626932-4-echanude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240522203758.626932-4-echanude@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AACA618003C X-Stat-Signature: 4egwdyr66rckxu8c8c1asn69gghq3xts X-HE-Tag: 1716476512-80294 X-HE-Meta: U2FsdGVkX18D23/s3rRl7f+5cQQ8AIHwf+iEodIdgx25OBO2qYQK7tl9DJ+icES/B8Fj9u6Vt97YBsrarJ/UXJei9h3Fd5AE+is9gos8iD/HIuOu7Agpjn3vTckSLrD1XKImMJeXFwGn3OrnBZJn2O6OVrEBd/ldMDZZhrogKMj9TmsjyFCnWVYk+ui+5LxGdWuhgMo6e63iL4VkWyaiV2plrmoeiWYj2TJWRI7U9W7H2aw50yQWPXIDdzyEEYiYgO8rANXE3l6lOSstItx4ZAtR1FT1y1KbiXE5/Vtp1TWEs8IqQCK1ke0QJyEsiBdVOwPMqxGWlR8QrCyJMpMbMUXi2fY18gvZ0AcC/4BCH6CbmulxSUMhja4XXEASmlcvABxeuPq9nJcvW0FYkeDnEmgMWItKFTFYvyRNpbRp0NB6r6j4bAypIxConjdgDQxxu78zBZ+DHUuGH8yZAH4iB1T6AqeVxvW1ServzP3LcUQ2iJf2XT617VvCk0tCc8wcZijSAJ8RsYmb0Q2Ey/RqFtCIAxz5uR7Nyqy5KUc2+ST4Ru6l25i69+VaHZ6ms9e9yIEyyfju28k1T286GWxkPzM0VA/a4tPKzyuJKS4WT65djt1ID6u+MdK6WC3+eofZlxOldXy3ULCOkhNbqMzcw7GJQsJxx9GSW3Z2gKLF0VzpkzSRgelTu734LiGEhExg6rMtt2h263N8GTdtLNs4pDqD873TxBqT45xObyPizJjfeNI/hkiYplicNXXOo80tssCepM6DrUh1314FKzdCFkBIAFelJx4ezz2jWNiUIlGYtebmiUPnQK1b1V3HGZzl5Y3G8wNL9zBM8eqIco342U8pk9mc4FeZ10+Hm6R/b4YRDKLw24HhJfP++5GBSDdE55/q6iAept2ax2cmcK9jnM4p2XQXx1IWAUT6DGda7oA2WnqVsrojBwk2mS1crrKzwN0nBqMuAMsGGybI0fb ZHruy+eL uaVshL/aNrSY+KC2JgAQ0lJdIIK3ylVAj/GkymQKt6Fjj6spjmux79N76ziK9TBgdMdgWOB+53KJEOBHjxxuEPfzXbhVdIrsA1BoHsRPv9co1Y2GbbmMzAeAjMRqEabuTfoYughlQ+7HslZ91WRBLu5cd/LKdxolsjHB62NobGpAv2fydrtVDohf+FwMOP7+5ah5P7KeoU2hHkfSMBcr5v00rLYiACp4YN7R1A0bBC3yKxuNdfD69cgi73SyDa/Hr/g/337WbZlY8Ca8YGFBNMZvk/syXrZ64vKad5xeBFLm/5Um9tTQMzkb4OcmFdwtBO6vl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 22, 2024 at 04:38:01PM -0400, Eric Chanudet wrote: > x86_64 is already using the node's cpu as maximum threads. Make that the > default for all archs setting DEFERRED_STRUCT_PAGE_INIT. > > This returns to the behavior prior making the function arch-specific > with commit ecd096506922 ("mm: make deferred init's max threads > arch-specific"). > > Signed-off-by: Eric Chanudet > > --- > Setting DEFERRED_STRUCT_PAGE_INIT and testing on a few arm64 platforms > shows faster deferred_init_memmap completions: > > | | x13s | SA8775p-ride | Ampere R137-P31 | Ampere HR330 | > | | Metal, 32GB | VM, 36GB | VM, 58GB | Metal, 128GB | > | | 8cpus | 8cpus | 8cpus | 32cpus | > |---------|-------------|--------------|-----------------|--------------| > | threads | ms (%) | ms (%) | ms (%) | ms (%) | > |---------|-------------|--------------|-----------------|--------------| > | 1 | 108 (0%) | 72 (0%) | 224 (0%) | 324 (0%) | > | cpus | 24 (-77%) | 36 (-50%) | 40 (-82%) | 56 (-82%) | > > - v1: https://lore.kernel.org/linux-arm-kernel/20240520231555.395979-5-echanude@redhat.com > - Changes since v1: > - Make the generic function return the number of cpus of the node as > max threads limit instead overriding it for arm64. > - Drop Baoquan He's R-b on v1 since the logic changed. > - Add CCs according to patch changes (ppc and s390 set > DEFERRED_STRUCT_PAGE_INIT by default). > > arch/x86/mm/init_64.c | 12 ------------ > mm/mm_init.c | 2 +- > 2 files changed, 1 insertion(+), 13 deletions(-) > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index 7e177856ee4f..adec42928ec1 100644 > --- a/arch/x86/mm/init_64.c > +++ b/arch/x86/mm/init_64.c > @@ -1354,18 +1354,6 @@ void __init mem_init(void) > preallocate_vmalloc_pages(); > } > > -#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > -int __init deferred_page_init_max_threads(const struct cpumask *node_cpumask) > -{ > - /* > - * More CPUs always led to greater speedups on tested systems, up to > - * all the nodes' CPUs. Use all since the system is otherwise idle > - * now. > - */ > - return max_t(int, cpumask_weight(node_cpumask), 1); > -} > -#endif > - > int kernel_set_to_readonly; > > void mark_rodata_ro(void) > diff --git a/mm/mm_init.c b/mm/mm_init.c > index f72b852bd5b8..e0023aa68555 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2126,7 +2126,7 @@ deferred_init_memmap_chunk(unsigned long start_pfn, unsigned long end_pfn, > __weak int __init If s390 folks confirm there's no regression for them I think we can make this static. > deferred_page_init_max_threads(const struct cpumask *node_cpumask) > { > - return 1; > + return max_t(int, cpumask_weight(node_cpumask), 1); > } > > /* Initialise remaining memory on a node */ > -- > 2.44.0 > -- Sincerely yours, Mike.