From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31077C25B75 for ; Thu, 23 May 2024 14:55:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AD9D6B008C; Thu, 23 May 2024 10:55:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 936916B0092; Thu, 23 May 2024 10:55:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D7056B0093; Thu, 23 May 2024 10:55:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5E62E6B008C for ; Thu, 23 May 2024 10:55:03 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C7F22406AB for ; Thu, 23 May 2024 14:55:02 +0000 (UTC) X-FDA: 82149958044.10.3455BD3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 1B217C0009 for ; Thu, 23 May 2024 14:55:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DFpSHDOo; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716476101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nX/ulH9XVWMKJvPl3ygVeH5f4LHyks/vFageAgxwbE0=; b=x3kfQ/v4XSg9RykBy1F8eKwsn4GiwO/Gqja9AtXHMkx7ggAGT7yJIz04DgqY/tuB8FF/oQ pb3LdjSPRPcKlNHHqTj6oBhu9AdjCmvRpWXKk0AESOP6hVx0webbjm646eGHC9nxdlcGjN 3IUJ9CM6ChFrWJPxQ2EXXM1xKCc9p6Y= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DFpSHDOo; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716476101; a=rsa-sha256; cv=none; b=cLSwRhjTMbHEMdCPegomEF7UP2nt2lS1p7YZDXTRZj0+ZAwL5iedXq4++p/To24j4odzcj 2nAX+7nMOmR7g9CjbuzLZ3iMAPqva/Ia4AchaWXzGIdA6KJ8uDv/4UjTgBxixuv0max5Hf MLVg3a+MswAIKxkrxjRFrdbX1obfQ8o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1A8C762835; Thu, 23 May 2024 14:55:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62E41C2BD10; Thu, 23 May 2024 14:54:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716476099; bh=huqtrEiJMT3yyvHgFIs+vQEWsNEe3M7813NkYEiVgZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DFpSHDOoZk4ot4oli7vxb/mxC+1SO0xwUZBrHVL2cnDmsE1XJbNYo3Ztyty0G6QOy a2+ZJdZ94aSPmDJxabofB3ir4Cj05eyvLBHuod1U6EgAyasFA7BuTbsoVlJ5oc8QAN d2YTPiKT2vx4iHtXjQqTFGmBPNMMFisqRc/l08QaPXPrzhm+6zqxEcqKFUL/r1x092 g/oQgtcsYp2BlzCY5yqNBfnsOLJm+5onwjE4ivS2SQfPlRoEf1JsqliBI3UwGhXqyH 9O7yGWBSTvc7QGZ60MS/DitDztagkeNemoiZjcYmXEVgiM69DFtFRPfyswd8HvggkS fJVYjaVZaQk0Q== Date: Thu, 23 May 2024 17:53:09 +0300 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm/mm_init.c: count nr_initialised only for last zone Message-ID: References: <20240522072959.23741-1-richard.weiyang@gmail.com> <20240522072959.23741-2-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240522072959.23741-2-richard.weiyang@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1B217C0009 X-Stat-Signature: ik7x9wkfjok91744ojwpwscwyindmhss X-Rspam-User: X-HE-Tag: 1716476100-974443 X-HE-Meta: U2FsdGVkX1/5qdyS6CDsNiF9Memw40KU2btxVuP+bYYhpuvlWIZ6ceIN3PTDR+LCXjKQfhxc4CPAMgNp8Awm6gYBkD35DM1Te3r9JboY8aaubDA5lLojLhCu/cYAGkujbejbiBp+DV5PxBibtAM3toW5adZDVGQDTrqA1S6dRg69si2V2slNq0JYAm5bpxkoqM3PvlXCtse5eZS7BpUc+mOiMDwkPOmYzlxLwUqny7oRIfSCEDC9rbl0FLcpKKHymZsyQREbvc7Rk7mJW7msLUt1Alk7OEOyElD9Z8WsukBMwpFO3p9sTcUT+f6GjH7Q896kvjSRgvrKh/VZkAd3GpbWSC6otUJDuss73deOLziKltEj8bvsn6+d4wR7Mcx4YgOXolqGuG2/FjJBpQxdsR1x0TQxFGo5GU/aSZYNo13i/eGBplV292g2iuJEeK6S45OQe/bJEEVJT9KGNAhCVu8bGRBNaqIOOOSrpisMGC9VzU+VMVzci/bJQx45LndfLi7dbclIs+Z91jYscK2JMJQn9SVcpTlE2ZYqS0hkw2yOt3IlHJvDPnNdAT3gVCW4NfeVIYMv+crwPg6rw/A2evLX+B7r0+5HTIxFA9MtpR1kdNL4aN3VT6+xyqkHRwCwXx7WvWlB8dy/SS8v13/BOA8lbXg+vUdidW5t3Fp3VRReoY2EvBIbvi0jNXHJr4UIpKY6DfNWzWxvjleZ7fa5IprodNIX9gri8cfuGS/Omul6/GOXoE5oOlRTRPBK4pyNkqw1gx190XnEasDLgVKgChsnwGESXBMzle4w6Jd5rQa0oOljLPYbvdQJTrZxc/GxB8n89pyqhx9oyFnWD0oIWHRKkMpEx5oqFptwKZxAMr6d5hG2MILUQq/f8kYU89ej4FhH7KeXpHfYrsa1xXysomHjTbnn4rLnLHw/scNruciapcsg4x2JHD4Kj1Vmp3Dvj2QgEaJjueyNnaioZE+ Ocjprgqy 9Vn0sIxhsvdHSKFYu7ZuV+Eux+s+w5Ui0RuK8BMJG5n7Rjm2esa8iX85167XPB/G8tD19VV+PHxv8lXkdV34OGWdAtsAvegCtKQ8ByS00Z+s07kQwdcvjjGydyiibBykiEDbJyXXx2Z6wxqBS3XanqZATrPG+VcYahwzmrcarrF+Ki3KQfVHg2qL5SnsD/sofm8T8OkPaXmqSkxbmCVUHlF9A5Qp6MCGHK/dCyHWTpwpre7sOQzRtXZtUt2qaGYXWhQTZRAhdGYR8zXLPnWSWEgzjI1ZR9C8DcenvQp+bL1ypRj9fR2tCZGpilWge9tLKuhJgMY8kp/ZzPM0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 22, 2024 at 07:29:59AM +0000, Wei Yang wrote: > Since we always populate low zones, it is not necessary to count > nr_initialised for them. Let's move the last zone check ahead to skip > the nr_initialised reset. We also don't need to count initialized pfns after first_deferred_pfn is detected, so the reset of nr_initialised can be moved even lower. > Assume low zones counts for 4G, this change may reduce 1M times > comparison of prev_end_pfn and end_pfn. > > Signed-off-by: Wei Yang > --- > mm/mm_init.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 2dfb87841fdb..4cc627b4ebfe 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -676,6 +676,11 @@ defer_init(int nid, unsigned long pfn, unsigned long end_pfn) > > if (early_page_ext_enabled()) > return false; > + > + /* Always populate low zones for address-constrained allocations */ > + if (end_pfn < pgdat_end_pfn(NODE_DATA(nid))) > + return false; > + > /* > * prev_end_pfn static that contains the end of previous zone > * No need to protect because called very early in boot before smp_init. > @@ -685,10 +690,6 @@ defer_init(int nid, unsigned long pfn, unsigned long end_pfn) > nr_initialised = 0; > } > > - /* Always populate low zones for address-constrained allocations */ > - if (end_pfn < pgdat_end_pfn(NODE_DATA(nid))) > - return false; > - > if (NODE_DATA(nid)->first_deferred_pfn != ULONG_MAX) > return true; > /* > -- > 2.34.1 > -- Sincerely yours, Mike.