From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B6D1C25B75 for ; Thu, 23 May 2024 03:08:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D48BF6B0092; Wed, 22 May 2024 23:08:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF8976B0095; Wed, 22 May 2024 23:08:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B99306B0096; Wed, 22 May 2024 23:08:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9D32F6B0092 for ; Wed, 22 May 2024 23:08:40 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 492041C052A for ; Thu, 23 May 2024 03:08:40 +0000 (UTC) X-FDA: 82148178000.22.EB856AB Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf14.hostedemail.com (Postfix) with ESMTP id CD74710000E for ; Thu, 23 May 2024 03:08:37 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YcGnkarf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8seKvAx3; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xo8J9aYV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=nN513p3S; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716433718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V0N0S6r8IeovFdxww9RN8WulP8rYDdid/w2zv2NcHlY=; b=xyg52U4ndx5ybgIlgnkALjRmvl7QRXrQbuc0g0J+QAzvePLgu1xLq5ChA1dSEEVvUyajzK n6M4zw8Qnwl4iPJAEjAXK7e+icBx8oFQTZd3gXjfPy696rn/KgD1LaVlx6ObaRMmc5LiAX IeSJFWHjNhOA1EO+uyJfOYBnpaWBKqo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YcGnkarf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8seKvAx3; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xo8J9aYV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=nN513p3S; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716433718; a=rsa-sha256; cv=none; b=ZnE08UKvSi0O9BzTyigjZD12kD5xm758R5URlVvuM/GdmhT7CXj5ExvuSV/FONzlvwuD9I O2tC+HSyE+IJHy+O8vv31pm+E/+pivjUCijC6Df5oXo2HQ+knqgPCh9041gk51JJAbhQqW dduv9UILxWMWV1WzDdSffJmwmfjAHrE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EDE2C1FDCE; Thu, 23 May 2024 03:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716433716; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V0N0S6r8IeovFdxww9RN8WulP8rYDdid/w2zv2NcHlY=; b=YcGnkarfP7rAwvhiOINxsKMbHpbeoO5PLcP2+nhBTfDiy176wv+VbDX11CO6faQrg2kZ6B xmEWJFNLm4TqJ8NB5pQi4TQ4HlbCqxki0PZnYqRfn/1PGf2sp5uIgzPHi8DO5YYkntL13s /PoGuujuJZycBq23rlOpbta8wOEdouU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716433716; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V0N0S6r8IeovFdxww9RN8WulP8rYDdid/w2zv2NcHlY=; b=8seKvAx34N9zbAbSXvZmX90nlXbI+J0lTECHG1ywHskkNPLTJeU0OCKKXM714nxIgCjOPv cAqnqxCS4rF9SjAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716433715; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V0N0S6r8IeovFdxww9RN8WulP8rYDdid/w2zv2NcHlY=; b=xo8J9aYV2HvLfM1cXOQxHP9mc8VPZLhgd60GR2simJH6IFQTHl2BisCBQ80uUL+up4OfDt IKTrH+tCZw22ujA2Fz5M+WpPbZ4dxsWOe2MMd5DqaEBJJMod50MovReFjtWnyfWYgNWUhU Kp8Uhrbt/BtvEopATR1oY6dRnd4z+VU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716433715; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V0N0S6r8IeovFdxww9RN8WulP8rYDdid/w2zv2NcHlY=; b=nN513p3S5maKAmTkBL5gb+fzrqAqgWdB+u8EK73ofQkChx9IgR8Rg6R7AxhnOx1vhmHiHn oIj72gUreXnNf5Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 948A813A6B; Thu, 23 May 2024 03:08:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id x4UfITKzTmZrEAAAD6G6ig (envelope-from ); Thu, 23 May 2024 03:08:34 +0000 Date: Thu, 23 May 2024 05:08:29 +0200 From: Oscar Salvador To: Peter Xu Cc: Axel Rasmussen , Andrew Morton , Andy Lutomirski , "Aneesh Kumar K.V" , Borislav Petkov , Christophe Leroy , Dave Hansen , David Hildenbrand , "H. Peter Anvin" , Helge Deller , Ingo Molnar , "James E.J. Bottomley" , John Hubbard , Liu Shixin , "Matthew Wilcox (Oracle)" , Michael Ellerman , Muchun Song , "Naveen N. Rao" , Nicholas Piggin , Peter Zijlstra , Suren Baghdasaryan , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org Subject: Re: [PATCH v2 1/1] arch/fault: don't print logs for pte marker poison errors Message-ID: References: <20240510182926.763131-1-axelrasmussen@google.com> <20240510182926.763131-2-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CD74710000E X-Stat-Signature: ek1jfawamdg7chk7dc618dn9kfna1m8r X-HE-Tag: 1716433717-188229 X-HE-Meta: U2FsdGVkX1+fKA0rKqNBUdlXQKMGd2tGFC02Ip7d1+u2J8QWHcpilbZ/7RrYggp5IYfp21D+beJ7txlrJM1uxcFoyL6PCWU3yt2xCF3QNglzzFoH8/yWbGp5OW3L2/egNEMDZstg0tLtB7kXhvl1XHb8Yudkkco8uKtXkASLpmBPS4J/fPx8hLQINv4RTHebh+cK72TCj5ub8ndGCGz0k1rLRMhHZ++lUVYFeLnVhXQR9yqrzQHseDwWuu39cYM1xTCj4cMcdZ2J6xkTqtgy3EQoHeJtECMBxrRJ3k1MgFqhSuAlmkxEuvyOYGpsjEYq08Cw1ly/gb1KcjwfsCPljdiXVDZN7RIttvupaFq5XTTVif1x2mDDNPIMrbMYdbdgknXUJg/v0c7IMv0jmIO/6JE91z6mu3YWSMNTlZDRrDbJssV29slo6riFG5HQbuTK1r/pDHFoQT8CFh3nVXoPLJ3ivGjeNKygFuQRwuATOdgmVeaD087WnJWr/wG22/bFUZW2clMoomnxnbmp3zFbnQeKTh2Kzpt4um/BNdAtCEBFsqzAph9YFNHPzTGxsaPj8aPpjkG40Cu+dEdLNpW4TnDPswu1cVvWYGVAMynhBcCj5TAjfqGMjBf5Yab0uhpa3eZ5eN19upxQI8+oFksHzvdgxHfX62wC0/WCLmxNWFpMDHQyifUQFwJbeM15+7e9bSopnqlPj6Ss6M56TCw6C31I0prq4rA21DZR15OZGSEBOvxTq2JcuS6ElnR79Kl/dokYo9aEjDchTPrD1UKl4SYCeo+ISTSE5fnuqdz6xld7LZPaO0PG490IPfOQ0ykxfEvq98s9K1JJgwghc9K9Upex5LWewl8iQBWFiTuKL/VyCs2b/2266DBSPzWbf2kdzRJ0+orJ9XmqgqPwHaX5LfAl+x90YprGsogu5o27/jybWv95uToXZG3dHRR0nBGAn0oaUdw3Q5MKz23AFRe zRcKU62Y bXZh606pd1Aa4pM0Wxx9Uzmjcv0hsLaCnVGk1c5HIGzIQwhWW8Ww2807omSodjRyKnsDPQy1pW7DSTXCZdg1SRd6yW5PBr2+tbNuQ8C3tIlvMhUbvYYFSE7KJm36ead6dt02lbTUsNhxkJoxk4iDvZROYnJUZE59sprRwAyUvDkjTlKtRJPmKnUhRTLfdQEumbWFEZzDSsLVR3EA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 22, 2024 at 05:46:09PM -0400, Peter Xu wrote: > > Now, ProcessB still has the page mapped, so upon re-accessing it, > > it will trigger a new MCE event. memory-failure code will see that this > > The question is why accessing that hwpoison entry from ProcB triggers an > MCE. Logically that's a swap entry and it should generate a page fault > rather than MCE. Then in the pgfault hanlder we don't need that encoded > pfn as we have vmf->address. It would be a swap entry if we reach try_to_umap_one() without trouble. Then we have the code that converts it: ... if (PageHWPoison(p)) pteval = swp_entry_to_pte(make_hwpoison_entry(subpage)); set_{huge_}pte_at ... But maybe we could only do that for ProcA, while ProcB failed to do that, which means that for ProcA that is a hwpoisoned-swap-entry, but ProcB still has this page mapped as usual, so if ProcB re-access it, that will not trigger a fault (because the page is still mapped in its pagetables). -- Oscar Salvador SUSE Labs