From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ABFDC25B78 for ; Wed, 22 May 2024 20:50:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCC7C6B0088; Wed, 22 May 2024 16:50:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7CA76B008A; Wed, 22 May 2024 16:50:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B43B66B008C; Wed, 22 May 2024 16:50:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 91C816B0088 for ; Wed, 22 May 2024 16:50:39 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 380D3A4A28 for ; Wed, 22 May 2024 20:50:39 +0000 (UTC) X-FDA: 82147225398.19.817843C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf14.hostedemail.com (Postfix) with ESMTP id 21121100007 for ; Wed, 22 May 2024 20:50:36 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RzDozfLG; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=tpIiFXxx; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RzDozfLG; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=tpIiFXxx; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716411037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k81BDkUMU0SoIhYIGjYwahblkQTHRGipazIuGgF/byc=; b=GBxWq2DSHn5JYuyKTU144ciWKnm1tfkC3S6s9JixgkbDPySO6J35CEPKbw+kuVlIiM2vm3 5QB8UC4bh32Jo26eU/YzxHVWCtT5Z8g91u0fQ7VtulncV0LiJ3YM9+8RxvQt1WgiaBCIMK aI0o5Qmsb3tFvdJN9fUsSPwxPtD0gVg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RzDozfLG; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=tpIiFXxx; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RzDozfLG; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=tpIiFXxx; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716411037; a=rsa-sha256; cv=none; b=wTF9GqvZqWOvzN48YyZ5rg8RJY2c3h62232Y4Z3QU+9vkHPuvj6XImvyUElvnouYy3U5Ro huFTN3p8nRAHeCYR8Thi96MZx6KB6mx8dIuOh2M0JqF9dSKtRFDOM3FQHd2D+VDwpuzfck YlLAItzPNG9L1zuZqFamLq9V/BZfRaw= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 723C61F7F0; Wed, 22 May 2024 20:50:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716411035; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k81BDkUMU0SoIhYIGjYwahblkQTHRGipazIuGgF/byc=; b=RzDozfLG/85ZUGYq6ELZiJUCU0zDiNjSwanE9DlTZJrLjcDKkGYKxffylI67o2JaSjyD8y wM1Kd0MyA5J3adJ9cNBn0kMazCJ/nEcu++gDZYbDykMvBJsNhxsgPrpz7tW0Qa6F2c1veA hOwkhPt+ngir03pLfq+u0JdboWzfqVA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716411035; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k81BDkUMU0SoIhYIGjYwahblkQTHRGipazIuGgF/byc=; b=tpIiFXxxBBT5PhPVflAniTyw53477v2YV6Fw2HPIeudyJn+DERcCBkhuIxtzzp1mYieCgC ctIituy3ZXjXyVCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716411035; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k81BDkUMU0SoIhYIGjYwahblkQTHRGipazIuGgF/byc=; b=RzDozfLG/85ZUGYq6ELZiJUCU0zDiNjSwanE9DlTZJrLjcDKkGYKxffylI67o2JaSjyD8y wM1Kd0MyA5J3adJ9cNBn0kMazCJ/nEcu++gDZYbDykMvBJsNhxsgPrpz7tW0Qa6F2c1veA hOwkhPt+ngir03pLfq+u0JdboWzfqVA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716411035; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k81BDkUMU0SoIhYIGjYwahblkQTHRGipazIuGgF/byc=; b=tpIiFXxxBBT5PhPVflAniTyw53477v2YV6Fw2HPIeudyJn+DERcCBkhuIxtzzp1mYieCgC ctIituy3ZXjXyVCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 17B4A13A7A; Wed, 22 May 2024 20:50:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4kD1AptaTmYIbwAAD6G6ig (envelope-from ); Wed, 22 May 2024 20:50:35 +0000 Date: Wed, 22 May 2024 22:50:33 +0200 From: Oscar Salvador To: Jane Chu Cc: linmiaohe@huawei.com, nao.horiguchi@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/5] mm/memory-failure: move hwpoison_filter() higher up Message-ID: References: <20240521235429.2368017-1-jane.chu@oracle.com> <20240521235429.2368017-5-jane.chu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240521235429.2368017-5-jane.chu@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 21121100007 X-Stat-Signature: cc7hrceoo9d4c1okz75j47sg3676jtja X-HE-Tag: 1716411036-370554 X-HE-Meta: U2FsdGVkX1+agWSGxX+H8GjA22XryR+a+NyXJ986yxr8do6p9YsvQuV7fmETuccbRIrA9JUemeuu/uKViSYK3E5NUZqYfEqSgp2mG4Lfdint0xIHeo+CTQdn2TnCyFf0b9znYsIF1Nn95svcTggOWgZEst4DPdqc7cQPgn+w5paGtbn1gCmHRKcsAv5Pg9mQ6z/bROz00wGGjAATxefQwVrbRFPbEczqeZbu941lkxGTBn6lnjWlqJ6VTTdfRcAEOLrkCPWTGz6E3K+WT7pKF8hGlihqCa/ITUQPm5N8mGXSsHpEoxKVyEDFMWJps+slQBY07iZcA04NeejxmEMoyVkQzLUfesY65jewbOqy4TqPBY/fYBfKu5AyIBsZSwkQSxKjXJK14fLoyS6z8Yk2mQkV6iWxe52boTr6vHIBnIw4KHAf2DJ0NPJGkHJUQEIW+xuXt2Awxs+akINNlpzo+PZ1SfUWBeDnRFQDzUy7MaphIE8tIk76wCldhdefgPSYd0eSMIjLvMvjhvJDL0FdbqAcI0GxiZ9wxu8X0tWhx5FaEAmkq0XZu7SLV1QnUDSLm1LIUtK6aacnABSYZQf8rnzuWNHQiaKH+krDK2Y3pU/C/dws7Jn02UlhEcwPNcyrRkCUVKlj0D0BVw0bE7wSu47IU2IZS2+ePcdCTrvfGjHcdO869za1Y7kjCex/VanGSpoyUXo10MRRGcpuKZ0jXVd1fpyjYt265rU5+WoPquMnu23pE1uAjS7EzMKgyCYTn5TS69WqYcFP8l9l6wTfEbKLZVPrGBjJoCq7LKd/8qkgWXxMtc2XA+goSikICvIziIrQYARlXIkd3hFfJ0NlJMKfUNfXIhY4pWvIYNFZEmc8cWiyc9+W87WqSR6RGHdPMX5WBMUhfzekOVSr6ZRVXY+By4ZcWmk5ES+20/M8A2xvEos3A8lF3G0HasvOEjSHtlwBMHFLv3DSGbRqp0/ LnpxJNPv DMx6tRj4ncGmfZ17mLvlQvaskKg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 21, 2024 at 05:54:28PM -0600, Jane Chu wrote: > Move hwpoison_filter() higher up as there is no need to spend a lot > cycles only to find out later that the page is supposed to be skipped > from hwpoison handling. > > Signed-off-by: Jane Chu Reviewed-by: Oscar Salvador I was about to raise the point that prior to this change hwpoison_filter() would be called after shake_folio(), which should turn some pages LRU, but I see that shake_page() is also called in hwpoison-inject code. -- Oscar Salvador SUSE Labs