From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF9D5C25B78 for ; Wed, 22 May 2024 20:38:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CEF96B0089; Wed, 22 May 2024 16:38:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67F776B008A; Wed, 22 May 2024 16:38:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 520B16B008C; Wed, 22 May 2024 16:38:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 33ADA6B0089 for ; Wed, 22 May 2024 16:38:01 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8F2B81C6998 for ; Wed, 22 May 2024 20:38:00 +0000 (UTC) X-FDA: 82147193520.02.2A5A1E5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf17.hostedemail.com (Postfix) with ESMTP id 46D2E40016 for ; Wed, 22 May 2024 20:37:57 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fS3T7fSX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XOHJPvWW; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fS3T7fSX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XOHJPvWW; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716410277; a=rsa-sha256; cv=none; b=Rkbu+XWfeGmS1fKQtDMiRoQjx99jkgGcpBZvsBVF0i81ulyWUXnug6hmvr/WVowMuuQnUW WyskxFlDT8i0r/Ng1Yeq5zQsAFuLf+JY/6BImEj18Yqk4jWHxkks/zW69Hf4ROEcKR+QTN QCjShrKgDA/cbt9nQ4hMJUHtsvdqt1U= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fS3T7fSX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XOHJPvWW; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fS3T7fSX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XOHJPvWW; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716410277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P7sgCBLEOd0zAwb9Vd8c+xk3tzP1NVqfInYRCah7qvo=; b=KT7LhZZNGyXQJwEclJ01JBD/7fbTkz0CMP/Be9I0AogjquiNdtPMe1g2NKzdCdqkIlKswS Qm4Mk4eKyBAyzbcdoX9pX6Ho48oo3TBM6cg2vU71WSRDP4/TnDs3wuBebU7R8Rnt2PK1ze RxaKD3/3+CxezsRWzuK3ADpPkjdZAO4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 71A6F21AFD; Wed, 22 May 2024 20:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716410275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P7sgCBLEOd0zAwb9Vd8c+xk3tzP1NVqfInYRCah7qvo=; b=fS3T7fSXE1NEq1FIoX3byHQiLLv7Pxt12b31mdWRp3mXRgHvhAbDtvLUWJA+R9xQWBbi11 a6Kfku0b3IOqmo467uOh/1Eppku/V21XQuDWgLcnsQ9qbSCKcPZ0ZegZQj1XeAC7pqGy9v FHu/ZdAnoZKN4BU1i8yYVJJw1pNYTps= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716410275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P7sgCBLEOd0zAwb9Vd8c+xk3tzP1NVqfInYRCah7qvo=; b=XOHJPvWW6NVaE8aJfQ+47Iqw7PJFlDYJ6tAB4Sc0SPRDL+kUAncGyC9kPuTkN+FF0JmaYh FH3Hoehur+jrCPDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716410275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P7sgCBLEOd0zAwb9Vd8c+xk3tzP1NVqfInYRCah7qvo=; b=fS3T7fSXE1NEq1FIoX3byHQiLLv7Pxt12b31mdWRp3mXRgHvhAbDtvLUWJA+R9xQWBbi11 a6Kfku0b3IOqmo467uOh/1Eppku/V21XQuDWgLcnsQ9qbSCKcPZ0ZegZQj1XeAC7pqGy9v FHu/ZdAnoZKN4BU1i8yYVJJw1pNYTps= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716410275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P7sgCBLEOd0zAwb9Vd8c+xk3tzP1NVqfInYRCah7qvo=; b=XOHJPvWW6NVaE8aJfQ+47Iqw7PJFlDYJ6tAB4Sc0SPRDL+kUAncGyC9kPuTkN+FF0JmaYh FH3Hoehur+jrCPDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1078013A6B; Wed, 22 May 2024 20:37:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +0kOAaNXTmaSAwAAD6G6ig (envelope-from ); Wed, 22 May 2024 20:37:55 +0000 Date: Wed, 22 May 2024 22:37:53 +0200 From: Oscar Salvador To: Jane Chu Cc: linmiaohe@huawei.com, nao.horiguchi@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/5] mm/memory-failure: improve memory failure action_result messages Message-ID: References: <20240521235429.2368017-1-jane.chu@oracle.com> <20240521235429.2368017-4-jane.chu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240521235429.2368017-4-jane.chu@oracle.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 46D2E40016 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: zbtags7j8ju3ogy8y8edx9nt83we8s3o X-HE-Tag: 1716410277-64145 X-HE-Meta: U2FsdGVkX19DT4QTb7yAO2gZXpQfEDwdxmwUUMaDG9Eniinc16uV5Jyd+tH2s0NNUl4A9OW06jYdI4JircA/2kjMVg2ZWjX3tLc4Tu19bnBWr5wgzMXiHICB2GuySKD34U/mUJDyFXmkuSfuveU3pQemLUOFOX05XRnmOFX6uqQLObhkH8PQeyibIYubteSiI+0fDy52tacpaLCMaYj+VrTSyq7mIu1/+FZBJg2JDmmw6Nt7Ks42+fSXzKgkvThFwqgZyiqRZAJwuEqsCLpMyb5iOvI1QtpdM0JM4raXovH0g+hXD15Z6SpFoaDKffp3jLcJMXOu53ZfR6HzX5zM2aMUW86UR02slnjFrjsmwNnSnExM5HXKhaxGAZVC94EP8flDWf/uR2IDJdBQSZoHJpErVLF3vJHYH/Ex0kAIPORw2j4fZGPPc1mDLx2ExlaUBJExqSgxbnvS2TMHRFNR4jjA0bGGPbukYHgI93hSyJpM9ROpfqfM/CYJsmUXR2u5imRAB723CCiz5acVgvJKuTLFkT+zdJ5RwKPsOWiZKTJCbOi+VQTeF2CmPInZsFGOrmympH/lpyaJ4OVCWb/K24upX1kvUcCAhDh6F6HGJmvfPjS5gvb8o+gEBsnMLi6L0SoeX/XHMxQFcKxlRyVG/XSCxiONJ0xYa2pSEN66pWvX1F8B73mOUMf5if6N3nKAgNJ7iYnwwqX4SO953AEyA8cm+do8parvwaZU46cWUJWf/lvVKa1CXHHSNzqstp9ingcT6nE0qYU2m6CmMOZo9eJ93Dpyg1Ui3mnb3mvIr/Lh0v9AliT6qvfcXSbBCZIaVtdzbyvUf5frjbqZ67idkkdOIJuN2RFw5qxB/9w5MYnhDCq9kZvtFuB4a1z7eRLH3rqRp7svyEfHUzhFjwF/sTeidDJNaH33GYorKMaw1B8qklEAbhsCor4ZhJBllpbtbNI+Vsc/zGpImdzMVau S5fw/nHW 1FFSuQQ9wdGIhP40VdgsP5JRP8NkYvV5Kb7ymJNBjJhMZ8iiDl7c8vxfoB6t/1MCcqofQEhsRXjcdGS/cg2d4U2uNs2WjUSFXVd4kDXBEgbXLUOQiinH0P2g8WIMhfZpQXSYuLJAUaBps+Prv9WNas/VShOTVKxnHEGZNp2oA0CwLOmE0lFGIoKWGNZImwgeG44kOJhypey+0wGSitbK2TT5zh63YZ8J+56MKVU1HEXWyXCAmr5OvSRTTqerUIUF7zR6ZWh2qb8ZO/kG47ERSItPaRB+BlrF4uIoCe+TrjeZnRAMm/HoJTi+3Weizje+NqK3uDt0IbHP6vRB5NQjC9UrDnFS9ahNjEcubiX/EeXV+an10LeysaiG7Og== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 21, 2024 at 05:54:27PM -0600, Jane Chu wrote: > Added two explicit MF_MSG messages describing failure in get_hwpoison_page. > Attemped to document the definition of various action names, and made a few > adjustment to the action_result() calls. > > Signed-off-by: Jane Chu This looks much better, thanks: Reviewed-by: Oscar Salvador By the way, I was checking the block in memory_failure() that handles refcount=0 pages, concretely the piece of code that handles buddy pages. In there, if we fail to take the page off the buddy lists, we return MF_FAILED, but I really think we should be returning MF_IGNORED. Thoughts? -- Oscar Salvador SUSE Labs