From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B792C25B78 for ; Wed, 22 May 2024 14:59:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A14A06B0089; Wed, 22 May 2024 10:59:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C3F06B008A; Wed, 22 May 2024 10:59:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B3506B008C; Wed, 22 May 2024 10:59:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 714A56B0089 for ; Wed, 22 May 2024 10:59:43 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 26F041A1EB4 for ; Wed, 22 May 2024 14:59:43 +0000 (UTC) X-FDA: 82146341046.17.6B1F014 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id A2808120007 for ; Wed, 22 May 2024 14:59:40 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ca4A5aCk; spf=none (imf29.hostedemail.com: domain of BATV+8922119ceb11ce35ef94+7577+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8922119ceb11ce35ef94+7577+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716389981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u2+ROOHYbkCaIa0leCLabsPb6B7hDNDjI6pFITeWd6A=; b=kOO4lFuXo2cQQ2FVyFg9SDK2VpvqTdUfwxOAvzIIqpdtbw8eIZFIq1/rNHVgMOSNhfBZI4 J7oG4+5sMlDbXDT7jizb2CR3Vg4LYrHdeftHKl77uZalrsyH3qpwBWyu5rS0yexL02y1qi qV6Rk2onm0cjge35te38H1FKar9rtzI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ca4A5aCk; spf=none (imf29.hostedemail.com: domain of BATV+8922119ceb11ce35ef94+7577+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8922119ceb11ce35ef94+7577+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716389981; a=rsa-sha256; cv=none; b=rRN/CsdY3vDI3y8tpTJIgc4ykRu7aGj6qNVeDPPLG0eCFkRmdlmbi7titoFfI/UMXXKsrm 6AyCwSkpUk+A1PetJ+rR8IiChV/shtmNRL/onFw46Jq66j0Mm3K8FB3dSqFAgVFWlm85zL WO45LckXTufiKqUsazlsBU/nHD/JKEs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=u2+ROOHYbkCaIa0leCLabsPb6B7hDNDjI6pFITeWd6A=; b=ca4A5aCkkcOqMvTo1iBrEAKAXC vnzUjoJj7fWA/n0wodKzJBZCYbq+MYO67wUupXdDXIQwTHOihB6Mt+QASIv+pbZqLNFRcMESZSZZb YQEHw+V49/xvQrVphkrS4SqABj0isfUUQ0RpfXZ5LY/U0dXm7E/5iph8ts8gyzWOT2vZbS19Kovd0 X7/qpW7dQQpTmj889a02Ln4UDGMe4y+ywMvX2H5s9gaHNRqKKOzfrKAEFLabt3+UWjlrfZxqbvYRK EsbdR+n2SH/LLoyufLZteCHHjwgWnKwO4YaSlFescAXX0As4V4EtheQ6jIHtaSare6t3sNFqxo9bI qOoh2p+g==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9nRH-00000003Hvb-2vFW; Wed, 22 May 2024 14:59:35 +0000 Date: Wed, 22 May 2024 07:59:35 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Sukrit Bhatnagar , "Rafael J. Wysocki" , Pavel Machek , Christian Brauner , Andrew Morton , linux-xfs@vger.kernel.org, linux-pm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm: swap: print starting physical block offset in swapon Message-ID: References: <20240522074658.2420468-1-Sukrit.Bhatnagar@sony.com> <20240522074658.2420468-3-Sukrit.Bhatnagar@sony.com> <20240522145637.GV25518@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240522145637.GV25518@frogsfrogsfrogs> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A2808120007 X-Stat-Signature: cww47bokom9w64tabtjxwcza6ixe3ep7 X-HE-Tag: 1716389980-723197 X-HE-Meta: U2FsdGVkX18MjWJEiZFg7pDtjYJIs+YHSOj3mBDhJrGjW8WRHIUZ3UprjiUQgQy7jARCN8depp++IOIXLbpylMqLJv7WhzEIS/lTxByc3MrrkuvZRE4oX5e+rLgPfcJE/7aSKyjuZaZr6VHpEEXNT3U5REafwHFUumPwt9b9BxtATO8bN6Ys9OX1erTzWzB32rZak1abd8ZuVcoyVCJZ2BLzSOYu7I5EMaIlwDpNw4NMXIyo2K7g95eXhzlB57BXomGe08SCy2GbcvRJreUGlHYkLCbmxwvY778x5sLHSFHqsTTEv4oMsDbE60U8dCDgppx2J7ZnJEV1ALP+uA9ZZyFTsMcpl6uVnrrGtm4wh5SK4DWyritg8vP11A21kWomf16lep0q4hun1aWu/OoOyL0drETqHKDOqfS8rtZqB8ea+VdVD2T9jgiK4RpRdAVfzhWgJlYcXGyZBhCkj7VM+YOX4E6uH7gZAytStrSr5bDykTma5vMS7OtMeNAn2OzWisziSaSY5/Unbtgd4KGZFdz7tMiL+bTaaK2lJCF0WyXcz8jZgWSECkzZRd+LBaciFskOsoSozZSag+iw6xoJx0ulL3ZM5ld/tvzcOguI7yeLFIWLwOTf1hXv33evjzlcaPyCV2zyiSnpsgmxP2vX6MsImas8Lmy6dXUG0Bmz13hPeV7mABOpk/q1GLKf2HHeHZPKek5SR1K3yPVgWNlvWnK6M0c5+hI9pTBwa9k6a8u6NfV28E0WMxvYwK51xHYccFmw0imufttaANYURDXl301GDl3oaTGDYPTiPPCfdCAnbnCyOrps8p8dNPRDZRBVw8ZXCwFM8C1UNQbXdvc3RgQjPtEx7Fwuhbc29GodSMmpiNJk/GTpPCFbXG38Hnhq6nZyHO1cohWOOP42Blq+6VOWUNYHf6bkNzrNzoJSMh9v/DXKK37S9BC04gamO91cLInnCTjiFUCiWYFMmdT iSBo1M8M jbA4DIhRhxoMeEtVSYJNmlvj6wyzD4wsur6B2LCb0zKjww5qMLzL5fMMfa5dRv1hDfpBqgChN+oufG0TaVdTqcJuw8HBu+CY3dAUTLQ4v6Yoe+J8VzcFnVeFx/cvgb6anjzfcGKyciWtK87y4gUWLhbN1Vcbmv2iOXTDTedJi/nul6BPnanZ0XSxm6xIZdhKmpSNRng9cqlQcm8w/lgjNkQpEBVlDe1dKtt2KFRntA8K1tEDEGyyhuNThr8VNVQV11ltywi/huYcbD2y7+yOqo9YhKGhqtgqvHa//XnpvAVABCrIirRW1IZ7EBtz0fGvLNmuJOVFneuC4DNWOP4Tvt3HuU+NBzlmo0nXx77IzDgj+QKZl8tpGEPmlDzovFikv2C+aA8gFUcgHCbk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 22, 2024 at 07:56:37AM -0700, Darrick J. Wong wrote: > On Wed, May 22, 2024 at 04:46:58PM +0900, Sukrit Bhatnagar wrote: > > When a swapfile is created for hibernation purposes, we always need > > the starting physical block offset, which is usually determined using > > userspace commands such as filefrag. > > If you always need this value, then shouldn't it be exported via sysfs > or somewhere so that you can always get to it? The kernel ringbuffer > can overwrite log messages, swapfiles can get disabled, etc. Scraping a block address from anything is just broken. Wher is the code using this? It needs a proper kernel interface. Same about the warning crap in patch 1.