From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5DE4C25B7F for ; Wed, 22 May 2024 14:12:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 509F56B008C; Wed, 22 May 2024 10:12:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 492DA6B0092; Wed, 22 May 2024 10:12:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 333F36B0093; Wed, 22 May 2024 10:12:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 13F616B008C for ; Wed, 22 May 2024 10:12:05 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 837AF41755 for ; Wed, 22 May 2024 14:12:04 +0000 (UTC) X-FDA: 82146220968.03.BB3875E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 0BA6716000B for ; Wed, 22 May 2024 14:12:01 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uEqWCsrX; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716387122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DDbjOB44ewZWIRltYmOU003Ll0k98hPAJ99V/6Z7rjA=; b=QeWphWZ9+StScsjbbSGG95ohLb5hrE2QgRteZl/5BP650gXFYnO/azNrjKNd777OJ2kgkI p+0Y1QAQiEx4+rvlAHoS+vuYYZ/QHMYoIGAja7OuFuHYn9cZ1xb5tE25GWfatozY1Weg5B jpTYBrzNhakZ+yUoG9oW5O9TD2QkZHY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uEqWCsrX; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716387122; a=rsa-sha256; cv=none; b=lkp7eFrZZxWhaJtNHBCQxt5vMq6r37cm2oGPah9NbKWBpxE/eR+WZpIgoPyLeikbReI8RB tYlnrSMUTGBYrW2lZeGNEIZ3eKnMwEhkVE5/7WtbteayMb6Z41RJUe02yERf2PZHnYmMYE 4JyVp9Wbt2CDbyu4LVgFwc7xqIzmO54= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DDbjOB44ewZWIRltYmOU003Ll0k98hPAJ99V/6Z7rjA=; b=uEqWCsrXiGnYASDuZAU5ot6tQN XjK1e6Gll8ojSe+3yON3pJfsrV/kkCYvTRBFnNjTzHHovDzW76TQ9M7XXcZxJl+XUGSqoBlf16Z3/ ws/+xgLky5OQhAsn3kwnQvcJk+AupZuZZKMGcHUQ05G2fM4NbUT1MU27yCBL9e5yt9wzfYdeqEd7f 5SIqFwucxPtY6LnnqhJj2qtrW01//jNhVTzviw0Z1MPuZJaUsj5V0MODpVAWb0q6O41TT4558Mtr5 UpW6InBw16BU72NmZLAcfB3Yne9fkNbuFw5e8QnUXbXOmcXrCJHk0h3tgJGNj8infSgJrpr7NDIjU ASpsxliw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9mgx-00000000iS5-2uBa; Wed, 22 May 2024 14:11:43 +0000 Date: Wed, 22 May 2024 15:11:43 +0100 From: Matthew Wilcox To: Sukrit Bhatnagar Cc: Petr Mladek , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Masami Hiramatsu , Mathieu Desnoyers , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] Improve dump_page() output for slab pages Message-ID: References: <20240522074629.2420423-1-Sukrit.Bhatnagar@sony.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240522074629.2420423-1-Sukrit.Bhatnagar@sony.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0BA6716000B X-Stat-Signature: o7e36dmmrgto9apad7jica8aojm3x96z X-Rspam-User: X-HE-Tag: 1716387121-245228 X-HE-Meta: U2FsdGVkX1/7DCwtt5A6NiBtarjP84JMCoxW8jffRy4rxqFhelBhLnKbp8z0qcKuAwIw21sOdXIwNNPiQ54fZ6gtOq2OMzxbtAAh/3+Hig4S1/2kcSe/ISXI/iwQnaEchqbGV1egHk0WsEMiG1Dk5kt5S3ek4glCiKNhP2dGR4nWMijc+wzBK7g2i2h6Fiv8hO6H/GAP7kcz1y+WQXztErZGkNktd52d8MVTR56peLmw7CwYztQpNyYzodqNfpPcBm3Irki/kNOZOEwCfBmib+f4RJGj0wm/045CkHAt1fMvtSzAsmnnaGqQXAYnAKIrvcLpf+7VX5PIk1U/XPwXopdeiO/Ko43Rw7R+ISozqfLqz7CtQOwFhITfm62AufnAZaYpVCfWtjvrKMxcSn8kSXB95DcAbu/vwbZf884q9kxiNpuW5GtWD9dqJPOZTNgQjok8wGpz9RtJD2IE9Kz7Z25Xl2dyT4ID9EW9S0KADEnv+fN8oxLG5wHHjGIHiyQd+J5+hcKPOY6WTRn3pgeIXGtxcI6VTGGMafCv4wYw1pE5E4IhM6ir6cCfva79Y3M8huKWXNfhM1k3TMOKd4QqFwBTaY6iu2OgBzbds1gemSIXI89PiProxixgcuN0LZVTFb+yIgcVmfroXqrQpkwZif/TmggRRFRcNy7XcP50amkAFy8wP17NPoxpdUoiHGdWhpRojCX8gxbbuKRLnvnOqVZ3KoZd4HfhzwDDJ/A05lLYM9ygPOG22Oymcd0ErQwjizs2TzQZRRHiYhG8wPh0/Tu432ini5Nqga7mUXsbVsn8GWdvJHBpI0BvLVqU4JC3h7gpogYXqbz9jzOOCFZzbD5rYHwTMKtnG89HW8OsZHOr0rvQ7HyzYnQdu1U0YD/RWdvwNEISuJCBvzGKdlQJ4CJt+7H5vBY2zLo0Y+0iGLb5VlxDab2IfMEYBi39DUDGhri/BHmBNHqJxYal3MM nVsHn1br Hrrkn+nEfMuWTkhLOfeqYi2iy5U/VshxUCT4juFhPV7COaBjydvAcg4E0gJLu+CEsmlW04FYcsvCH3aaBd1jebpKFEwBWXkUdh1blHdZww+5e68LX1r4Nboz/68RdYS9rsz6KrlBo5lyTD8UOOKpV7ErD6y1/uJO2MZOqa2qDGuO3rWD/VuvqtY//mUUqH2f10A9BaTUGzq31hRlqQl9Xq4IOgth3YXAxHWxCJmMrzRr52cxKBgHT5d3Rw9A3Ojpo7ul8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 22, 2024 at 04:46:27PM +0900, Sukrit Bhatnagar wrote: > On the other hand, the struct slab has kmem_cache which maintains another set > of flags. It would be nice to have these flags added as a part of the debug > output, and to have a convenient way to print them. I don't understand why the slab cache flags are the interesting thing. Seems to me it'd be more useful to print slab->slab_cache->name and then you'd be able to look up the flags from that, as well as get a lot more information.