From: Brendan Jackman <jackmanb@google.com>
To: David Hildenbrand <david@redhat.com>
Cc: Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>, Michal Hocko <mhocko@suse.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm,memory_hotplug: {READ,WRITE}_ONCE unsynchronized zone data
Date: Wed, 22 May 2024 14:11:16 +0000 [thread overview]
Message-ID: <Zk39BD7NPbP7WJOz@google.com> (raw)
In-Reply-To: <9c23d824-f2c7-4f9a-ade2-e8dd3a0d30af@redhat.com>
On Wed, May 22, 2024 at 04:05:12PM +0200, David Hildenbrand wrote:
> On 21.05.24 14:57, Brendan Jackman wrote:
> > + return zone->zone_start_pfn + READ_ONCE(zone->spanned_pages);
>
> It's weird to apply that logic only to spanned_pages, whereby zone_start_pfn
> can (and will) similarly change when onlining/offlining memory.
>
Oh, yep. For some reason I had decided that zone_start_pfn was fixed
but that is (actually very obviously) not true!
Will take a closer look and extend v2 to cover that too, unless
someone finds a reason this whole patch is nonsense.
Thanks for the review.
next prev parent reply other threads:[~2024-05-22 14:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 12:57 [PATCH 0/2] Clean up hotplug zone data synchronization Brendan Jackman
2024-05-21 12:57 ` [PATCH 1/2] mm,memory_hotplug: Remove un-taken lock Brendan Jackman
[not found] ` <78e646af-e8b5-4596-8fbf-17b139cfdddd@redhat.com>
2024-05-22 14:27 ` Brendan Jackman
2024-05-22 15:24 ` David Hildenbrand
2024-05-24 12:02 ` Brendan Jackman
2024-05-27 7:53 ` David Hildenbrand
2024-05-21 12:57 ` [PATCH 2/2] mm,memory_hotplug: {READ,WRITE}_ONCE unsynchronized zone data Brendan Jackman
2024-05-22 4:25 ` Lance Yang
2024-05-22 8:38 ` Brendan Jackman
2024-05-22 9:20 ` Lance Yang
2024-05-22 10:10 ` Brendan Jackman
2024-05-22 11:23 ` Lance Yang
2024-05-22 8:42 ` Brendan Jackman
2024-05-22 14:05 ` David Hildenbrand
2024-05-22 14:11 ` Brendan Jackman [this message]
2024-05-31 16:41 ` Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk39BD7NPbP7WJOz@google.com \
--to=jackmanb@google.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox