From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD996C10F1A for ; Thu, 9 May 2024 14:57:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 564A86B0098; Thu, 9 May 2024 10:57:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EF676B0099; Thu, 9 May 2024 10:57:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38DCD6B009A; Thu, 9 May 2024 10:57:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 194436B0098 for ; Thu, 9 May 2024 10:57:41 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BC454802A8 for ; Thu, 9 May 2024 14:57:40 +0000 (UTC) X-FDA: 82099161480.17.CAA52C6 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) by imf27.hostedemail.com (Postfix) with ESMTP id AC2E04000D for ; Thu, 9 May 2024 14:57:38 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kxCQfYmg; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715266659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4bqRwrBrqoa19SvEpE/J0OTW8kDuORQv0JaSXGHN1Ek=; b=bcnGDlXPbz5B/BteZ+AfaQj4dX0Xg9Ja1+257+8p0jlcyCVs0WTgWmhPynkE3431Il4wxv 3qIevGB/GysbqR8awdmnfF3WvLbrUcO2moBywTGbcMtKs9wrn8mrRbODZzQVMPT7dpxMuh JNyeNYC5o83bWFDiXERxoK3I/3SHEbo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kxCQfYmg; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715266659; a=rsa-sha256; cv=none; b=RRbd4qB6s/5fmzTdC/B9+Bm3OtHNYoRFlq8oslBXwUAIfmCOO702lqfdXVLtSdl/pKg1iE Z3/uCGfxvcU6kjx+DxctCFcN9Z/Efj5ddPNQuCyQBXJBEJLLGSsXB5XsWq36C6GM063vD+ 29F2GnVy2IeIxHZuPpNwLBeqkIUBfxQ= Date: Thu, 9 May 2024 07:57:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715266656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4bqRwrBrqoa19SvEpE/J0OTW8kDuORQv0JaSXGHN1Ek=; b=kxCQfYmgzEJJatutIe250OnBWlRlo3hl0rMFNu4PIDHKKj1dWF70b0tqtevbLXEA92GBTF RlfANb+akKXuenK3bTOYzQTSYYtt7Jx3KFZLa970lk8To8HJFzQoenTQITyUzc9yu1ZHZG oHraiU/TxtBzp5MZEMF7y5xFqg6Ey6Q= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Johannes Weiner Cc: Andrew Morton , Muchun Song , Michal Hocko , Shakeel Butt , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH rfc 0/9] mm: memcg: separate legacy cgroup v1 code and put under config option Message-ID: References: <20240509034138.2207186-1-roman.gushchin@linux.dev> <20240509142205.GC374370@cmpxchg.org> <20240509143635.GD374370@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240509143635.GD374370@cmpxchg.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AC2E04000D X-Stat-Signature: noz8o8zdm36b5s18jemrwdzfufhuycdf X-HE-Tag: 1715266658-907354 X-HE-Meta: U2FsdGVkX1/BwB//+MI6RGc4bZEK5RM5NAYWvOOki0SaXD+A52eecbcP0OU88oa+qOTETvWKgHwoGibK7Ua8IdnlZujdHFHH++5GPQbJaH19l0ypAWkFFHz2Om61ezIiehNUw5MdE9u5EYSoix2BUSNpuyYLCPuW84Nf6Ik4+xrflwdzSb9HXKAu8HHHw4yy2s5TqVXPWllfh1e5mTp58RH6qODxm+gq6yxaJLCJi/tzS9wyyL6vZwIJpW7xuqqVYfKk5DHsFD9ETLe1HwvouX3y2Us+GvGfMcJGvtzdy/AO1y7FHhfedIJ8yEWKZG2EIyNN1sxwLaPXmUMb5QjYGcfpK8JUFC0xBCXj1WN75hrwAX9Sd2bDaJc9BkJZ+xReNafJgl1Vl5JYkeRqFMI02ajwYZ3EBMi/SCmEilga8OsM9oxPP7AuTASVYUbUqjQViZCvFtLYZxcxkEMuDDJlxyUN4xRHvX9Hxs9Rdmk0t/bnG1Wx0nTArTZthBEV63XzDVklOUZECZU5jINZu5gqoK6YCHeabN79/12ogqoYO5seyt78kO8onXN6ZbNVxbdNEklyncHAepOUVm2u2a8ENn4k7LEkIAMym14YoQ2cnCxGjpOnGky/dvA+rS3DdGLRbRGKpDAy6o8qaOfzX+7JMs2bOm/ncGvoID9ROhfJZilAhnibDchn8kE3/ygt9O6OHyjgWKNGtH8NlPfqupo9dOS9ujNASaSl5KLdiraiWAI4UDwuptemR4+Vn4JDbxDOYvh0b8Jkc8kGjOWQzZEiS9/Xfsi0oAqpO0MHLnbQOJtf2RpZqNJnojwoqflSwwaXd6WyNKXquFjOTAvCDtULIqXRmKFCgCXlzvPXMH8grdyIfDL42W5cdDosIBJn5kek+uqLMZ/bgXRCR991aYetWeyIbjMa1h06elhEMTeJXGb7DHXKfkKa7/cz54BmkBg+BN/SkJC84y4FuD4ECQL zLUJDAVc Z+GWhfAPBLC0FsuLOTEx8qzEAVs+aiq7mjhwUyWPiv56TMqelV/EwnNpTfJjdJsjrkA6fbo1HEAesluf4+ta9OTEvnMA3x9yH0R+UsCONw7KHGeag4oJAQN3H5XTJUImLbuBZoj+6Dd3EyCQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 09, 2024 at 10:36:35AM -0400, Johannes Weiner wrote: > On Thu, May 09, 2024 at 10:22:10AM -0400, Johannes Weiner wrote: > > On Wed, May 08, 2024 at 08:41:29PM -0700, Roman Gushchin wrote: > > > 3) Is it better to use a new include/linux/memcontrol-v1.h instead of > > > mm/internal.h? Or mm/memcontrol-v1.h. > > > > mm/memcontrol-v1.h sounds good to me. > > Argh, there is a folio_memcg_lock() callsite in fs/buffer.c. I suppose > include/linux/memcontrol-v1.h makes the most sense then. You mean put everything into include/linux/memcontrol-v1.h? And functions from memcontrol.c by memcontrol-v1.c into include/linux/memcontrol.h? It's an option I considered it but the downside is that we're "leaking" a lot of internal definitions into the outside world, because memcontrol.h is included everywhere. So maybe mm/memcontrol-v1.h for definitions shared between v1 and v2 and keep exported functions in include/linux/memcontrol.h? There are only few of them. Thanks!