From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E344DC10F1A for ; Thu, 9 May 2024 07:49:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 758756B0083; Thu, 9 May 2024 03:49:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70A006B0085; Thu, 9 May 2024 03:49:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D0956B0088; Thu, 9 May 2024 03:49:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3E0AE6B0083 for ; Thu, 9 May 2024 03:49:06 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AE07C81500 for ; Thu, 9 May 2024 07:49:05 +0000 (UTC) X-FDA: 82098081450.07.6EFA85C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf21.hostedemail.com (Postfix) with ESMTP id 7DFAE1C0004 for ; Thu, 9 May 2024 07:49:03 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="q5Hcz/HP"; dkim=pass header.d=suse.com header.s=susede1 header.b="q5Hcz/HP"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715240943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iwS77UEIDIui68vRbwx9BsX+4DYZiA+lBLJ3muE9lSE=; b=avEmNW45sorttZiqVuU4M/rdHQXOfKcvkd9GdcJpP/FTHwvOgRYJJYlwwoyy1EYTxjjkgp H/OMCPF3UAhY2eRfhDku3jBSfKyETF4cR3SN+wPI8ZxCrIJ8VYhGTXPWOhHdRCVK2pcgvR IceYnQCwtGjJ7BAKhOQ1nnrRACf+TFU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="q5Hcz/HP"; dkim=pass header.d=suse.com header.s=susede1 header.b="q5Hcz/HP"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715240943; a=rsa-sha256; cv=none; b=Q8tDdvmePITis74c9c0ZQlQVwS78jxP7555AKURTcgjWkLGnaB7UBB11J4yhRQFi73W3gz uJ2xTWiA53kYvV4RSmZkIg/5K8+SPGexrira7jfaUuqDWRj80N6Ifam+r38IvbHcaUZHXL SxleOyAHcVw50Gau5t+yWJjmiP6yH6k= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A28A05FA04; Thu, 9 May 2024 07:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1715240941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iwS77UEIDIui68vRbwx9BsX+4DYZiA+lBLJ3muE9lSE=; b=q5Hcz/HPTPEbZVRbLf25WP16dpAneCdFIqp+3UOpQl6GzhmOzloD9a3aQUxBHiH2WhHooD L1W73nBPDGlG2ANr1SWD8mTmk8O7cl6iEcn6Omyr82nKEeSKQJ1NWRxxDhXOjXF+VFPa/a tAMw5eAnXNzHyr8m+dcBWyhhSX74rW8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1715240941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iwS77UEIDIui68vRbwx9BsX+4DYZiA+lBLJ3muE9lSE=; b=q5Hcz/HPTPEbZVRbLf25WP16dpAneCdFIqp+3UOpQl6GzhmOzloD9a3aQUxBHiH2WhHooD L1W73nBPDGlG2ANr1SWD8mTmk8O7cl6iEcn6Omyr82nKEeSKQJ1NWRxxDhXOjXF+VFPa/a tAMw5eAnXNzHyr8m+dcBWyhhSX74rW8= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 76E4D13941; Thu, 9 May 2024 07:49:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0y4yG+1/PGb6EgAAD6G6ig (envelope-from ); Thu, 09 May 2024 07:49:01 +0000 Date: Thu, 9 May 2024 09:48:56 +0200 From: Michal Hocko To: hailong.liu@oppo.com Cc: akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, 21cnbao@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xiang@kernel.org, chao@kernel.org, Oven Subject: Re: [RFC PATCH] mm/vmalloc: fix vmalloc which may return null if called with __GFP_NOFAIL Message-ID: References: <20240508125808.28882-1-hailong.liu@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240508125808.28882-1-hailong.liu@oppo.com> X-Stat-Signature: pntb1s91x9damsx48spjnsoiw7z16578 X-Rspamd-Queue-Id: 7DFAE1C0004 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1715240943-695731 X-HE-Meta: U2FsdGVkX1/N3ivVH99TW4XOb0YSuaRCnWNJnaDildPPB3t+gUpxXRZDU1plttzJHT3v4Y37CRGk0UmneoQYXCimcqhDeLa3fE3khlKNqG9yEZloRponmFnDa8o5g6bhHFEL7BpVFkplbVduQ49mEJgJ9gKPECHcmxVmDbkINaJN5g0GTS4O4vSglSt8FgMZ2L+Op8YLEH1KFEbUB6LC62ISqOYfCN32gH25VDlSRAHdSAmqK/UYQ43mbr76YixzyNDa/7D2EjUUNP68r/BAxxnVQvk39aR1U25E9i/OePgZ9KJ9bVMZyuisl/2LEKDOuOJNJjfLduxPacL+ui0/j3ToDxZg3yCOriKuUpvBnddWAnw/ngCEAJjmW3V8I6LPd5BJbDi5FpwlrKXgyFsV3WkOzdGP79vfZDbtg6pLeyCiJ4BpavbTTnVtov3+xO4H31WM11oC7S8hQZ3xd/q35e50C7VqHf94NttN4uMKPUsC4rQBb8CKBvjo/U3Klv2YkeqTJGSGMM0WiRp+I1yukK4jis9G5sbQARcx3xwvE/qjGWIZEZDTCoOkoGqRULIxWOGd8K5VTwhD98TSDFvG3xPtJXnor+bQSPWRm5ISd2d6X6JuSoDa+XHCNUA+6FG/g/6iwdyAqZi4nMqh3crauK9XLCUGQ6bzwsYXHOIFpFMimRWrOHb7JIKPvs/QmiOqelXe79SqdNqAG7ASrBQDXJOXFK7lUQarCi2uCIHzdsG4DzGS2/EgfU0BSUGKcmsgMEXszsYd5xegkyqZ/PpR4dJ1zE9hxXaNNRnOVYVdIyTvSP/GWlE+vAfSFT4e0AoS6Ck7htXdpT6jsTOy4VZTYGmPTKo6YdTW/C4Ov/ef+yzC8YmDRrHW8gDxlLGbX37JOqz9skgCrtLY69egDW6M4RG1aAn7LF5Jls2N1QPILbwNA8/Br1gRi037+EzFTlEeUbpOFIsaKWKHvgbSfgI V+nJwUPv 9VCoflYBqF4bw5WqzXyXePf0Xm/Xuzz7Fu2ZE0/wkLipcsvJMbxuWYm/jCHxZtrZ6jhU+vPkPEdiCZYJUHN2DHH/yIfS7m9xsz8EvfX1t79izDVdVKYTQd7kpDmVfUxJXwQ9JqT68KHnMd0a8BPd+tcua4E56rGgaujOOflwY50ZpYReIzH2RUafv7+n45kuQy695xYnNq4cS0f+kcgtu0+kCJDWTOQrSnUnG+ULlPlY64yP4IBTRKV9X4epISNN8zsrX7J/rn5RqQBhc5zRyXQrUkeVCALs1aBQSIDMxuUFgaGKWlLVJqEkwdLuHzpDFzz2E6oTxJoZhly/MPrBo4bfQmNu4dfIMOhZXwaHqxfD/OxiPoayjhx3Qfe7n4rIm/kYf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 08-05-24 20:58:08, hailong.liu@oppo.com wrote: > From: "Hailong.Liu" > > Commit a421ef303008 ("mm: allow !GFP_KERNEL allocations for kvmalloc") > includes support for __GFP_NOFAIL, but it presents a conflict with > commit dd544141b9eb ("vmalloc: back off when the current task is > OOM-killed"). A possible scenario is as belows: > > process-a > kvcalloc(n, m, GFP_KERNEL | __GFP_NOFAIL) > __vmalloc_node_range() > __vmalloc_area_node() > vm_area_alloc_pages() > --> oom-killer send SIGKILL to process-a > if (fatal_signal_pending(current)) break; > --> return NULL; > > to fix this, do not check fatal_signal_pending() in vm_area_alloc_pages() > if __GFP_NOFAIL set. > > Reported-by: Oven > Signed-off-by: Hailong.Liu > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 6641be0ca80b..2f359d08bf8d 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3560,7 +3560,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > > /* High-order pages or fallback path if "bulk" fails. */ > while (nr_allocated < nr_pages) { > - if (fatal_signal_pending(current)) > + if (!(gfp & __GFP_NOFAIL) && fatal_signal_pending(current)) Use nofail instead of gfp & __GFP_NOFAIL. Other than that looks good to me. After that is fixed, please feel free to add Acked-by: Michal Hocko I believe this should also have Fixes: 9376130c390a ("mm/vmalloc: add support for __GFP_NOFAIL") -- Michal Hocko SUSE Labs