From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E730AC10F1A for ; Thu, 9 May 2024 04:52:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8181A6B007B; Thu, 9 May 2024 00:52:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79FCE6B0082; Thu, 9 May 2024 00:52:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 641F06B0083; Thu, 9 May 2024 00:52:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4993F6B007B for ; Thu, 9 May 2024 00:52:40 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BD175A204F for ; Thu, 9 May 2024 04:52:39 +0000 (UTC) X-FDA: 82097636838.14.820C0A7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 205408000A for ; Thu, 9 May 2024 04:52:37 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1OW70ydo; spf=none (imf02.hostedemail.com: domain of BATV+16439c8c750d17eda2cb+7564+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+16439c8c750d17eda2cb+7564+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715230358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GK8skucNd3RCC7HoRVlzYUTm9Wu/E1K3l93ozVZHIl4=; b=rbMbc51g+uKbJmsfjmm8HlvLpgajSt6z5IT14gzL8oUDxzv8/C2M1Q+Z+rqdwKMETPPpPs EXFknEXa8gPP+sRTUdGZj7U2N8MC3Mk7TfV7oy6j3VQlva43DR2mdOzVtgY5vIjiCp4wNZ 87skVk5k50yI1M7fCHMBjXOSe9tcHIg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1OW70ydo; spf=none (imf02.hostedemail.com: domain of BATV+16439c8c750d17eda2cb+7564+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+16439c8c750d17eda2cb+7564+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715230358; a=rsa-sha256; cv=none; b=IrkB6sTZ/k1Lj+fD7AC3isq4UU9YOSVuEhyAZNJvRWJkXdV6nGmgZkBTcrXVF1Qd3epCjc 5aO6J3v7s7rV4MH6f5dj/JRwiKTlGuNyL6yBYX7SVSd9J+gNIYJP6ilLyxvW3AZedTlXwY NOSXbxq2GZYE9eAw5dy6dc+giDIBiYg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GK8skucNd3RCC7HoRVlzYUTm9Wu/E1K3l93ozVZHIl4=; b=1OW70ydophlQncbAq89LV4LOpR RK1UsHgA2PsqhlFa2fOeQA930u3Tf5bjmO7rPHIZ7dFjFa3oVfeOA2hVTSSYphpFF0A9EG/C+qpJ+ E+/H0mlJP2aQijinCkU4GLG7D+TFQesTkEskQQHwpO4Addc0W14z7MRxOUPn3N1Ndzwkd1D76BWSZ loDlz6ZS0wrmRnEf71ZYAGZEq2Zb0CVTxieMj16/gDXI+KcIAaYVzSbLyZ7WhI+7cIC6MkpczAXXF 5xgOkE3yG26chVjNbKmVXoCVz7eqDRSjv3qsP4XaCousiMdcxVHO6dUNCm0K4qhNbq3nY3rgAy3t5 +dRjscYg==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4vli-00000000M7q-3CR3; Thu, 09 May 2024 04:52:34 +0000 Date: Wed, 8 May 2024 21:52:34 -0700 From: Christoph Hellwig To: Barry Song <21cnbao@gmail.com> Cc: hailong.liu@oppo.com, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xiang@kernel.org, chao@kernel.org, Oven Subject: Re: [RFC PATCH] mm/vmalloc: fix vmalloc which may return null if called with __GFP_NOFAIL Message-ID: References: <20240508125808.28882-1-hailong.liu@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 205408000A X-Rspamd-Server: rspam06 X-Stat-Signature: 4st5p4jigccw6cjb3q3ywy6gn8m84pia X-HE-Tag: 1715230357-822332 X-HE-Meta: U2FsdGVkX1/MTlc0HtwcA1GoSEw+GQBZKLzWxSfBAB6k5JzhmNmz4n7MLhVLAjJVJVn3YU9cTIM/5dYDqskOXLuoSo/nOj0nyL+oh6nHMHeXMievsilCKqSFEF0LpYlq2ObHv4M+Q7AqFK8/GH7KRo6QbLgFfNukSAsU3BI8XKXxLDHSl3Z8oYk50pp3entUvYszmmtomyEdl7esiQuqnXNH1LH58M9YvfcCb/JEpgcd/qZpNdujcamAxcfFZE0c2w9gCMZk6GGv9c4uxj3UQIX2ayrEmUEWBKoWpowscgNVdYch4+9vM9OLnRNkUMAEnYgroTqIquYeDN6r/36sQdL+8va+0Klwg1awKO/pRc1yrUzqjgrZkxqSDj0tI1JEMWdkkpI8P6t1R2wceGyWWBwiyXIdKcSJ+Nhue4Oo3joBlR1FTT1QoBuWIwpnZB3PDmMkVbeW+rCjNDEWcO77BHAzsuFXa1AXODGJSlpo6t7AQAFEamZXWCtuOqLuIrilYrqafNue51L8Dk+vUqym4dlBtQ9as1HHrBTbGryLCWp1PIey3v1qDSRXLtDFTaClNXHw0jeZ/JkfPzLx5Z8RMJ+xnI75IQJCDiwUBkuZpmtyxAhfx/Ao0iY4JriAbP2ZCMYesP2/EQcBa/jFgQ9sdq2EzTclRecu+1c1U0eEJUP2pQGcstpsGXajtYcME54sRdOSKzb8t+pO9PXrHRwbd4HatVpkpPdmQbQKa/uAu31sEYGi7NnZgn3/llcag2wDqxc+nDTORc/ax7biwfL3YQsxMfZ/Nxp/jww4c2VvR2WGGZTtD0RBoT38qawmHpuYCFN7AC2OpVQNzfla9JS23A/QhQInl7qhXutHeD/BKFf3mBSsRuMFR+6jJ9ok4AnqRG2nUIn8L7eow5DXwhqbww73yPYrwWq2YJvQt/ExI6qTF7ll+PHjMfqM9PDN+MUoVIL+0pqomtbQelONsUG XkfbE3gV bUILMiIQi49FKRiq53560+g/xydVJ3D5tet9rRc0eWcGBoATdScVc3PAejrECR/3w6dTADXyvSE6v9abVGQSA9ZzO8csfCPjFd/c+XfX3KPdJ3jpCnHuszu1yTxm6k7gnuBbrt6EC3CDOf9PLplHI2zFjdoGZY/QUfBWo8ps9SmcwThWXERWFV2057yYOQVAUA5WE5l1txRoxg4IWBUaBMf6q0JAWEDfebjxEZmMuysnUiJ/VLboHY2D7aYFF6NRm8IHBoTavSbnXrJDPYOZn4aaSYiBb4jVVPmQeMQw7A57qKgAjTTlfgbAhAOmuMXOOTdiTpCm4a69HlwrPaItq9FHF41brs2auBKq0EYH5wbgSonghAFkTqje8cvxwaqOruv/t5EXFaZtVWzC3zTqdkGBaaKIFNcGP0GgTPx86dOJ4huvHKbN5pH1VuQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 09, 2024 at 02:20:03PM +1200, Barry Song wrote: > reverting the fix intended to address the OOM-killer issue in commit > dd544141b9eb. > Should we indeed permit the NOFAIL flag for large kvmalloc allocations? What is large? When you don't allow actually use cases people will just reimplement it poorly. E.g. we'd probably have to add back the XFS kmem_ wrappers.