From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A4BC04FFE for ; Wed, 8 May 2024 13:54:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B15C26B0092; Wed, 8 May 2024 09:54:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AED4E6B0095; Wed, 8 May 2024 09:54:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B57B6B0096; Wed, 8 May 2024 09:54:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 773906B0092 for ; Wed, 8 May 2024 09:54:45 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EE6DAA0FDC for ; Wed, 8 May 2024 13:54:44 +0000 (UTC) X-FDA: 82095374088.26.257358E Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf02.hostedemail.com (Postfix) with ESMTP id 38AE380012 for ; Wed, 8 May 2024 13:54:43 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=l3mroVm8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of 3IYQ7ZgYKCFAAws51uy66y3w.u64305CF-442Dsu2.69y@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3IYQ7ZgYKCFAAws51uy66y3w.u64305CF-442Dsu2.69y@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715176483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qrxifLi18HwIXN/paZijnWPdESXfJJzxe/+u8UtVff4=; b=v4LaelsMbemmXXH5O7rOqC+OiRffP07/iH2xwS4cjU7Tl8B7gyXl9dQJta+uWhtaYl4EJo kjTfMF4dFPGWsQ/buyIw57kR+bNnO1l1lQeBaMM1FLZyAcqXHQIwXfqg1pC8JkWxA3NbOy HpZ5mB8CcjwNDycbjCMKYlc6itXpVnQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=l3mroVm8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of 3IYQ7ZgYKCFAAws51uy66y3w.u64305CF-442Dsu2.69y@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3IYQ7ZgYKCFAAws51uy66y3w.u64305CF-442Dsu2.69y@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715176483; a=rsa-sha256; cv=none; b=OyvJGMpmfL/WwP8TkpLcPfIg7o1JjkDuAt+GQ/KhMsPfnnmTQ7plYaGt1ptMCC213TPgJR HG/gZvyEcknrpTXnBKZyQi/W8f5P/jgq+f6PR2JZAHQyHwEWGfm4JCxqvlkILXS1dbdlq/ 8UnuWtt+zIFb8lNQi12YSP1ksGEpX44= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dbf618042daso8058019276.0 for ; Wed, 08 May 2024 06:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715176482; x=1715781282; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=qrxifLi18HwIXN/paZijnWPdESXfJJzxe/+u8UtVff4=; b=l3mroVm8ooFptw51Hxb/MAYrNqUQCiAV5A+dZbiKw6ZTx7fDlPAyn4e5xHM3K19dfD GRME3VzavyC363KM8mjI9fQWP4QX8Qn1FAs1T3zey0uC8EA9Zg+rZ8g78dXGTjApp9ew E2k76QL3otC8L8dBPti1oaC+g3Eruj5RZl8Whm1Lpq2ixvejoc/fcS0EMRBHDcuxjqNp 0Nwo0o/7TpQ+H6t4R9BcEjAMYOPIyyr0ETSYmNE3LXBcjk4d2KWULrpt5RHSdnZc7ebt CiszVt6d9k4R7516LkWcYtk09pYXuVztPHUZ4ygB4IowuYamsGtJl/e2QCQtB36J3aW7 x+9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715176482; x=1715781282; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qrxifLi18HwIXN/paZijnWPdESXfJJzxe/+u8UtVff4=; b=PzVETKZiK08M4FFb8LoafN6EFRmCADGeB/jX7TcdJNKMXZUa8M5qjj/nbLDv45YuY6 9ofNxUUORlZuxrZfUJ/HFc+z//AssgKuRG6KsVY+H2ezmeFp8ZifbfrEsU/FkJAXVqHG /uB1eyLiciLTUr+0+SSwwbICCI7ohxsezQ2EwpCk1hf25C7T4/1kYBhdUVqLh4QiULWX Ldb9T/Wqb+bHN3A4+m6krUcDCusecDEI6Nf7MBK8T8VN3GVEQ6nn5ECAeG29vg/XQM/v nHBcoifWAq5xDh9NGK+PTL5YaVURcufkPtP/MDLVOO8VGhVCQCiGyG9/rxl0DxNf01yP L7mQ== X-Forwarded-Encrypted: i=1; AJvYcCWMqKbthWKPPEiTcIm9d3y8BF0PyFETvFbqDopVEO+4+W9fLPEMhXKDmcAoe+9ioqv91T20ZY1kQ3F/HC/30lamV9A= X-Gm-Message-State: AOJu0YwzGG8M/2zOoITVrY+UPiwOryr/y2gXlc0LDdorQFMcfYmzvfpF KQhF82NrHfho1KNfZ3/sefsn5d+jfefECFQDdSeNOgYuJHO+YQ/5+8pkLZRASV1iCanE3Hm7E4e LUA== X-Google-Smtp-Source: AGHT+IGJRBi1UvMX9yVwIeeKPJ5i4MXrMA7fvNEnU0sh0JI0w6+2/9z2FlMIObyx5JUsUOMhiA6kQPpm0zI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:18c8:b0:dd9:2789:17fb with SMTP id 3f1490d57ef6-debb9cfd19bmr223701276.3.1715176481930; Wed, 08 May 2024 06:54:41 -0700 (PDT) Date: Wed, 8 May 2024 06:54:40 -0700 In-Reply-To: <20240507214254.2787305-5-edliaw@google.com> Mime-Version: 1.0 References: <20240507214254.2787305-1-edliaw@google.com> <20240507214254.2787305-5-edliaw@google.com> Message-ID: Subject: Re: [PATCH v2 4/5] selftests: Drop define _GNU_SOURCE From: Sean Christopherson To: Edward Liaw Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , "=?utf-8?B?QW5kcsOp?= Almeida" , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , "Andreas =?utf-8?Q?F=C3=A4rber?=" , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Server: rspam01 X-Stat-Signature: wps8c96azd8kqendeqzpphqckueyjnru X-Rspam-User: X-Rspamd-Queue-Id: 38AE380012 X-HE-Tag: 1715176483-902329 X-HE-Meta: U2FsdGVkX1/EkifJgLbZeeDEJRMjJjt48LKxT9//UFm6Q9oip+INtjFm7qwBvAlr+vomN2XoCIjTptiC0ADqK4fq4F6kCDHO2r8fzdr/T9lU80QzxGUEwwSdxYiPYREyrWgX6wL96So7oary9kHirDNRqtVbesTco76PL1Lw3oT7WQg1bPAd4LYjsq33RIkB2RXYnxoj9nn+WAwUak0nF0E9ox/JJbX46IWMGpxYGTS2Cz40ms2FyvYtFRwM2OEjpFbQ0Psd67X3FCZ1Mi7bkeV+4AOO+dUqmyW4StilgqWJ3fqKq7ZVLCVhoOl0860MuJoQ0Ep/5CQmTlv/PyPNQy10kQXS5v97WnRygwlYqYW4wiLr+QtrfDyeMhXwV5S2+xMQU8PrjZo7ltfLfyrrFpWuNSod9SaXEv9OrFIkitxh5zxWzirMUj9z1a69uYNzc2Aebz0ZA+kHoyIhEkOpvxa0n0XjqCaFsWHJ4FzO2NW+Ghrpkr/aTpddjlfBh79lUyW76XvhnttqLr5KaILKBOXL+o8OEMin2e5uo1EdoNVnYsH3rvAeMWcefB3+QvsX8MQ04+m6BAXs1tf8Lkvrq+HabThYLxz1An5iBzrdiHudeKYgxIJkLORWQXF9abakMRXIY3e0ABwhZWtSHlaZhOs+/B5a5EV81Rf1fXOiQxETB0nVTjYYzOv/0mwhci0lNFPnhLtQbPze9qeeA3BERP04XlFIENuw5jY209Xiw74J6dDFGb7sl3AENyJKjaU4rAKSdX2KMpvpS4QtViR7CL2FSTM7saI3j11g+G2jyEqL3qckCcX3MastsZ4FCahRYibJdeLP4hBHKDQ4j26kcSyoPdKUnOYcKkIGV8AJkDx1dbj0iEdbsPB6MUYfEzA7NpawnPyw3Sg7ZQRrkv9n9KepBR4so55UJR7OOMXaQgSQhTNFDrqZLhgHmKaBsq5uZGdBf0GBU5iQfq7oeaS Zgg6jYoX hAHfI/8U4dCHU+G9PJ72TyeUN1qEYiFazJQMHG4AROpT8F9KFgonZkUPStvoVpFpUPZcp2r4v3J6crnRGonGbMgl28THCT0A7IaSk7MY6wZ6DBKBEXTBlrC1uaVshNnhtaAX7h2hswbifJEBM3Qs69WBv+/8f5SsMHk8EK4gjagpTCGkwfxlbm/t6GXqaacZxPFGlDyhH+KASlyaNWWGSVVowlqZ3e+s4afSwhp/5hHKmd0GHv5gyW3+fJ62uN6ICCZ3jXVfUEx9Dy+yl9slm7+tqqsJVbxxyoEp/xQPNsz1SOWyzSrngySQd9hdfkAjf0pbD9ABmnr+4yxTaT1Zc41hOhShiXdHVdubUcVcXQ6qPHXs3NCcfsY74cLQuRc6gA8p8O8G/jNDRc4t7nqYHbihQKxRUJhCnKVnmBgpflWdsrbaeTNmZ0vFhg+oPHWfMk81U71sXRz9KMHDyfR/xe3NbDVqGX+Lq+b5hjsxqOuROIPjAzP2dET1qCs4idoh/Oy2tKtKbLaa2zK2r72SAmbwWpsnKXgSobH0s2gAQ4oAbDIdTJdX8Q7ekAArP74krPXeRcYyN0DdensKxFw3qxGrdWrtMJkuRk/1ZtXID4znv1VzsOq4eaL6XY/A0Pxdd8exOIztzD+/hPdorvIsmo4s1av8SBlRoL/oc28dmqJ1uUN3YqpcvzTstZyoNObz9qghNbjtzGXFH51o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 07, 2024, Edward Liaw wrote: > _GNU_SOURCE is provided by KHDR_INCLUDES, so it should be dropped to > prevent _GNU_SOURCE redefined warnings. ... > diff --git a/tools/testing/selftests/x86/test_syscall_vdso.c b/tools/testing/selftests/x86/test_syscall_vdso.c > index 8965c311bd65..5cd13279bba5 100644 > --- a/tools/testing/selftests/x86/test_syscall_vdso.c > +++ b/tools/testing/selftests/x86/test_syscall_vdso.c > @@ -8,10 +8,6 @@ > * Can be built statically: > * gcc -Os -Wall -static -m32 test_syscall_vdso.c thunks_32.S > */ > -#undef _GNU_SOURCE > -#define _GNU_SOURCE 1 > -#undef __USE_GNU > -#define __USE_GNU 1 AFAICT, manually defining __USE_GNU is frowned upon, so I'm guessing the __USE_GNU stuff is just the result of misguided copy+paste. But it would be nice to get confirmation that this test isn't doing something clever. Or at the very least, explain the removal of __USE_GNU in the changelog. > #include > #include > #include