From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA02EC04FFE for ; Wed, 8 May 2024 13:47:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5437F6B0082; Wed, 8 May 2024 09:47:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CC456B0088; Wed, 8 May 2024 09:47:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36DC16B0089; Wed, 8 May 2024 09:47:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 161DC6B0082 for ; Wed, 8 May 2024 09:47:08 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B981E1C136E for ; Wed, 8 May 2024 13:47:07 +0000 (UTC) X-FDA: 82095354894.17.5768545 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf19.hostedemail.com (Postfix) with ESMTP id 03FB81A000F for ; Wed, 8 May 2024 13:47:05 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=okqZQ+xx; spf=pass (imf19.hostedemail.com: domain of 3WII7ZgYKCIMzlhuqjnvvnsl.jvtspu14-ttr2hjr.vyn@flex--seanjc.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3WII7ZgYKCIMzlhuqjnvvnsl.jvtspu14-ttr2hjr.vyn@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715176026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9Cy96MEbs4JLv+XlnJDrNT2CJ2qEQRDaH5Qu53Pf8ZU=; b=JkV6LgkfKzcq6Z3mDVdoG2haGXVdV6pr+FdhIySTxpGay3td1WvAlPG7Rq+iVolyE0Wa1Z 2/vIYT+dEYV4zocH+jnVcjC9KNTup1JJpujRr2VG3eHDcKvsXzoHwn//jQTAV6ns0bK3OL x+yDslh190+0t3gnsA88C1QJwC/sTbc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=okqZQ+xx; spf=pass (imf19.hostedemail.com: domain of 3WII7ZgYKCIMzlhuqjnvvnsl.jvtspu14-ttr2hjr.vyn@flex--seanjc.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3WII7ZgYKCIMzlhuqjnvvnsl.jvtspu14-ttr2hjr.vyn@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715176026; a=rsa-sha256; cv=none; b=nsQ+03IuuTzybTaOwkNwfhvKKwCTJ2hR/3QPlUzYCI5G7ZHt99D56Pd/x4m747TqjcvKu2 dus9P9g3MAMWqD7dnNM4hBby+MsjxsA9ESSiJBO8wT7B8YBySlSkZihhI30nqMRTzx4jlb 8FaFVjcS1r6QKzykUzsYJgh9c/oOa/c= Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2b2a8bd5ee0so3637211a91.2 for ; Wed, 08 May 2024 06:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715176025; x=1715780825; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=9Cy96MEbs4JLv+XlnJDrNT2CJ2qEQRDaH5Qu53Pf8ZU=; b=okqZQ+xxXEb+arWj9KoGhlnrCFs5kZBSgjIjWFn8hNIQ8wBWuf7Xgb2eJWC2kILRX4 qxNNJd+zEn6B8sZk9CLUTRW4lqfwPXKdUgXQ0NuSwaA2hY11lXDiL4XtrwhtsGqGf4Df G8v8CBai8HR0bBf1nykTqS678hJB4IGSyAFAhUoxqGDwhtXbyn0AohBVqxhfdmdueEAE ccj4dCYPXw5RLN9WaBUYONdoduQcicY3R9RxWz9jPTpnQ31V2Zf3puEwIbGxoTYF5aRs RyUUlHWZAqaaZH4P7p9q+MJrvzU/GE8SlVBBqumnZMkSNwozepDDPZCMTpPxf67RudlV Clgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715176025; x=1715780825; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9Cy96MEbs4JLv+XlnJDrNT2CJ2qEQRDaH5Qu53Pf8ZU=; b=WlpG1B7iL5eSCws/3sXw5cSD47OhDC+y4xK7i2kXyBytB88ZqGXEYeY1RRGKIhMpsz WDKfBk2lvO9syhK/4O20ZfzLpwxBaOzxllD7wRYMe6cqDiFdzlS91GlRv2XccZJLvlZQ QHyLsxWi+fYa2h3GMxjx7Dl2/lixrueDHpHE+OESPzKFp+R82CA5aEpBMVw9jTYSw0u6 sPOS47PQW6S3mGW7IC7RtroJFLNdHMS4ajnPKMAqrkuqnEqBqexykJdfmVVOija6Z6lD EW+cpxp2n27qrrZbDyL/K5ZH1iIGy1Dh5Tyb/yCf1oX5EJEZGMgBXyjC0Opxvcr8UAWS kABQ== X-Forwarded-Encrypted: i=1; AJvYcCU717uaO5p+biOAmd/d63itiBFf4BatbFjDlzP4WFlYnoU0EZhrHk7eO0nKZBnKM5F8vic5O+MBWCLxbF1Zh2v9d6A= X-Gm-Message-State: AOJu0YxygVoWGQ5lj36LQn1h0gKlfqqulQLoMel8Q+P9yOBOtCLaOuH5 qGyN13vU7rhkfGqgUQtTcZz2wIe9gJUEaUsJLeFcdsvegohtjrksJsyLweijrelTW8EZ0crcMA/ XJA== X-Google-Smtp-Source: AGHT+IGkEzt3rrLCYEAc2MIkDJ4rSudkNPJV/ZI7YDr6FjDNwR59XbPWzyPuXmQfxq7n/1Jp45z9S3futCA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90b:128d:b0:2b4:32ae:483e with SMTP id 98e67ed59e1d1-2b61638c780mr8658a91.2.1715176024465; Wed, 08 May 2024 06:47:04 -0700 (PDT) Date: Wed, 8 May 2024 06:47:03 -0700 In-Reply-To: <20240507214254.2787305-1-edliaw@google.com> Mime-Version: 1.0 References: <20240507214254.2787305-1-edliaw@google.com> Message-ID: Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using From: Sean Christopherson To: Edward Liaw Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , "=?utf-8?B?QW5kcsOp?= Almeida" , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , "Andreas =?utf-8?Q?F=C3=A4rber?=" , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Stat-Signature: e1dhxdmre4y1jujudkymghbw6nywephs X-Rspamd-Queue-Id: 03FB81A000F X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1715176025-993656 X-HE-Meta: U2FsdGVkX1/rtur4JoGweP8ow9DqoUElU+YNhE52FdXUvVgzSPk77LQLsbB2QQla9kEr8ljlqhkTlUhTJ7wrdQn8+pGFAGOM9BflotYgXIdvs6YG2DTgSwijveTR89FzF+Cxelx0oE+pUjkzbXVlxlotMxsJhPahGN0a610fV2DODj6l6lFSclQcD1Q7lq/0pXcMdmFiKp+C/GDrGNPfGFdySqPG16gnLsPmxn85sDtSfkZAkBu1DYNoBZSplxzVpoTMI1UevE3pLfb2fxqb6lYupIm8CyQTVQRD0pgET6vaB6Nj86RSRZsHmj8S7gUl6TLnGm4eV0cf32MQ4qTpeFBdtJWejyRasJJpF/bkF2TFkVSdbTLces6SAVJOrd38G6gGfE4KfEla+bJeeRlxEQxEC6039h/vUm6gJYPJnqc/G8ntri8Q7iESETZ/u9lP277/D4Zt6pXPL6xVQ3OPY2l3MYggocAUfcjL6KGD4P2pn1WDsB9OyONJSn1Jv3UbSTgOMWmPBqtWu/TDgbAP5TkSDGoOouXLIbDGujVzQ8VPZt80ZX3FoGovwmPuTb2c421IUwl+cfDnsNjzn0yuJskaVPpRp0gwShFTGbddibkANLCP/klwBv4Qy2sCVFn8kvH/8X0TOYf9/JP6rYuBlp0zZb6GEo+J8uiqM1795/perCuNmtAx9JSsNUi34g5+NlS70jfCTGmvswskIkStxS7oDsVsHNa65O4tgtdpG3bpjLYTTMvwoEh8hmkeQSzBIhFow68Wht2QJSGrv5Xf+lbwUH/KNDxloZVuX3wGSPkGIjiPzMqPwv36WXySOaevdQ2WXMNp6GAXI2Vky4VefpH/43meNDOBW3O8taGBMkVrwZVL8kwm5SJGaDXPWffMmGTFovUmNH456XbEakT5Ofr/InsKpgGh6OblCao6TQJ2QUd8MDCev7Pey2IGk2I/SncQ9DXimWzMUDzFDH2 of8vozT1 OGpJ3dIRXsb27ORY35xrbm8ErXDbM2AxFV/DrciK4aqwIPWjHcl9pJVIxi2gncrbAqcqFejVW+qJzy1TdR7y45+EKxZwDko3ssEAsjpuYF0o/eymaOXLLMWw4ONqpP8fbz0SfrSiLcgx/ySpGG6i1+ocHdswjbYTxh+joTHVmUGkbBIyhurlSCwEuR7O1fKGvjPBf7yVtT14wISvNKGH3f4KNdcvv83uXuBx//7INCmf+vgZueUCscZ6sBUm3icMHHZYNuNPiQcdeIpk72p+R9tx2Wwn7VY7EOwoTTLOnMPfpCjH6XDeA8qHOtc3+0pXGDIOZUp6SLFf+3UqRsP4SeKwh3X710Vmb0clS3uxGhqZr/dPjqXzimvs1S0GRz/lHp0+A1hybkqkiNg1+GPYMnb6ma9gYVpJKW9+TBa7ib9F4Aj9iTj07yDiWRrR9zARGV8mkTad5UIDw/nYdU5prybbCQBEcJlQ79gxho2wD8mc+76ik5IqgUWuYPLouqyVssJT1f9UlX+Sq01Ua84Ra4nkYp49jtwF8upNiFcTdyffqh2tyJGdKqBCur3WPD/ULFpeAe8/fMXMIByBo2qTBA+vIhk0jECS8yFE1iw34RzN7OgZOMnSLo/2HxB7ucSraxkpo5qMkWyvnUUzcOPN/FmDl6uvnFfqkCBz3EuORQIQmteFGYhzqV8faRjE2E0t7iB/Vb1NQKuSkqTmNZ9SCK54DfvEd5P3NqjF7fOdbIQNKpt89IUz1SOLgcOIj+LZARHZ/75nRQF+fjT9fA4djl9H2WmciFt4NdLkyolsVaDpUrvIKguOvlzTkpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 07, 2024, Edward Liaw wrote: > 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > asprintf into kselftest_harness.h, which is a GNU extension and needs > _GNU_SOURCE to either be defined prior to including headers or with the > -D_GNU_SOURCE flag passed to the compiler. > > v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-edliaw@google.com/ > v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single > location. Remove #define _GNU_SOURCE from source code to resolve > redefinition warnings. > > Edward Liaw (5): > selftests: Compile kselftest headers with -D_GNU_SOURCE > selftests/sgx: Include KHDR_INCLUDES in Makefile > selftests: Include KHDR_INCLUDES in Makefile > selftests: Drop define _GNU_SOURCE > selftests: Drop duplicate -D_GNU_SOURCE Can you rebase this on top of linux-next? I have a conflicting fix[*] for the KVM selftests queued for 6.10, and I would prefer not to drop that commit at this stage as it would require a rebase of a pile of other commits. And I doubt KVM is the only subsystem that has a targeted fix for the _GNU_SOURCE mess. If we want/need to get a fix into 6.9, then IMO we should just revert 809216233555 ("selftests/harness: remove use of LINE_MAX"), as that came in quite late in the 6.9 cycle, and I don't think it's feasible to be 100% confident that globally defining _GNU_SOURCE works for all selftests, i.e. we really should have a full cycle for folks to test. [*] https://github.com/kvm-x86/linux/commit/730cfa45b5f4