From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D992C04FFE for ; Wed, 8 May 2024 12:06:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25B8C6B0177; Wed, 8 May 2024 08:06:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20B116B0179; Wed, 8 May 2024 08:06:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05E7E6B017A; Wed, 8 May 2024 08:06:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DA8D76B0177 for ; Wed, 8 May 2024 08:06:01 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 92B04141487 for ; Wed, 8 May 2024 12:06:01 +0000 (UTC) X-FDA: 82095100122.22.B57D48A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id CDFE3160028 for ; Wed, 8 May 2024 12:05:59 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h6b9ritU; spf=pass (imf08.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715169959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nyz1qBX4AhSejr40aGAqB++CiOKmtDB7Y/C9c18/WZ8=; b=WTWA9AbkDaCLd28rHqbgoSzLVBwJ0ve5Ln3hcwL4UDvBF/EHCiGGAfKbrHTNozyUEwtQN9 vfn6e7Qgf97dtJUgAOhcV+5kQH5TFD+m2t2K+b6wIzgbbUyhu9TG/GcQRdDHkLFc4enBCy 2kwYOChb6Frni7uDsNkBxXsCruF1kFI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715169959; a=rsa-sha256; cv=none; b=CsKUT+h3FsE4Bgpbq7AXZ/xve8+7ya6lR8SJABTA617vzKW+LaoLdaQMFnUmLE6w5UH4yr 1DFNELZZaWiUAQAonGjnMI844xYYrgJnty2GQTDgliXNg+DvOwtvM8h2WRmK2CnBg/w3Jd hg9JcUWoeZU3SKXxh0o54f16OYyaKRk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h6b9ritU; spf=pass (imf08.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A663C61B86; Wed, 8 May 2024 12:05:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E81CBC113CC; Wed, 8 May 2024 12:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715169958; bh=Nyz1qBX4AhSejr40aGAqB++CiOKmtDB7Y/C9c18/WZ8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h6b9ritU4vQNxnTR7eE3vrl7XyG3xhiGCQ3mm6aJQRCCFjPFC/Q1hWuJjhy4l+Qax oR324+ZD/1B55q8u12dgWy3sRKPw84A6m5/lJMNbU/ZfkzUlIfv9F6M4Qsr74SZluv Ri6pDOnK4BWwAhDMhF58vTUbpuAZdeUXISMowuweeAt6zvNRRwALQPzA5fLGJ57Wbp 2OEXRdD82ue1m5gsxJCTrctUxqpi5AwOZDXrAU1DFHkyJAlciUx03FDgas2YXkWL4U Ezxdp3UnYRZZhJByl5oD0Rz2BdBs3ecBvSz1FhVaxAQRSNofS2jvXx6H85WK8jvqHo 58Yjy/AMTsjFA== Date: Wed, 8 May 2024 21:05:55 +0900 From: Mark Brown To: Edward Liaw Cc: shuah@kernel.org, Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?iso-8859-1?Q?Andr=E9?= Almeida , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org, kernel test robot Subject: Re: [PATCH v2 1/5] selftests: Compile kselftest headers with -D_GNU_SOURCE Message-ID: Mail-Followup-To: Edward Liaw , shuah@kernel.org, Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?iso-8859-1?Q?Andr=E9?= Almeida , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org, kernel test robot References: <20240507214254.2787305-1-edliaw@google.com> <20240507214254.2787305-2-edliaw@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fwllAq8yEacRp/F5" Content-Disposition: inline In-Reply-To: <20240507214254.2787305-2-edliaw@google.com> X-Cookie: Accuracy, n.: X-Rspam-User: X-Stat-Signature: bpykz1znxiur3ifehc6us6drmjfhsqdk X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CDFE3160028 X-HE-Tag: 1715169959-581800 X-HE-Meta: U2FsdGVkX1+y4FkWkNTOm3S5O4bhq973hRKwzepp+4D+rehGHGqjGNB8qFmWLrcNuwQzNclZ6HHvrKcgdysJggizm7dD00TuOHawfE3dUGKoK48hxSqxJKlhg70kgOlRwWyqrEHiXlpDRZ6ARuJPs7woYY6d/yRQc1kc7iOCtcGdWy3OBBBCSEdAed+6QrvVM3oy7MIX+mRnMWU+/M0AMPyPEkWW6gqfTXouFiY3mYJfRkRzyFhPJLjxGvC5SNDa/uRRj8/f8uuTR2bLZuQMQhfyZGsrafoXs7DJiyhGqQ4cvK1ADdcI9/CI3FSyIQlc5EUPDOd0LqPoEHpEgdrGIy8KhXDnwLjQkMXpYUBXqNlwmfJ/G4NjUNP2M8k9spR0wwb1FR0tjlKCAkofRBb1ATsQjJdsxRFQNqsgdeLWXQhcj7s0W1q5gbQjouF+iICd/ZcRKzygcxyxAfiCqP/nBCvryuZx7XX9TTeof8cbytRQw/0jMD5GoUQE4Qmlmd37RJWNU+2cyw3SzSDOe0On+qTrYMLTlsAr8RpHv3Idk3u6n1sOQRk7+9q+xWh3BJKnwHdM98RSU2TeGjXAzJLxZKeMfzlCWXXLAAhuHwIkUOLgJpavZids7iTM9qN3l2+4fUrS1ljC7RQWhKFtZYl7NmDAM+9+8buX9xKTQVjfoY+QZwBHlBvi8gqorA5td9e//FTjuR84WGjLDz9IP0rQBVp5Ps+47kGAxi+M1rWo9+e1Z0szdHgUAHbNK+j+/Chk4BWHx8x7Fy04LxUrwFqtbSBs700iHZVJKYLcVhTtweaYJGkRt/lf822qMplcKrAbl7n6YFpPTixh/90QpVtZu1pD/zhdlOqXv1pgq8eFNi8CeZdFaZC+dNkcwMNFQ+tOWfMkkcr5/VYbxiIULU75k/Z6pj2Gg4Sz3mhSk9pERAGov9Wc6OMC9hVTWBB5X+DN5bPZqpklvR9EJWckmKV R0Ffb+8+ knOKCMYRHUmbJWt7Umvskx7al5MiSpTksGKVYYSr4UAVRVE4bXSKpQSpWfhgNcpsjhYKPDQGHJHS9n1iMZgHJo/WbgPRQsEHNZX9wTUBd+SA6nMn8XaVsfpFkYYYMNqyzpgxpm8ECAdbTylc+vWZvwZPq3J2Uo5f1t9JIsuYd7OxjweswR8aVG8crr0N9/sAb8+Y2U99yjV0Ug8Rjzphc1OYVPDM/Tcmsa5TP8GaCzAWGRhpBGN/27pgVo6BsUOOebLEeeY8xMhWAGqMOMogGTYcMblYHqOeyzQUnNyydTPCsDUUqv2dQIV/qkfSZx0GHrBE4MDYlTVa2/z0grNMryOFBzg3I0zKdiJeYdQBkaGOCsXcgudTEWnD+mYLtjYyewjlX+MZfGlGO9DdPev5RCBkhvtSzaUyjvLFcnS/gcMinAGI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --fwllAq8yEacRp/F5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 07, 2024 at 09:38:26PM +0000, Edward Liaw wrote: > Add the -D_GNU_SOURCE flag to KHDR_INCLUDES so that it is defined in a > central location. >=20 > 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > asprintf into kselftest_harness.h, which is a GNU extension and needs > _GNU_SOURCE to either be defined prior to including headers or with the > -D_GNU_SOURCE flag passed to the compiler. Reviewed-by: Mark Brown This does mean we define _GNU_SOURCE for nolibc (and I guess any other libc people use like bionic) but hopefully nobody's using the same define with a different meaning so should be fine. --fwllAq8yEacRp/F5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmY7aqIACgkQJNaLcl1U h9DCxAf+M+eUS9Sr8Cy7bCTOxGv4sZGiJ7AeEEoR5TzBm5SOC6mKe/M0t4SexFRB 5nAjL3TO9i8cfMtUMh6LMvciaa5sGVNRFhpTIgljvO7ND7Dv+WKpJyiicl/1DYIK DEdpua8OQJ4bz9PQwOZO1kgQzC003JRxY0Gbz9kk8ie58HVAodSSWi7kgNsMc/0t mKOumN6X7MhAoslboc7h3A6xymN8AHvHeNga3yP+1E84M8mjiR91sc3btIn4Wa/w 6LIqTSCun/wuxeQnkz0Rlk1LdA1F0KQPzQAriWxju8K9dqc3prqYkWuDtRVYN+Li LJAemrTmdlcOF/7uoi1Z7s4wZajT2A== =IlWr -----END PGP SIGNATURE----- --fwllAq8yEacRp/F5--