From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF005C10F1A for ; Tue, 7 May 2024 16:09:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43EE66B008A; Tue, 7 May 2024 12:09:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EDD96B008C; Tue, 7 May 2024 12:09:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2902F6B0092; Tue, 7 May 2024 12:09:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 064966B008A for ; Tue, 7 May 2024 12:09:52 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B30EF140384 for ; Tue, 7 May 2024 16:09:51 +0000 (UTC) X-FDA: 82092085782.20.CAD5267 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf19.hostedemail.com (Postfix) with ESMTP id AF11F1A0021 for ; Tue, 7 May 2024 16:09:49 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GYgFcoZF; spf=pass (imf19.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715098190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tgzIR0YD+S9uWGtbeF9+1URxHxfb+Er2kUk5GWowswQ=; b=omq0HlHG2pxdJ4fG8W/TLXDiN2iA2Syckol83hDGpIU9kflXzUeQmQ3n1ss3xr4G7EMCFD v5NqM31sf54Ni1eb9kenBcoPXOueDIytPctUYAWHJq4OaPa2vTD1VI+YNUw8Hua9JZgPbJ 42Sp+9rKauk/fLjQUKEN5HGFQzAWG44= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GYgFcoZF; spf=pass (imf19.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715098190; a=rsa-sha256; cv=none; b=R0nQWsLQUjpum8nC7XpP4ciSdTwSNvsiujWTOQKf8Itx8bFK+AUSIPFPC7bWQ/9ny+/BFa CIcZ0Hxqa5DO9M/3OSQUHkILJWiYp26MoQauPgLQsN6ysNWdCrMBM4V/05fowI0E0YcCX6 MMNSr32MK41dYAG99LG+V2p5HMm09iI= Date: Tue, 7 May 2024 09:09:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715098187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tgzIR0YD+S9uWGtbeF9+1URxHxfb+Er2kUk5GWowswQ=; b=GYgFcoZFHdDT9O8zbQNUuBjwrw3TYPWDPuV7kfu2wxM2XY5R/zlVAaa7+/VEnmVBOaXaOb Bd0uwhVVj08huf6sHJBxSAABdmpRTNwO1UiflcVyljF+6UECf8ZIY5GV0zvOtF8p1wxO/L WOxNDSZLD9HnbXit5a7NqNimo/JxiqA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Xiu Jianfeng Cc: hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 -next] mm: memcg: make alloc_mem_cgroup_per_node_info() return bool Message-ID: References: <20240507110832.1128370-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240507110832.1128370-1-xiujianfeng@huawei.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: AF11F1A0021 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: xe6j97f4ko9rc17fkkbehr7yajhsgm7z X-HE-Tag: 1715098189-100378 X-HE-Meta: U2FsdGVkX1/5T61dTfec2Z3qUYskQvJFG9ZUIl8nOeoHc/9DCTQMDd6m/ABEmpnuLUiSlhOdcx0w88508CDfD+Zf3/NDgn//WTr6y/ysqdTdxLg8/IHApCAAmmZl7sG0wtkvY9tEjhWbucbYKMpOn7V7GTQ/te2c5XQK8urK+DUuofmj3UJovLE9aUdJud7xD8KIOY6Kk7KfTEji6V4nuiBeH+XbvUZoSrDHAEv6n9RrcZlalX8vlinSk8C4C2wBcZT86FvpMqmv9JQCBDopufS+m9J1Mn549l1HjDbtwZ1ydaxYkJFOns0lNFLY39rbw/xyjoNacJ1MMjX/kctWrnTdqIWr5D+0uliIVVI0boyb6xo37QKe1ZjMlCNJv0yONfa06C9ECCO+IfQkvhi8pHf00F/o7oh1oM9qYppypR8WiEtoZhJ7kOPxIU4k0HWLC9hiT3m3EpXE66rzjaNOANncSPnCw5c4mF3MIaXA6EKO25Yd2vp5lP3VRDVGyNm+kxyp8Mk9P12EAcp4E/yGlfB+fJ00WdzBStyzViifl+Vfh2UrnPY4aM+93+wJd0GwweSHFTAX+oyp4644NSnto/FeDLkTfIUB0oz3pbmAT+Tnl1v9szeBfMa2SEkkXnR99iOc3/gpxfOYvlu0rPlislZLcimdSNShoFA4P+Qz1iYeOMKdRiTm6Iz/C5JQXj8avSjNRQ14+fQtJPtN2WJ58HFeRs2qNMnM2R5kduWauaSJVt5RGYwOuVBaCKa2EM2dxQfMyeSCpxDfbYEPFe7o3TrKqYSA5GjviFjErYjDcyd7AvUXpp65Ou7VuI0QyKUccJN5ALC11K1SkMYXS10MKyo1nZFgLL5Mj8QKOGecDaJBTMWbsBt/sVQtyL3wMBfTg70DFuLDsWnMo45kvZ8cWDDkj3qtdlsjV1vmqaMr0dv/yHRHyPSwVd+bItk+g0UTmREKnuLOsK80ckPmKxW 12GxMQFC yKvZCmGNVNmKw96tMD08Lm8ISU92APqbxTel6YUuMN5hUlX44r2yIRZb4wJfIkJN+7saaeTWmGbySWVtO+bKbj03qzfovq48C0VmY2EhnP9QbiA7Qcak7XOmRRhub0WCWoFgLOr2ec2fQuTrs0Vtwz9uq/LMqSk6x33NrlXEFiu84x6gPCJcs78NJX56zt8XDfoe2dh5yxNs1N/0pYQtu2AuQGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 07, 2024 at 11:08:32AM +0000, Xiu Jianfeng wrote: > Currently alloc_mem_cgroup_per_node_info() returns 1 if failed, > make it return bool, false for failure and true for success. > > Signed-off-by: Xiu Jianfeng I actually liked the previous (ENOMEM) version slightly more, but this one works too. Reviewed-by: Roman Gushchin Thanks!