From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA7AC25B4F for ; Tue, 7 May 2024 00:05:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E11AB6B008A; Mon, 6 May 2024 20:05:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC0F16B008C; Mon, 6 May 2024 20:05:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C89116B0092; Mon, 6 May 2024 20:05:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A92D36B008A for ; Mon, 6 May 2024 20:05:42 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5562C16012B for ; Tue, 7 May 2024 00:05:42 +0000 (UTC) X-FDA: 82089656124.23.DBCF9F0 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf03.hostedemail.com (Postfix) with ESMTP id 5CA952001A for ; Tue, 7 May 2024 00:05:40 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=nhiH9azD; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf03.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715040340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/mO8RAIpI3ciXCmAN8uZAWkBK2a+XdI/Wl85E3eh0Xg=; b=iPI8fh4voX3rb2XMOyazeW9zhP+//UKx6sEV+4mc6Wj/xKRJVgSOos9z2uJwCI65XM06Q0 wYUs9qOokufcp997v/zmzqt9u8BCenjrG6Fba6++3ciMNqhWhqw3t1nyQcaNB71h8+f0WY MTspf8Ww02CoBA86c3HrwoOaQvlrNYk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715040340; a=rsa-sha256; cv=none; b=aCqPZ2RVMlV8wItTzznQOUuz5dMaVbOQJcmvhE/WYvSV4V/nXjjYvLBEJEanDoLeEiaWnR i668iVUee15o4NWqwWumzNT3BwtB89qdDlqWHxqYlMD/vIw0Pc8mIb7MkxcgUeCEXKUgSw FdGPJbvecoL1Z9KyI4h72CzbIKlS0ug= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=nhiH9azD; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf03.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=david@fromorbit.com Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1ed835f3c3cso23946775ad.3 for ; Mon, 06 May 2024 17:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1715040339; x=1715645139; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/mO8RAIpI3ciXCmAN8uZAWkBK2a+XdI/Wl85E3eh0Xg=; b=nhiH9azDx9L/sZ02/KrtKSHEPlodS3h/gNc4ZIfotnFlIh92v4mo5pc04l01fbmJag xANkrz5Qi/wgpna89CdkWJLRCc+2gq23aph6hHfaVZR9TxJi8lXMcjPkbDxVxxabe/Lb KVHouCQHvDzwTy9ubSYpfp6SuyCI3bN02j3dvb4oKapZTUDatvrlq/KLX+wQqb7ZZx9j YpMW6C912h5Di+I+DHJXaW4olpHoi3F2ydpNW1M+b/NHD+Tpls50amqVBZ2Bar1YdypW idDeqGxgicl5ueJTe9A0NLzYbisdtqKKewijMWp2VdsRqedLW47Sy83IoaBR2olo3tbR lYdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715040339; x=1715645139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/mO8RAIpI3ciXCmAN8uZAWkBK2a+XdI/Wl85E3eh0Xg=; b=dILSkC6Di/iExf/fiqKc6Sa48/ZfhJ2T9IpoJxd0fchVcyVDavx5gnc6eckmEfqrIe PyJwTtweICn3vp873aPH7fQeJeeO1t1KnLLmjT1qExbQUk/MDCaErYY+vYk0ai54wwDM 8J6eRbuo6GwzXpXr9wgqgw//Udmo7FKqfTIQl4mi9YoTry9M/9iCfU/9S5xzPna/k1V1 2iIgW3l1iHOvWnaS85+wcs6nnQU7X3NYI+PIhaMkVJrYnEMTJG3WQW0WWFkzDftIc84N JljwyJnRouHDgpTCcSjU5MH/dinOrvtfMB70XNQ7d377WNNvH1XiKtB+4UssDriAjaNg m9Pg== X-Forwarded-Encrypted: i=1; AJvYcCU7JehT7BKz00UngAEsPBUozEtQMqecZkpNKZJAQXEsTrR9H9/tnw3OyMdkzLade9nBLQm05a2z6Jaz+sttfBCXquI= X-Gm-Message-State: AOJu0YykJi2fvBEfRcqi26/I644y5gkVoO/4MQOr/dLg+Ol39OVeYB5Y y590HMoWgFTIVbGtPPRcYIhCvntojxCRibXzaEt1PFPP+QVa25inaeAgS0bSJfY= X-Google-Smtp-Source: AGHT+IFMS+uzDdaAPRHwq/U9jqHYjfdEca1j76tOxwxbkz7wqlqDtFC+MYf5HxlMEVl3x/q1hzXhRw== X-Received: by 2002:a17:903:2306:b0:1eb:1af8:309f with SMTP id d6-20020a170903230600b001eb1af8309fmr18304829plh.4.1715040338808; Mon, 06 May 2024 17:05:38 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id e2-20020a170902f1c200b001e088a9e2bcsm8829552plc.292.2024.05.06.17.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 17:05:38 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1s48Kt-006745-2E; Tue, 07 May 2024 10:05:35 +1000 Date: Tue, 7 May 2024 10:05:35 +1000 From: Dave Chinner To: Luis Chamberlain Cc: akpm@linux-foundation.org, willy@infradead.org, djwong@kernel.org, brauner@kernel.org, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v5 11/11] xfs: enable block size larger than page size support Message-ID: References: <20240503095353.3798063-1-mcgrof@kernel.org> <20240503095353.3798063-12-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503095353.3798063-12-mcgrof@kernel.org> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5CA952001A X-Stat-Signature: aoywo85e8z5tzrwafyqyjhm3usiw8xem X-Rspam-User: X-HE-Tag: 1715040340-257222 X-HE-Meta: U2FsdGVkX1+1jeDQRvEna98piMChPNykMzEa1b3dDYZpBBi882YJqYXwAtDEVMxLVClbBvr+SnlQXJ0Zxou8qeO/uNHrCjqMjfyI2OrVb2TI7MNUez6tTefuxaaayTWB506OkEApar+36hK60Ud5kk/19XRI7qrtUF4Mq90Ai1fnBMwyzhPqhKgDQuK81xmr0zzYoE78+mc4AwHOl67TrPSkxyvK7J9FvD8e5zgGsWrlDxWEKo+lV1gWgg/qPWHiOxDC5VDBEK+ekdZG3K3y08cr1033/Tre0MB3yWnoksqht0OrnUnAqGcqcVxKGsT6ZtfK58IoJDOiXdGb1LuZpscu+CWL7qOGmxWy3WvIiROQinD9+2qGFyqJfj3WKRTJeT/RVt8ULHsyrOIR1aDlJdqjVUodALwGh78FVPs9UIKlo8cSdg+aMxB1poGXoNBALGu4EAkQv1UlBL8RDT034635N7svZjZYIQsWmfttDuq6pbVtcqhgdM00njx+0LCYERMx8LFAMPSwOwd9uoVOQ1mdDscztfBQN8e4K7x+SE1g3AQhpVolfjWwJLSmYnIinOvS5NY2EPbzKfUjIZXPVZkZFegjTaRTmdKcn2wDC5oNcleaCy+WQskgPJjLILZ1QPXs5X1KZYI4XkRaJ6f+7/Kr1aWnxemFaBWIdZx2eAGxUEGmqlC8sfG/b1QA8e+QJbfknn4dlELdGx9KrpO4+Bteg68nzIS8FK5oqhydMBLHHrnJlOveu9y1KYiw2HapmICXgi/vWlKy1oANjZbUm/m1XxKnzG98oj6ihFcUv/1233qTAEuW+8Gw7uaa7079lTaMnqXKTGSbIiWnjBZpnCBO9AIPNFNFnnHxEENc61kniyDMZl0IVZBjd1QDBMr7HJcibBWz88rPvErZx6ajvr/lGQB/Mu7X3jrQ5JtiWUyQSmNsDRiC94VPBz4ZAfa6T+zyoZ/NEcBLru5zYIx 6Z13TzRQ 7bYt8+XGQTiaF/3hI2TfPi8w5VIhOsv6/hShcNgesEbssMQPynPZ5qY1ZbfwKZ2vF5A99E+te9DwS1hI69suyR/sNi1tQxwLwlavVjz6QPQeObzXRxKHPgOdhB15lJOTFTC3ZqOFceJ8pqR/wBXxY1H2TWhy9eo6apHEtr6oriQnRzSw7BFf9KlLYia6EVw+Q5XRWSyLi+JmHesMOn7EYUz4EyFsfZ6i8HL5UYmV0M4d1uwmTV9iAv3qHnzoDOXmxI9Py6eAp2amxc/sqFk9vNFlG7wdOKeowdKHZ9CA2ROChSCoCoiye87kqSEyDBLHSgmq4XLOHLQ1s1UWYPVR1RZi3a1UjjMfjkBI3fEEfjJ1Ea/ltpsK2bKGxqKpVcfJnO/E2w/SmO28IImIBOo0Z9Egh2UujRI2zr5Erf/j0pJKoNtdmGsYy0FSyTHRT9SSLQ1HbwGJkWjK5dipFYi9l0OUL5zx/+M6xC1pDizVVRADrZ1kWUDQDbzV0IBNTGvVN49U6Spl6AlJ/YvZWBw3Tun2mO2/mGfKAY8C0bCsdPp8xwXs7tiJndYihR2IPyLaKtQ9lBWpJ2Z2LW+bzNgQXCVBqXxPsnnpZeaWl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000163, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 03, 2024 at 02:53:53AM -0700, Luis Chamberlain wrote: > From: Pankaj Raghav > > Page cache now has the ability to have a minimum order when allocating > a folio which is a prerequisite to add support for block size > page > size. > > Signed-off-by: Pankaj Raghav > Reviewed-by: Darrick J. Wong > Signed-off-by: Luis Chamberlain ..... > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index bce020374c5e..db3b82c2c381 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1623,16 +1623,10 @@ xfs_fs_fill_super( > goto out_free_sb; > } > > - /* > - * Until this is fixed only page-sized or smaller data blocks work. > - */ > if (mp->m_sb.sb_blocksize > PAGE_SIZE) { > xfs_warn(mp, > - "File system with blocksize %d bytes. " > - "Only pagesize (%ld) or less will currently work.", > - mp->m_sb.sb_blocksize, PAGE_SIZE); > - error = -ENOSYS; > - goto out_free_sb; > +"EXPERIMENTAL: Filesystem with Large Block Size (%d bytes) enabled.", > + mp->m_sb.sb_blocksize); > } We really don't want to have to test and support this on V4 filesystems as tehy are deprecated, so can you make this conditional on being a V5 filesystem? i.e: if (mp->m_sb.sb_blocksize > PAGE_SIZE) { if (!xfs_has_crc(mp)) { xfs_warn(mp, "V4 File system with blocksize %d bytes. Only pagesize (%ld) is supported.", mp->m_sb.sb_blocksize, PAGE_SIZE); error = -ENOSYS; goto out_free_sb; } xfs_warn(mp, "EXPERIMENTAL: V5 Filesystem with Large Block Size (%d bytes) enabled.", mp->m_sb.sb_blocksize); } -Dave. -- Dave Chinner david@fromorbit.com