From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05C32C25B4F for ; Mon, 6 May 2024 16:18:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 785D76B0092; Mon, 6 May 2024 12:18:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70EBD6B0095; Mon, 6 May 2024 12:18:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AF5C6B0098; Mon, 6 May 2024 12:18:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3BD9A6B0092 for ; Mon, 6 May 2024 12:18:43 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DD6CD1603D9 for ; Mon, 6 May 2024 16:18:42 +0000 (UTC) X-FDA: 82088479284.02.81BD9DD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 00B5FA0017 for ; Mon, 6 May 2024 16:18:39 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bMuxHhF2; spf=none (imf15.hostedemail.com: domain of BATV+7ec5f3411cfadf841344+7561+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+7ec5f3411cfadf841344+7561+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715012321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h1ODgGE2m2OEgAd8jHSSbz3SpjDDWzrnbcCs/Pk5lAc=; b=p64l7BFXDiVzF9iB8pMr055k8rfK4SVraQuld+GSeTlIkXPONZGM9Wq3c5EekmEYJOw+n3 fMZ6vCs/dPH3zlNdolB2oT9FXAEZfWzvzU07pwSb0pSBYRwn7NsQMiKHmlgDQyuSwjOVSE Su5p7va6CJ8m4Sli1EQwE7TYjga5f0Q= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bMuxHhF2; spf=none (imf15.hostedemail.com: domain of BATV+7ec5f3411cfadf841344+7561+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+7ec5f3411cfadf841344+7561+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715012321; a=rsa-sha256; cv=none; b=du5IV0HeDQb00RygMn8NWWZArt3F9FmbddavmetwxLf7sMsUe5QqAqfjNCLLl6XFksjy7t hFc9uHbTpwBaGUqdK8L8Vp31EhbBNG4BSPTsRVCn5y60bY3WdvlB4NWYfV98FkSwonP3jd LELWi2/nR5tUn1EW/gq6K6oTFYGP+pU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=h1ODgGE2m2OEgAd8jHSSbz3SpjDDWzrnbcCs/Pk5lAc=; b=bMuxHhF23V2OWvmdmi4hKXKgc1 ZzTQu/fmdHL4ph7ohGu1qlDG6jTXSmG7rU1UUbY09BURxmrKdDTriz7tPK9FKnYdqn4XHFDKQ+JN7 8Hfc5AR9xQzTtQ/3abdN4woK/Na7wyH2o5JYueuWFCeWPJzElAg/wjx6OTiXiSo3vjukUk47M/HrJ pFv2WUBehexhoJHOMK9/JQEg8sv0AM1smhToD3pH4UQwccAZInCVdkwQaiQweO+cIgRdGTSyQ1EQ9 e3/yUN6O/GBIuc3cNvd823V2dLpUkS/qNmLdtUV+00RwAfWw91vaWaQpXaQiZV/0GfkBXnYEgRHqh rVccTsog==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s412q-000000082GK-2Fr1; Mon, 06 May 2024 16:18:28 +0000 Date: Mon, 6 May 2024 09:18:28 -0700 From: Christoph Hellwig To: Rick Edgecombe Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, bp@alien8.de, bpf@vger.kernel.org, broonie@kernel.org, christophe.leroy@csgroup.eu, dan.j.williams@intel.com, dave.hansen@linux.intel.com, debug@rivosinc.com, hpa@zytor.com, io-uring@vger.kernel.org, keescook@chromium.org, kirill.shutemov@linux.intel.com, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, luto@kernel.org, mingo@redhat.com, nvdimm@lists.linux.dev, peterz@infradead.org, sparclinux@vger.kernel.org, tglx@linutronix.de, x86@kernel.org Subject: Re: [PATCH] mm: Remove mm argument from mm_get_unmapped_area() Message-ID: References: <20240506160747.1321726-1-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240506160747.1321726-1-rick.p.edgecombe@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: asjcxqc7cin3tqq1t3y1i7wsenha5zaw X-Rspamd-Queue-Id: 00B5FA0017 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1715012319-912954 X-HE-Meta: U2FsdGVkX19jeVDVPJNfcC3+i0VycRz8UFO7X2vnGwRBXKR/UvLEud9JnNstpIOtkwIojz56djy1y2Zt+eK14fTFzEHsoMTjQ9zkrwPzALXJOD6Dp2PR8DOHLbL+8N1QrFdl+2zU1NY72CzNtP0z1VNtPHP5TM+5XZLCGOpKSN5KFHisRXDu93U0ORnXzujZ8km9TmhFBHOS9XyGXynjYSv/GuRo14ckYZcx9V9dNq/Ds9WKLzVyXQRQtxwCJdyxww7zi2QM5FIVPJhrEZVTeKkTc5k3d1+DxkG6/0RR8UuSWxdp2AQs+Y1Xdc+o/2U0ivueQNykxZSJSdfFBw1fjDc+r/yruUdA8dciMYiSFP67GIK8146lw61igB8OukaOBN595ndATJmCX6tlPpo0JpKn2l8gexGvhrfnRvwvXI86Q8lmdU6CNyHDgXw7CC7dGVqojQhI+2T59IVUHo/CbpP9By96qLZHjITxijiYmjPK9V9vYfsBanFjsQuLIRitCrslyu21hdFmRValFzrJ6esHXbNZNjEPlUtFIczflLWE3eUtMJ8CUSF1zCfywoDBJ0v6cR8AYoQ60WJKTrq/nZI9cy+HJgGftAMw64XlzIzRC/E7Fg8c9CuOqCX7ct8kz2c/9k4cE3gV2H/wt8y0zNxG+BZBx0PI0t1Y7cFxAWdxyc02/C2S48ez56WdJ8Q31cTJ51fO4m2iwF9vhlDVBpEneo16zUywY+KSFbwzuhJ9Orrwsi1duLL/pYRgNRzUXsW1J7QY67herzLtwDih1/2sIYWscB7fSn09+vDb90FIxYHrtwZ3+X83zF5GAuZttd/NFbwI83JhQFXq05SAMQuZ0lCen5l2Xs7qlenRskJbyi/40PdkwKT8RDzsEFArKZboIzBz+O7UEQ7lQIKDrnI0eDgoL7PQuJuEjG5bOYrzDQO88orizmYQ/LtnWq+OYL8OSHyl0Hq7jOPu58y /QHEqbyG 9pVuCrfzJSqEh8eyprg4nj2Kq5BZUDCI5Cnv8E59viQ85fU5Ls+TKPEmrcyAwXhFkLpkDdtGv80MBdSMCjKtgb15IwgdG4QMvMBFSHUg70yTyhIMkxKb3JMxwe2WmJQ81Krw3KCp79dvRoCG8/+DnUr28pe8B4KJSxKDGxf+Kw2qnlv4ATZeS4CaM2IhawUHkLM1D8S9GOmW5itMKDVRdl46S+9Gr2vY2paqgJmw9yLquMmLOSuw16ufgwbhHpQpZRr3W9earwwVEejY0pcIxz+Ci7eqN4uMT0q1Nzp66O45IHDSPOBywY/G2DH/9MYxPEUVg97AuSS3r5ncKO1evZUPbfiRtifuWIhJ4/XPIbUuOEnmLxZwJDZbjZcUL9JVSA9ACfobosox+nCAltiqr1AHipShYPooWebZ+hRaPKQUtv5D4uT7zSjM4Cw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 06, 2024 at 09:07:47AM -0700, Rick Edgecombe wrote: > if (flags & MAP_FIXED) { > /* Ok, don't mess with it. */ > - return mm_get_unmapped_area(current->mm, NULL, orig_addr, len, pgoff, flags); > + return current_get_unmapped_area(NULL, orig_addr, len, pgoff, flags); The old name seems preferable because it's not as crazy long. In fact just get_unmapped_area would be even better, but that's already taken by something else. Can we maybe take a step back and sort out the mess of the various _get_unmapped_area helpers? e.g. mm_get_unmapped_area_vmflags just wraps arch_get_unmapped_area_topdown_vmflags and arch_get_unmapped_area_vmflags, and we might as well merge all three by moving the MMF_TOPDOWN into two actual implementations? And then just update all the implementations to always pass the vm_flags instead of having separate implementations with our without the flags. And then make __get_unmapped_area static in mmap.c nad move the get_unmapped_area wrappers there. And eventually write some documentation for the functions based on the learnings who actually uses what..