From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEEB8C25B74 for ; Mon, 6 May 2024 20:30:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 422386B0095; Mon, 6 May 2024 16:30:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D2466B0096; Mon, 6 May 2024 16:30:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29A246B0098; Mon, 6 May 2024 16:30:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0B2EF6B0095 for ; Mon, 6 May 2024 16:30:34 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 826EF40B41 for ; Mon, 6 May 2024 20:30:33 +0000 (UTC) X-FDA: 82089113946.27.FA63D62 Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by imf14.hostedemail.com (Postfix) with ESMTP id 62477100011 for ; Mon, 6 May 2024 20:30:31 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="EvKNLO/J"; spf=pass (imf14.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715027431; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zWTgDMw010qjBzY9SNStiBF2+BhONuUA6RIHZNLF4YI=; b=5jES0qlWLY0NyiqBRuCPaWFg/EuX8EwHEjnDm2Lt4JAXsM2Lh8uMvwDYEOfIYDmU7n23U7 agkgkfwjaf0t2kn+AidRxe6t42yTIDajZPHbq3UbU8jnMii53Hga4D+tw0mY7TSUgSf8sA iEaZUJV8Y+SxQRk9qxHHqo9m2UAN/c4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="EvKNLO/J"; spf=pass (imf14.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715027431; a=rsa-sha256; cv=none; b=8bx8Sv1VG6VRjAx67eY3JNlOGwsA9MARPZTvjBiy+qbcX8BUJmrh9P+ctBazdOoenjTs0Y jeGX9m0c+3a+/m7eo3PaR9SuSR8iLdipH7eP4M4RMUHSKtc+pW0GYbi0zJjLzp/a6wWOMM p3jsJtduDLhsCM8VGT7n+1LOT1nkRqM= Date: Mon, 6 May 2024 13:30:23 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715027429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zWTgDMw010qjBzY9SNStiBF2+BhONuUA6RIHZNLF4YI=; b=EvKNLO/JPjUI8g84XqS/c8Vr2c1jLOLboa5hR1FxWZnWTzoheYGGabDAkAgEWeVqHqnV7P Pr3PFGD+9YllGtNWxf0gWmfMRHjMGMb46W/O4HK2XpYp80gRGQL6WsDP1RpeyUeNM1GawN tCLtZY8O+UblZWbaC7vM8sYHrRGlJss= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Yosry Ahmed Cc: Andrew Morton , Shakeel Butt , Johannes Weiner , Michal Hocko , Muchun Song , David Hildenbrand , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+9319a4268a640e26b72b@syzkaller.appspotmail.com Subject: Re: [PATCH v2] mm: do not update memcg stats for NR_{FILE/SHMEM}_PMDMAPPED Message-ID: References: <20240506192924.271999-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240506192924.271999-1-yosryahmed@google.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 73dbxdtnq7zb4zygnb91jtbbxj6nyqiu X-Rspam-User: X-Rspamd-Queue-Id: 62477100011 X-Rspamd-Server: rspam05 X-HE-Tag: 1715027431-771623 X-HE-Meta: U2FsdGVkX18tCnK/UL+3iiccRqQGnatST8bWhGAgZ/qomtPWGmTdbqXeRQf275Ix7xmgWqXCWxu+UvgvKbnS2s6RiTbYit0tvgoyXT3mnqrKvgcAhLFSbFe2I9TAXevgYfbhPTbkX82OgufkKKa2hlwtAZu0GUQQdaeZ1o4PAreSJtRkcdmK5SGpT/+0e7OTxCUV5UAsnsOh0Z9eOUrAw0bjoV14WbXwf3O5W4I4OtkxKjxH/YS52U8G9Md+I+dnUVosgkeCDrhTzSinlQK5ft9LzflOrEedr9iG5BzCvQIFTacIm+sfUjXeQ1uqK6otT/AAYOau91495dYu5uMfhwUtj9mSZF5I6wrnUPp1X9DP3aL3LUMDAz3fyiehMOnGWKN6pIixvoatUKq4fWNjZ1JY8uSfAf/CHTNaJHh+Okf76VTtQC2P/3dKdyrYZVLnLaah+zo02/3Xgey6EgC76F/bbcbSzUL5GmiIXCXUFhc0KAh9648atCmRpSmhXI/BYyhFdx4RAqY+2m0TDw5rIyBogxoMz5Pnh4pMG13s8KE1oDCw2TkzGBXAabIPq2WF2B0OTRM+7gES3ZSo6zuWXmOLlZ/JfSdCukc9L1AX1//uLZZH1J3it+yQZAjb/mgBlKvG9N+mj4CBXY7ptjnbp12bPP1802Zjwm0UxQIrFT9s3zAyuyRroyHYYrGI7tW+I6tjVDNtlzLA7R5nOGgehCk0nxqbOsXs/F/fqy/TFY+FV1WDszpqxdTdmVzo6VgT1m2FSqiIBEgv2Ncc+SrvfQmhkcVCj+0dOzLxj/tbtDsjOF3/M3nO0ejXIKeQNRyPKNCUtuTSv22CyeCiKMMgRjATAtug3cvZF4t6dR1lt2BK4bfF+9P0SYVfJKsvuQD0wPCwDZgWEkrdG6JO/3FHaZzqxL7dF9SNjij2r4wWF89NNAjNVq3XK+UNkrZtJoRyoCcLQWx8cQwXuDmMg/7 tJBK2P6X 6lbBhSxT+tkmQCqNUqtws3p/oCPTHGxhQWwSFCtDiABS7raZMMBfmIOVhQ2m76a4SmX+53dHb5ChhHFvSxLkdMKgSmM9EWSZ3RYPmU4S1mWWCNIAeeuwmpxa9eN3EPbwjlKTS0uBQ1LkE5wGg51j+U1jeWzhFnQiPQ0MPbRd2A621rl0jtj5PSDvQXQYJ5L70sfaFx09ydls8NYwPUBz79N1CtNPYCaePnlK4blfIGEML1XDEDKHdU6qgn5+qNQoytPEIU1KP7HlvaGrEz8KjlB09edaW39GotfIXO1EzYMR1pLo5jp2jZJQMiiGcKYSTcFkJXsQSW9PobaWyH2PJFwV4RN2WQ2O9s1TTEt/iX4gpCNPclTrGnYzhew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 06, 2024 at 07:29:24PM +0000, Yosry Ahmed wrote: > Previously, all NR_VM_EVENT_ITEMS stats were maintained per-memcg, > although some of those fields are not exposed anywhere. Commit > 14e0f6c957e39 ("memcg: reduce memory for the lruvec and memcg stats") > changed this such that we only maintain the stats we actually expose > per-memcg via a translation table. > > Additionally, commit 514462bbe927b ("memcg: warn for unexpected events > and stats") added a warning if a per-memcg stat update is attempted for > a stat that is not in the translation table. The warning started firing > for the NR_{FILE/SHMEM}_PMDMAPPED stat updates in the rmap code. These > stats are not maintained per-memcg, and hence are not in the translation > table. > > Do not use __lruvec_stat_mod_folio() when updating NR_FILE_PMDMAPPED and > NR_SHMEM_PMDMAPPED. Use __mod_node_page_state() instead, which updates > the global per-node stats only. > > Reported-by: syzbot+9319a4268a640e26b72b@syzkaller.appspotmail.com > Closes: https://lore.kernel.org/lkml/0000000000001b9d500617c8b23c@google.com > Fixes: 514462bbe927 ("memcg: warn for unexpected events and stats") > Acked-by: Shakeel Butt > Signed-off-by: Yosry Ahmed Reviewed-by: Roman Gushchin Thanks!