From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D8CCC10F16 for ; Mon, 6 May 2024 14:49:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCE9F6B008A; Mon, 6 May 2024 10:49:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7ECD6B008C; Mon, 6 May 2024 10:49:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C20066B0092; Mon, 6 May 2024 10:49:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A70EF6B008A for ; Mon, 6 May 2024 10:49:42 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5914E80AE7 for ; Mon, 6 May 2024 14:49:42 +0000 (UTC) X-FDA: 82088255004.06.B91DEAF Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id 3F4EE100014 for ; Mon, 6 May 2024 14:49:39 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=h+nh5+x9; dkim=pass header.d=suse.com header.s=susede1 header.b=h+nh5+x9; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715006980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8SjI8VAl0W+J1vcR3bFCMW1ShLhq8ix+ki0A3tbAkyc=; b=A2xoUZR2mFAvQfIRDoducbq+wU1xboql5zs8YPKVHoqOHlvNvBajkDEsS2SgsRSzCJbUdD Kq8fWD5JGz/jZpBbk+ik03n2Z3uLiw2BZSQeTFCCxL3Srv5Vpv0GPLpdN0V6X/UjWwa7V9 eH1Ba1gO/HmbNNTm5XyyR7H+BvPumMM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=h+nh5+x9; dkim=pass header.d=suse.com header.s=susede1 header.b=h+nh5+x9; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715006980; a=rsa-sha256; cv=none; b=vohZOujkgFu+hDAtzS5xoxIweTtYFQbp6W8NtDaw7O+j8abgW9iZ13xWz62giLK1Cm1U/W 0J9SuzWoqw6mpID465n1EVq25aG8s2YilcZsGPrxZj3jsw1mn8dLGVnMXQcs140oWhN77q v6xmXVvOZg1gRa1x7dtGiauMaNX23p8= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8AF245FEBF; Mon, 6 May 2024 14:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1715006978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8SjI8VAl0W+J1vcR3bFCMW1ShLhq8ix+ki0A3tbAkyc=; b=h+nh5+x9CTVXkLIHwAMBIkfOqiSzV8va338K+8d2goT4GNJXbBH/PXF7/vYGaYV3yRAeDl daQ6gOABZeqq9pqH50K4zoX57RIJkoEJgIBLfMooRc8osmDOjRK7k0qWCpLXbFzJlWa8+M 50oJXSS6z2v3NnSbosVXVRtBbeI0oMo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1715006978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8SjI8VAl0W+J1vcR3bFCMW1ShLhq8ix+ki0A3tbAkyc=; b=h+nh5+x9CTVXkLIHwAMBIkfOqiSzV8va338K+8d2goT4GNJXbBH/PXF7/vYGaYV3yRAeDl daQ6gOABZeqq9pqH50K4zoX57RIJkoEJgIBLfMooRc8osmDOjRK7k0qWCpLXbFzJlWa8+M 50oJXSS6z2v3NnSbosVXVRtBbeI0oMo= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5973413A32; Mon, 6 May 2024 14:49:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id fMt6EwLuOGYldwAAD6G6ig (envelope-from ); Mon, 06 May 2024 14:49:38 +0000 Date: Mon, 6 May 2024 16:49:33 +0200 From: Michal Hocko To: Matthew Wilcox Cc: Xiu Jianfeng , hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm: memcg: use meaningful error code for return value Message-ID: References: <20240506133643.1124102-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: y3iw5ofd1ztjowmakpbpemeycdg5qezq X-Rspamd-Queue-Id: 3F4EE100014 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1715006979-540494 X-HE-Meta: U2FsdGVkX1+7pHJRjmsiES3SbOCW0/uG2cLkBeLIlmnRvq9UeMl4H+NltyGmIzMcab1c4yhMkZLdq1qjEcjILxXy1Ko1MkptGfC8R0Xx1J0jNO6kk1rIB0bf0dk1hV1386qJVmsxuhM0LS7PeTrcQgaKCG6W4YcJFCL8BJlGFVPAWTMMTG37ZBbj3IiSws2/RLVt4k3CE5slDOCGhGeRD/Df+e3RbJuIy1/a7zQ5Fh2lSm1LrPh8LqIrJON/TBnhFotlAScnaco6jN5k9+q5QT9lTwhm7oUSPU3gSpTGjLuCbvZEDI+L5yWKLK20HMwRs17Q1R57/AIY/NaIaVmuTpkewIIcue9QqgoFe+vvE56+Y9daWYlQhgBIeGMTPP/ZnnPr0XTb3gRnDT6HM3VHoXvwLuwMDzd3ZLQVwSJdm71gfbdg0DeE6NO4lPb4OkkfLOn3IVhzB6t/A6XAyDbsUj0t5qVa0yp5hTT05BQzB34lMm2y/VJfkh3S4KoXEYKrYKaYTH24V76eCwlsLKKizBjydOKBbPFIeVSJJj9Haksdp7sK25eY5oiUoA9yBQeGORe/gL19CgYbBQSg4yDn8jhH5wmdqvBagG1sO9X1pJBNoKzQmjXcnMyPM1LU70NiE9UV6nL4e39Hk+yNFRVD1XVwSRLylHseVolcPrFauYMFRNu0mC7lk5iwxc9hRHho0xEKr4eq00lzBmxOe1+gOln7IOA/2/rcpzZhObU73Ui0uzhGkszWq6tiEOX6Hh1ToDOvW3alOvOshAsRQ4AHgQLXABFtxghR3b0iNZWEVsfQjcZqKVFvJlLUlIGCKNMHTfSQPXU6iDEKNbnw+YdDwG8zARb8B5htLss/4K5o4AFrUXNRSA7taYiUUeJ15uIuq+DXez5L0sGWQe3ILdN9mrqw47TgDQwOx8suIOhvutikI0gT5oskENwpLdUWmsI88QsPp7CyS8UDq2b2Obl ogkQEmmV 5iMP/tlRocPx9JUwd7ooVEws+Z79wt7vFDIX0bbgfyAhHF4x1RzzxpPCEFSzaCGqgpiaBgO1MjKUFjcZUC+i4vZheorM9c79US9bllQlmOJcn0zXryQg5NOGZssBwlAH4h1+5FkBx/a1In37zz/PiSueRGu1rZOWL085BKHF9FfGySlKUBtJw9Po03wN4JjS4S3n+HTcQxUYG0lVaisrGSQgq8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 06-05-24 14:53:47, Matthew Wilcox wrote: > On Mon, May 06, 2024 at 01:36:43PM +0000, Xiu Jianfeng wrote: > > alloc_mem_cgroup_per_node_info() returns 1 if failed, use -ENOMEM > > instead, which is more meaningful. > > This should probably be changed to return true/false instead of > an int. Agreed. Or change the only caller to consume the error. Changing to bool seems like the easiest way. -- Michal Hocko SUSE Labs