From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB9F6C10F16 for ; Mon, 6 May 2024 14:12:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E3856B0083; Mon, 6 May 2024 10:12:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 393ED6B0087; Mon, 6 May 2024 10:12:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25B7E6B0088; Mon, 6 May 2024 10:12:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 076756B0083 for ; Mon, 6 May 2024 10:12:03 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7E02980AF7 for ; Mon, 6 May 2024 14:12:02 +0000 (UTC) X-FDA: 82088160084.08.18F1585 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) by imf21.hostedemail.com (Postfix) with ESMTP id B8B9D1C001A for ; Mon, 6 May 2024 14:12:00 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=k9Mt3++L; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of 3L-U4ZgoKCBYKAEDKw380z2AA270.yA8749GJ-886Hwy6.AD2@flex--yosryahmed.bounces.google.com designates 209.85.215.201 as permitted sender) smtp.mailfrom=3L-U4ZgoKCBYKAEDKw380z2AA270.yA8749GJ-886Hwy6.AD2@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715004720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3rybRiGbcuMZ0JyaRfONRcOqvfackBPFbCzYjcQ//jA=; b=WPOv7z2Pf4eEyF8I6zsf7Bh7+wCuKM6gYI6dPlaU/9DkEnkuYEMP81shOWq0vpL6AUm0SH zbK2NAPi9pDUT/3aIKKwYWyBQJ6mbdBx8nmqo5elKVTSnoy7dOLjoaQsiohCdsf4Js7ucA Mul/hS3z7sTMp4qA1CSgikTz+wXyuDA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715004720; a=rsa-sha256; cv=none; b=XF9VTkYYOzrkP3cRVUf609n/8CT7+eI3c/4kTWVWtjjYf700WcLtAQtp8Kl+5ZQMJY5R85 fCASYdheVRQ+lqu/KGygkKXvks1Zj1JzyqLwD3fp+rkHE4evISF1s67sg+KX9ugTCvQER0 xPMJeVGWZ14mGSFDvHzBRcGPpOli+ns= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=k9Mt3++L; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of 3L-U4ZgoKCBYKAEDKw380z2AA270.yA8749GJ-886Hwy6.AD2@flex--yosryahmed.bounces.google.com designates 209.85.215.201 as permitted sender) smtp.mailfrom=3L-U4ZgoKCBYKAEDKw380z2AA270.yA8749GJ-886Hwy6.AD2@flex--yosryahmed.bounces.google.com Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-61a9fab00f3so2009835a12.2 for ; Mon, 06 May 2024 07:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715004719; x=1715609519; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=3rybRiGbcuMZ0JyaRfONRcOqvfackBPFbCzYjcQ//jA=; b=k9Mt3++L1qliYeZDsUpT67HYOSZGxQu6jLkr3tf7EpvEI0mvuQbeLntkoXiwosyDAe 8qCXxmdl00sJwWOrLm8fa6T2XW2qz/2d9J4J2qIxAI1SXcq9pM4tfHj/srs8TbZ2Ofwg f74/I3v8g2CoDrosFgFnZY8r077RnGSbMIGQBG00kevuvSMXTxI649O9jWsvhn5RH1TG 0O6Ks9+Yi32Y3XeorQycHrNib32Q8uxSGFqf6jsMJVU1KIKKnPFQzmlaUcrWpwUqXYhq OafmIhXXc9GxeiyUSUrxujJPAk4amGUotP6nGQ5yDwzp+w/jX7+h9TW87fBSzPidGv3J Tr6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715004719; x=1715609519; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3rybRiGbcuMZ0JyaRfONRcOqvfackBPFbCzYjcQ//jA=; b=pRLHmMc4nBhOfBOaoB5kQM5PN5WD0lwHIljNcImZU0DXcp2vbtCYlPVdLcXUcVfZsO CLFlANFLAeZb5+OzNavLCB5jStyimUp0ibF085eT05cuc6rNBcgnLaWPs9pzM7YwUsVG irPo9oC5IiDK9y/d+KJyUKi5gQG42kzZ1gQPBxAVJSOosY/r6C59IfknQdNVU6kHoQpL eN4fUuFM5exsGplgzHtTKiKRn86y6MEZtNijYruoCpOFO74A7tcXyskQ6GNCrZl/9NhU +WoJXJepLZ43WSBJ49aR9V/AfdYN/UHk5f1Y+SHGao6og1PzneEIEKbWaoGSmw1wmdbv 9GlA== X-Forwarded-Encrypted: i=1; AJvYcCXoSOo2CwBwv14IRG1snFigZpPQMUbFXv01juTjtziQxY1na0npTiRAnFlAkT/9ZP3QZM9HEwde7MkmYzuH0MwgaKY= X-Gm-Message-State: AOJu0YxOUJB8MHkmmLh7EUnwOlC+xshreiIbJzPkpIDTqYgPabLbHekt saTTmUGX9UgQfCBVxzYj2jbsm9ZjhwVTEAl19vtCrLQZfy63+24uq6O+xEGdItMdK6Qw1Eqp28o A4DTVBD5P8Y1Gtow1XQ== X-Google-Smtp-Source: AGHT+IFsPyCDxX6XqIyh+dT1bq7RxRgsQ0lBRlV/v+UFcICYKh7V0MGyY7/tPU8xlnByRAKTG4aO+chA/o56dtB5 X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6a02:69b:b0:5f7:9ef9:e6b with SMTP id ca27-20020a056a02069b00b005f79ef90e6bmr34670pgb.5.1715004719446; Mon, 06 May 2024 07:11:59 -0700 (PDT) Date: Mon, 6 May 2024 14:11:57 +0000 In-Reply-To: <0000000000001b9d500617c8b23c@google.com> Mime-Version: 1.0 References: <0000000000007545d00615188a03@google.com> <0000000000001b9d500617c8b23c@google.com> Message-ID: Subject: Re: [syzbot] [mm?] [cgroups?] WARNING in __mod_memcg_lruvec_state From: Yosry Ahmed To: syzbot Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, shakeel.butt@linux.dev, syzkaller-bugs@googlegroups.com, yuzhao@google.com Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: B8B9D1C001A X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: bzekqqgc39hizpqo9scfxzokq6jz6eq5 X-HE-Tag: 1715004720-309850 X-HE-Meta: U2FsdGVkX1+Y/+HnxxHyFaeLlAWzBslZYQ3fYVWVxBDj+FLzh7fTnbbHu+j2iBuFmPlNpAzXhLc19Ku36F/txmRsq2nPKL1D/yRCWhY2Tq5ugkmnaVO3FHONcnHx/7c1tW6eKiK2Y7lXNJbVPpd7G+cnsuBmJwBZL1fTXMwZ6z9fXumdYsjJjCBDedzAaPhbMyS/+ohqpf7w3Ol2naAZH9abfC0+O749UurliOWO6d2m+Q/rMJY5y/obx4TMMOOnm55RJ31PvVFgbxWgNvFA+KqksKLGq9jrPWi46IwpN50hYNXbq4mHO2yW+lgpliNto3GuvoUdcAJefC00+E2ib9rABfm3mFboCF8dkgzPHWTgvyahJdX3BQyM+yP3T0TrGNwGpiVbYPQ9/lZnbUR0klaZuKZJCMwwkycBwCg8Yi0Q7ulRGfXkQq4lrvixawGFik1Vr2Q3j3NX9oaplcelNT3NVRs6b3SsTKLFIwTGiglE73CzSBtxo0AIfZyQWlJxNmiTpdCTqZC6rjp1uRl29QMzP804Y8i+ahaAE+FTJF1fE8p3W9A1ee96OOoNfG0qWTHrRcLAHHkumkRaAPZkvVvBYR43aI8Rd6iD3enZBNR9LC9Ye/W5y9wuA+Nc1TTD1DGhBS8xKOG7X/lecF+oZX2UPFUXo6we5NOTdE3UHcjqifbmBVTM5HFYNP/+4f2e2PxRGHvhCdC0yXB5epCSpG7ORqvq7kOxdOKaqrtsHpjstg6t55LuzI1se7ETtFYtPxbrno9d/IHgpz6GyJnZxGzij55lRwe01vLN/TAw+CCsl4TTTclrEwJmNWD0djEQnSamC+KuPeHGXRtd3crN+JAfA4b5LxKYeku3jweDL5Y8UVxgPAY0QRs/D/0qIEmrpVE8yBxW1VBOQfeSpa1LsVm7+SmxTKeotxdW/lnm7YnIrSwlu2JUvLfy1lMgTZXf7e/ZKrHsQOlEut9BHSV iOd+ziad iyp+KSfTyaoflEk/nCXRPA5Ex4HGTp6dYVusmMKSxWvnaWz+PFaa1GUHEb3fqHUa/0eez8NU+wAru7M1bmU72iPaZ1dcIIt/8GqBtbO0bphgOucaiExf//BC/sfXDSCrpBmJiC/a6XfkV/W21jllKYmZZkr5CAMpJS5XZUveEYr99JJuRtKGnHLyykkWCAF42eKBWfO5xXDTU4rZqiXA7UrtzMTSokBozbSfo2YNGMGToRkGPTKl3/W1ooshGCfa+IvAUepp7X6RUcCDYuQ0mucfvNX/cX6Gqo0uxe0GzJj8zNoB06BzlcYzJ1SjtlFyflhZrgF/9toSH+el0KOvI0yoLBIF47OnP6Ok5+uaX/U5UOMK/RK+GEFramN/JRDTeqiq5jIxPaOlTkdrsvIEhUiJtVOPBQpl6X3SUQki+wL6efDmgkS21J7zymV2XYtGubzObGioKm07R2zOd8E8RRzQcjky6DsOuAXJ+HvdwTsqAo3+7bJa3KuouDfzJOvliCSUxW2OXKBTAF1DK3JMzeew5leauwgsZfohOXn040xlj3jCsuUwwH5jKwvN2fVyHDv0zXhnYmib1TnT1FR5N9kfcRmsmGZ3cHnHOuW/uY91C3n8rGomcPa7vL6HWFJKUEk3urX8+Y85R5S4/iQ5t7Y6OJyvJqryuBwbt6EAIMbEiO1irxfjyzvC9nQ4dQlkrHbuYWasrylFmGgXxJ0xNaZSixlYbkpUd+DBmmNNueXFKZCyb4U9O9Kwcjl5daF2+FJHRzL/956X7gTKmuk2QzCbhD3jDEY0pUYub0j0W0fJw7aGld7wF+QillL66N306EMdySwfAKzfyP1VVAw3Ida12lps/2Qtfie8bdcdZ58TQQdA6BH1XM5GMdelRJksgFsxENXeGoi2SdGWk7yazzR0B7m3H3RaBrLxKDZpqDiIycglTVngd2cJO3bYHbPdHFNhVXADZv2l5lhhnpJU76UCiQprB 5ls3eA7w 8lxPuHC8g2/FNa53fzRsd94Zh2gSDBzau9Ok77eNHORSKWMkVEHXG502qIiabDZRmvDS3JeBV4Sghg35AaLjj3kgB6T6nvCNtJ+kXdhuhEgsBYcckEHQsWIMcvfM1JObz+A0ZYxlPOaeDaKJ9ut0Gapu0yQA/BCrVqra8dkdGCa2zgwqzSHF8kLd2fcNalpPxbLibVJa7+T9KqgP+hr5gXAeMLPIEorLxPze29Kf6Vge8EYuWlx98yAwJviMTETejjE/DmbFHrg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 06, 2024 at 06:03:29AM -0700, syzbot wrote: > syzbot has found a reproducer for the following issue on: > > HEAD commit: 2b84edefcad1 Add linux-next specific files for 20240506 > git tree: linux-next > console+strace: https://syzkaller.appspot.com/x/log.txt?x=1164931f180000 > kernel config: https://syzkaller.appspot.com/x/.config?x=b499929e4aaba1af > dashboard link: https://syzkaller.appspot.com/bug?extid=9319a4268a640e26b72b > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=123d5d1f180000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16527450980000 > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/6a22cf95ee14/disk-2b84edef.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/f5c45b515282/vmlinux-2b84edef.xz > kernel image: https://storage.googleapis.com/syzbot-assets/9bf98258a662/bzImage-2b84edef.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+9319a4268a640e26b72b@syzkaller.appspotmail.com > > ------------[ cut here ]------------ > __mod_memcg_lruvec_state: missing stat item 25 > WARNING: CPU: 0 PID: 5091 at mm/memcontrol.c:999 __mod_memcg_lruvec_state+0x18c/0x430 mm/memcontrol.c:999 This doesn't seem to be the same issue as the original one syzbot reported. It's the same function but a different warning. I am not sure how to tell syzbot that. Anyway, this warning is the one newly introduced by Shakeel. It is firing because NR_SHMEM_PMDMAPPED and/or NR_FILE_PMDMAPPED are being updated using __lruvec_stat_mod_folio(), which also updates the memcg stats. However, these stats are not exported per-memcg. I think the following should fix it. #syz test diff --git a/mm/rmap.c b/mm/rmap.c index 12be4241474ab..d3a26ea4dbae2 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1441,7 +1441,7 @@ static __always_inline void __folio_add_file_rmap(struct folio *folio, nr = __folio_add_rmap(folio, page, nr_pages, level, &nr_pmdmapped); if (nr_pmdmapped) - __lruvec_stat_mod_folio(folio, folio_test_swapbacked(folio) ? + __mod_node_page_state(folio, folio_test_swapbacked(folio) ? NR_SHMEM_PMDMAPPED : NR_FILE_PMDMAPPED, nr_pmdmapped); if (nr) __lruvec_stat_mod_folio(folio, NR_FILE_MAPPED, nr); > Modules linked in: > CPU: 0 PID: 5091 Comm: syz-executor374 Not tainted 6.9.0-rc7-next-20240506-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 > RIP: 0010:__mod_memcg_lruvec_state+0x18c/0x430 mm/memcontrol.c:999 > Code: ad 35 94 0d 00 0f 85 a4 01 00 00 c6 05 a0 35 94 0d 01 90 48 c7 c7 80 53 d7 8b 48 c7 c6 54 27 b8 8d 44 89 fa e8 55 f1 54 ff 90 <0f> 0b 90 90 e9 7c 01 00 00 4c 8d 7c 24 60 4c 89 fb 48 c1 eb 03 42 > RSP: 0018:ffffc9000338f1e0 EFLAGS: 00010246 > RAX: 38a0635190e19e00 RBX: ffffffff8fad3cb9 RCX: ffff8880221f0000 > RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 > RBP: ffffc9000338f2c0 R08: ffffffff815846c2 R09: fffffbfff1c3995c > R10: dffffc0000000000 R11: fffffbfff1c3995c R12: 0000000000000200 > R13: dffffc0000000000 R14: 1ffff92000671e40 R15: 0000000000000019 > FS: 00005555900be380(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 000000000061cca0 CR3: 0000000075f1c000 CR4: 00000000003506f0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > __mod_lruvec_state mm/memcontrol.c:1055 [inline] > __lruvec_stat_mod_folio+0x1a4/0x300 mm/memcontrol.c:1075 > __folio_add_file_rmap mm/rmap.c:1444 [inline] > folio_add_file_rmap_pmd+0x29c/0x700 mm/rmap.c:1485 > do_set_pmd+0x767/0xc40 mm/memory.c:4650 > set_huge_pmd+0x28a/0x710 mm/khugepaged.c:1452 > collapse_pte_mapped_thp+0x5c7/0x10b0 mm/khugepaged.c:1655 > madvise_collapse+0x661/0xcc0 mm/khugepaged.c:2762 > madvise_vma_behavior mm/madvise.c:1094 [inline] > madvise_walk_vmas mm/madvise.c:1268 [inline] > do_madvise+0xc5f/0x44d0 mm/madvise.c:1464 > __do_sys_madvise mm/madvise.c:1481 [inline] > __se_sys_madvise mm/madvise.c:1479 [inline] > __x64_sys_madvise+0xa6/0xc0 mm/madvise.c:1479 > do_syscall_x64 arch/x86/entry/common.c:52 [inline] > do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > RIP: 0033:0x7f1421be72a9 > Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007fffb7f38b78 EFLAGS: 00000246 ORIG_RAX: 000000000000001c > RAX: ffffffffffffffda RBX: 00007fffb7f38d58 RCX: 00007f1421be72a9 > RDX: 0000000000000019 RSI: 0000000000800018 RDI: 0000000020000000 > RBP: 00007f1421c5a610 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001 > R13: 00007fffb7f38d48 R14: 0000000000000001 R15: 0000000000000001 > > > > --- > If you want syzbot to run the reproducer, reply with: > #syz test: git://repo/address.git branch-or-commit-hash > If you attach or paste a git patch, syzbot will apply it before testing.