From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8442DC10F16 for ; Mon, 6 May 2024 13:54:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 056896B007B; Mon, 6 May 2024 09:54:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F21526B0082; Mon, 6 May 2024 09:54:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC1BE6B0085; Mon, 6 May 2024 09:54:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C06786B007B for ; Mon, 6 May 2024 09:54:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 45207A1793 for ; Mon, 6 May 2024 13:54:01 +0000 (UTC) X-FDA: 82088114682.30.AA0824B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 289C3140013 for ; Mon, 6 May 2024 13:53:57 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BgbMRQ2W; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715003639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4wGZZWr50vBbs3Q757bfPI+FzVZjlv4CH/7/r+l/niA=; b=qmrA9YF9nSENnFUlEhfPtTpiAe+ZVuBlEMTXxxzQrXJyw+hiPAjI9VIlSiiSacfKOo1yK7 5f69+r4+/yP0cSNdMR60GEWqB+ytOAiDItDZfwKqe2EKlHd+C2XUxEjtN0ehs6QGHsVt8M m6ootLIz4z6XXopLBnXOE5a2RPg2AIA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715003639; a=rsa-sha256; cv=none; b=d0bk1FQvR2zi/T/kDNmviPnLH1sBp5seHagU2VgeImgP2bYezM0GgZsdvetZfXHDyZu4k9 zoNS8Q+KO9DudghMk6W+xU/ZUG/Bgxd/66xH83tP4DYbBmeZ4+PArPih5jI2uq2kuhqhFg vv2lNYz1eg5GvYPyQg9WBETiidHnjZo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BgbMRQ2W; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4wGZZWr50vBbs3Q757bfPI+FzVZjlv4CH/7/r+l/niA=; b=BgbMRQ2WdJfHA20fF1oQAn25cc jk87a5yBwfhlKEqjjW7Y6pqP7s+X2z+DuZHBnN2S7F/XmSK6495gokjSa+o3OpSveFSYZinIULhEX ObCJ6LLabA9MUHJM0obz5AoKxkLDASvN1Ynn1M+O/MRerqv/+CVKvpb81pPuCaKgLb+xGM5KXNGCx 9CClxA6t01knOSFEImNBBIV3O90uZj4XdjPR3MCmmDjkLr0OvOp59MZZ0Ew8PFixxUN8tbnnSvrf9 F6yMyja3qhr2eBstJDud8D/7jxA6R8Nfy7lJGa5potIiUsudHdsRJWVNOWpG9qblitFgKT8NxUqUd UT/95xkQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3ymp-0000000B3XI-3waU; Mon, 06 May 2024 13:53:47 +0000 Date: Mon, 6 May 2024 14:53:47 +0100 From: Matthew Wilcox To: Xiu Jianfeng Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm: memcg: use meaningful error code for return value Message-ID: References: <20240506133643.1124102-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240506133643.1124102-1-xiujianfeng@huawei.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 289C3140013 X-Stat-Signature: y69puayz9g4p79gdu5kt5yd1aub35ekh X-Rspam-User: X-HE-Tag: 1715003637-299507 X-HE-Meta: U2FsdGVkX1/lO21ZaBTCyxkcZSvcqjqFFgOocnWpLWojajIPz9N18qwkHPm9GwcOkfG9dqzLl4DOg55thSzwzKC22OIfKYAiTvReh8FGtwtM52SO7mLrRIQxdUyMsr4xSlFk74os3o0TNsZTC1/9Imt8oqdjv6xM8mzwBrCiJaXSITevqsfLf55sFzBC+T6n3fTfbxvFCNNYOpfUwamA+IEWXBL2abBVpPnEowqdwb5bOeDz/ddGFwQEgpnvOl0FOlH6b3Tl1s00Teuo4cH6vim/vUeAKTiJ8yRjMGKXRhiXd2RylZipFTE3X0jdxu+ebvFvxXQslaOfWHzRIE3B5GddX1qvfnWM8UCAlBYDlBuF50L75VoErLx2YaFR1XhjQ295TvyJK97Krx6OlA8OTo4MwZ1W1/PwvS/Nzjvo3N+RvwsnzhV+ZjT2GFILqcebDiSXsUrus8ZlvFZpQ/sj8fX4ojA8WKGJtk/Ab4fo4OMXBL7HQIkzRozMy6W8qmAGUsRQNv6JEVeS7W1W8Jlg5eSXhfvq7l2rPkTBNrkSsTq1zI1cExScgWE6HSN2msIhNYU0VME/BRGM+GFSAtwHEJGdpX3mBGTtzWOymHhzBIGS1RjDFZo0opFs6dGxi9jdolpqcOH9FCrDPgiTDOhN0pCcfa0+2mz407+RHiXca+vFU/WEwrNOlU7Anm/j0EWl4NgkQFcucznMLM07R9XfALFNK7F3wcJPpfw2t3hc04hOlQurb5txNtlSp/v0I+FtxwIBBKcCppR2QjTYdPu9NxnXtcqQvJbbHhQzNquaQShTrcpZpnAkrb/IDD2kf3593O2qQ7YhMbrAKczfwOoIaZzSAZ+vl8+WNMmwsoDLpQq4PWMlCFbi9WzRmezJrM3KjlDngpuT4LGeOYHO1/c/ZkqTWXH5yW6VyZLzIBVA8jQDV3eYAR6/UKZhKOpF/d6Oxxcoj9ZeQEqVnp6DMfH BaVNt2YD 9Z5O/p2rPiXspAplXBUEupBqdeZUEjBcDLRWLXCi+zZpVXddyFX94FBZUuNJ39n24HIz7MxqGEc0ysCNyRGD3cSCHOF4A89TBcYZzuAqWDmNk/erraet7kTv7KIBkok2OtXKc4GfLugb4laI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000358, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 06, 2024 at 01:36:43PM +0000, Xiu Jianfeng wrote: > alloc_mem_cgroup_per_node_info() returns 1 if failed, use -ENOMEM > instead, which is more meaningful. This should probably be changed to return true/false instead of an int.