From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B008DC10F16 for ; Mon, 6 May 2024 15:44:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 012536B0087; Mon, 6 May 2024 11:44:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F04DE6B0088; Mon, 6 May 2024 11:44:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA4CC6B0089; Mon, 6 May 2024 11:44:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BCA196B0087 for ; Mon, 6 May 2024 11:44:27 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4DC2C80951 for ; Mon, 6 May 2024 15:44:27 +0000 (UTC) X-FDA: 82088392974.28.FCC138E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 19FA2C0017 for ; Mon, 6 May 2024 15:44:24 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NC+BDK1+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SMx6EZos; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NC+BDK1+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SMx6EZos; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715010265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+v0bQfDYhEJjeC4GC6jz30GjJBlSHabfty94pUQWzEY=; b=3ngKVKwwbuwqFvnosjoNyx7rCfTNH/EM57UKGTpSpfsMIOX2gpwpnBJuV0dAcmBiZEIcZq HnLWvw35zzvpIMjSiNgBGjQqjsQu0TSJAAGhGSkVtzFKsmBiZeTONiK5CBTJrxHpZGufz3 z18mBh2ED/ldMjG2KaBS82mJRCYxNrA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NC+BDK1+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SMx6EZos; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NC+BDK1+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SMx6EZos; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715010265; a=rsa-sha256; cv=none; b=INnFnLWt0gCIP33BKzD5Yihg+k7XPJilvEBnhPagfaoiFttHJkNwmwflgl2jtU+DeVUnyQ hcWA8Cb8F7THlf9inwpRUsXMEml9Wn4eqCU4K8y5eZKAzTJXl0VVsOMp2iW6PdTd624M8u WQHwITjVXSAjXqKrz2Fz1jL/N+IPrPI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A27CC38590; Mon, 6 May 2024 15:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715010263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+v0bQfDYhEJjeC4GC6jz30GjJBlSHabfty94pUQWzEY=; b=NC+BDK1+6RrBo1yHw/gCfyZEn4jaBDF/gsTlPiI69rkqV9DK87j/fFhHYMC8oFrqT9390o cDjjFrNJP5vKXpry6bK8OFuVduBlqQuGodPP21k8Pf/3uRhsLBgjYFiI0Xy32PTlb1fXCO I1v/GnB9A/O/pan79qwBBDgqIpRhwKI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715010263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+v0bQfDYhEJjeC4GC6jz30GjJBlSHabfty94pUQWzEY=; b=SMx6EZoskkKlW4wIPfUPcQA+CYqiq7cp6KtuD5YwK447tbmNQw/30m6h84EQnKssShptRF B9M5SDUOl8h6FwCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715010263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+v0bQfDYhEJjeC4GC6jz30GjJBlSHabfty94pUQWzEY=; b=NC+BDK1+6RrBo1yHw/gCfyZEn4jaBDF/gsTlPiI69rkqV9DK87j/fFhHYMC8oFrqT9390o cDjjFrNJP5vKXpry6bK8OFuVduBlqQuGodPP21k8Pf/3uRhsLBgjYFiI0Xy32PTlb1fXCO I1v/GnB9A/O/pan79qwBBDgqIpRhwKI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715010263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+v0bQfDYhEJjeC4GC6jz30GjJBlSHabfty94pUQWzEY=; b=SMx6EZoskkKlW4wIPfUPcQA+CYqiq7cp6KtuD5YwK447tbmNQw/30m6h84EQnKssShptRF B9M5SDUOl8h6FwCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0C5BA13A25; Mon, 6 May 2024 15:44:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +6dQANf6OGbOCwAAD6G6ig (envelope-from ); Mon, 06 May 2024 15:44:23 +0000 Date: Mon, 6 May 2024 17:44:17 +0200 From: Oscar Salvador To: Kees Cook Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Alexandre Ghiti , syzbot+41bbfdb8d41003d12c0f@syzkaller.appspotmail.com Subject: Re: [PATCH v4 2/4] mm,page_owner: Fix refcount imbalance Message-ID: References: <20240404070702.2744-1-osalvador@suse.de> <20240404070702.2744-3-osalvador@suse.de> <202405060754.4405F8402F@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Stat-Signature: 3smh45gtpkkin9akk816a38x7dmhj69q X-Rspamd-Queue-Id: 19FA2C0017 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1715010264-133312 X-HE-Meta: U2FsdGVkX1/O0Kd/tXKT410AcgQP6U4q7FhvmVllIEPHXgYj4mymsN0pj/o4VlF1UJrQg+05K/v9EoFTJ5In5/qrLkq66ebAxOMg7T/NAlzVacNzyvTJqw1Isgz5wPLP6w3U/gnMGq7u2QfDyGJWHsKiaFNBFYGnZ645siLj3uGYk/LRLhKZNoWaGwRlJLhgh5nZJ+9EUB8cVzzLqLLBkVwOj3luZxCsI7YSaA2HNg5KLL3mwmRNtgO0/UcuvuY2gkUuYFQKFlFdwmI5n29YDqLceuUlP4fv3I6FDlMfXlC0qtp61tKYdWSxfXrP8fkIRIb8igxZB1/KMCoqHqL6+wCUNz3d1CxPefc292iPJ/QjfAmXAWonzUB52CzUo3L3hVSLglaUI+7kjm47rGVEk/WB4Qw3s+k8r8Ha4BLjNjreezlMZXfldgX9eQt6R350gX3qGh7HhRLnwQG5asnHrY8sl5fqolP3dcrKYCQx4VShTEJEvDx8K7PB5rMs6oaIT1nrZJ6xFITUcAe+A8G4zCpFWrRJqRB15z5XY1d/kVlHxwa9Ep8C5Sf3SbppN8sCBdh7gWaZabCD6ANQjC9WW1kma9Erx5m+9SAcPWYfx1pRBsbi0mtvXaj3KVyEJZdSLBmPRtRU3cFZfkt5RwfXHlN5ZDufgodpkvpj90Cvgno3sd5Jx+5TR1Zy65R4VVzi1trbDQWp9E1I9jXeYfLRrCYt5M3WVpTNd7l4WAmXosNxIY1xsBKc+FlRh0j8ta09f9P4ImQXSVmIt7IGIlX+WCGiq5zcEsMNSPLAiAIkIt2Vda21kq6n8EjzoaLYszoF+kot4l5PZEy9YnbzWXdF+HIi2l30HebfuqHs8W5l3xfVGAoCi+T3qx6l2BMiZ3/9i6eFSthE8U8xXwWSixc7cJVmoRYANH4OuFOwq9HazBDFvQ5RM1vwwV3sG8bsM5+yYq1uqFRJ/6I0GQPsRWa MfJ0C5uV xMlYpxmJ3+79vhIOPwgZwGOaJ53zjJVJRyazQN7RYufQrbWb9XLi4wGGYCjgnV5FpzSfpHQbJyYOBy3BU8RjNNIozWQzX7b2dobzPgLxXMhvpdT74JetqZGYEh5mIcVt99Rc6QRssOJEq6tRaCg9rSlesF1pKcphaPKj1I9Jr8HLcJf9AAfZEP6/SUbTbT8G1R0AjcUCNYg4rAWpTusSvhxQjnNfkVdeBY7AX7J8x77GGmHQ1MOEyPNN2bM+N/aBDXIgK9miO3hrwcgxc4dPPUJ1o46zVJv5rppo4F5zy7Uj2uvFqmYGGYDRM41Gu8euyTMbzXUYrpf9aIA05M2MjD/fmoPhXMmxeUsqZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 06, 2024 at 05:41:28PM +0200, Oscar Salvador wrote: > On Mon, May 06, 2024 at 07:59:11AM -0700, Kees Cook wrote: > > This pr_warn() isn't needed: refcount will very loudly say the same > > thing. :) > > Yes, but I wanted to get the handle so I can match it with the > backtrace. Although on a second though, I could just switch it to pr_info(), otherwise the warnings from both refcount and page_owner might get tangled. I will check and send a patch later. -- Oscar Salvador SUSE Labs