From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE9FC4345F for ; Sat, 4 May 2024 22:47:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 679BB6B0092; Sat, 4 May 2024 18:47:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 629766B0093; Sat, 4 May 2024 18:47:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 517CA6B0095; Sat, 4 May 2024 18:47:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 336086B0092 for ; Sat, 4 May 2024 18:47:19 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DE1DA40010 for ; Sat, 4 May 2024 22:47:18 +0000 (UTC) X-FDA: 82082200956.01.5CBAB9E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id AE530140012 for ; Sat, 4 May 2024 22:47:15 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ef6uEmmG; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714862837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7mjooXHU8nB/XGYMNHSMZnDBMj3hnPkOp0sLVPuWzkE=; b=tzsnIfn8m5+ZGp/JVD7ErYCjUlMBtuuaV07S2ATvWXm7G/ePrJz7KUBi1OyYHxPSiZol3S kK3qwfLGSffsMuHD08fUTy7HSvrZy+6wXoYKFfzrbVQwCkimcgGzAmyidXIeJM2HtJi6av llTCVs5PSn9Ndh0HPoeVaz5QwU+A0PM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ef6uEmmG; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714862837; a=rsa-sha256; cv=none; b=Ow3sESyAh17l7OQrUqNpdwra784I8iBAGgoMs55R3Sv9pwCLIp1X9FZnKq7Udj2U2XpNbD okGwZS1uN/Osab9/IR3Mc34FrgVUbPW3ZNuuJHG38bCOk9/ZQOrJzU+oojinf7CVy/50Tg M8nxvZX4POB4/YsLxF4Viz+zoRjFQ6Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7mjooXHU8nB/XGYMNHSMZnDBMj3hnPkOp0sLVPuWzkE=; b=ef6uEmmG9k6P3d0gn/ebUsb6Qh a2nwNNPGo4u4awHiPAfRSH2pdh0ON3U6LYEyaYBAU5Lp/SPINP7CBVC1md4RgKeolHeGKp2KekM04 CVH0qW40mPu3y+04TUiZeRPHgSN3+6GvDWiYAX4dBrPI8Kno2UTpkgIhxaUBq5Hh0xQdhBw93Pb3X 5P8NW8IJCKB1+gj1ifRzMy/cbCb17O8hXZFG+gEAimRRi0al8HosQnvyKDBKQnTlUA8CJYf6fR9iM HjVK+SB522w1V/pJ9r3fm/DIY9UAfx9Mwxh3Qbp5Z9V7f2vI1RV/MOs+bAaVHLy1sh5EG8Eg8MswF QSBmicEw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3O9s-00000007Kxh-0Syy; Sat, 04 May 2024 22:47:08 +0000 Date: Sat, 4 May 2024 23:47:08 +0100 From: Matthew Wilcox To: Andrew Morton Cc: kernel test robot , Song Liu , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [akpm-mm:mm-nonmm-unstable 80/82] kernel/watchdog_perf.c:282: warning: Function parameter or struct member 'str' not described in 'hardlockup_config_perf_event' Message-ID: References: <202405040851.2EgypmL1-lkp@intel.com> <20240504154455.2ddd2cbc523698a270cca9c2@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240504154455.2ddd2cbc523698a270cca9c2@linux-foundation.org> X-Rspam-User: X-Rspamd-Queue-Id: AE530140012 X-Rspamd-Server: rspam06 X-Stat-Signature: eex89qkakzrqkf7hkuthxrgb19wgaasd X-HE-Tag: 1714862835-923467 X-HE-Meta: U2FsdGVkX1+fy/2NP2QzUxmygEMaXiseMCoyo3ZNtjPrCK9kJDRx6ZAr8ePchQmUYmskKX8a6/Fcp7h0FERTSmsnGD9Rpae9FnM/E8IbhUzrlaZGhB9ZUh8y6b17kIv/ZqS6Gxh9hUzKtbmDE/w4KjzTbBrFv02TEQBRiKWNtmnhNLMiaO0ws3VJi0KlBa+O6Lqtb8kvnGFCNxwL2CTrmsKfkWF0V54jYbTXegdC763Tb6uIdCan+0lXarJjlFlDrz49UUgpCjaU3u/IiGBpQsbR0reBlpi0YxR3rBPloa1ID25tC78K5v3uK3StwFZJZc2rJZdY/sA4VxP98c9nQO0ekgDtye6rX+R1dHmF2gqqYZtbz8n2xkgNG9PRvKDdIg9SmiydFVymEY/xAvoNe8yavypZ2t+N/rMvI4RANTq3Hri8NvW9MOVP++6zAxs4/jWORtYOTrOR/SGFhISbt0B3nRQA9ZY6utbH+3tDgQtEbRjscN4SYNnPI8iiuNWmtMCwq9mennipJAtiKpZhpxOh84jxQNddUAQFB+44eA17vO9r3kbONQiEHkPvQUIhn0pevT8y8LBrW2UQg8C5d7xAmFMs5eluB6LYF3K+bPFiU3gki0Qo+sp4WVJJabh66VZNwdmzBDQQB4p4rtHjmZXUSn21h7/QI6ejFIDVLmONfFbCTbIdUobUZExdoMBFhuponU/ViSEKeTNdgAPX+d9eMYAde5/x86cNpfZ4+omeYSjlH9A5PuEL00zhNBV0lcqznGoY5p28GIB6id6Q63UoH3Jf/fu6IARSI3o6HTIYb9KplSwqs+8Drmt97gEoFSJ/aWcXzS9G1w4lpg6gX8paNYtQIrzfESL4PgnRo8iUrb4rrOZilVKEqHH4cBcSr1lgWBCrC8E+aBXkDDxzzUw6/62UabCQJgbPc+1B8jJpqZhTLAyTU+lwdFgAjWLNQU8LElb1QKXNu7cHitQ VA3maG41 PO+FMffkE7mLrI3oJYnH8nXw8jJ3gm6lUdRye7qpLXWlBDvPNU1LVkDKhK6SKOQJu0bCKJuja1zOaqbBlMdkaYqbHFno1nuAbnAo3eO9jxbMrtpIyVeFpzTDNGmZOjTt+eP5In0rsdaRUyqIr0kpI6McWiNlpMdrf+mrz/u3k46Q0OhLzn/46ItgYZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, May 04, 2024 at 03:44:55PM -0700, Andrew Morton wrote: > +++ a/kernel/watchdog_perf.c > @@ -277,6 +277,8 @@ int __init watchdog_hardlockup_probe(voi > > /** > * hardlockup_config_perf_event - Overwrite config of wd_hw_attr. > + * > + * @str: number which identifies the raw perf event to use > */ > void __init hardlockup_config_perf_event(const char *str) We don't usually put a blank line between the name of the function and the arguments, but other than that, looks good.