From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B172C4345F for ; Sat, 4 May 2024 04:04:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B10B96B007B; Sat, 4 May 2024 00:04:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABE156B0082; Sat, 4 May 2024 00:04:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 985BF6B0085; Sat, 4 May 2024 00:04:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7AEA86B007B for ; Sat, 4 May 2024 00:04:08 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E2B4580688 for ; Sat, 4 May 2024 04:04:07 +0000 (UTC) X-FDA: 82079370534.10.82EA2A8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id 868A11C000A for ; Sat, 4 May 2024 04:04:02 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vifOKZQ1; spf=none (imf18.hostedemail.com: domain of BATV+f0dd96bc0f36f5e1fe10+7559+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f0dd96bc0f36f5e1fe10+7559+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714795443; a=rsa-sha256; cv=none; b=O6b0l8C/R+lNkJdcrGolW4q8IBc3p+yXLlibTJs77hlKLjrRGnYbsHc1Z0YzmLN8NQm/KI LTFvq9aYRzqmF6aqvI/TFHLO5oaQEEOtanCu20NzJxiaEWCR2Al3CxsTL/Fgb+1LdjFfTx 4n0viB8GUi0Dc5WZ1atBGTUELOJ+pPk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vifOKZQ1; spf=none (imf18.hostedemail.com: domain of BATV+f0dd96bc0f36f5e1fe10+7559+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f0dd96bc0f36f5e1fe10+7559+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714795443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SYAmbYA39mRMtra9kKxfupAmrezK4kfaxBes562k5XE=; b=I3kPvUncteq60qOofoyYKvSVfyWWQlzQnrFgDvi0hkbAKHB/paztvukGIV3TGaVY8GtqeL Vy1V+5jzFpygF93ENKFuVlRx0Xv5SZsTVGVDcB2EPQ3G1HRCgyxiMxCPi+tyIqrKNE9dz+ tIkjcmbMABiXPis4Pgw7k7XwiJkKhao= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SYAmbYA39mRMtra9kKxfupAmrezK4kfaxBes562k5XE=; b=vifOKZQ1gHFHOk602G+1pZl5YM QcI0pkFD5j13gQ4Hbq0In5APxg6Ze6lXKH6fstUB5zJ96BBSXTU5W7hCuwr3bjA+ZXJcULUnRZOAp waiKuifg5Ko709O92WBpsnWHjoPkkAHbz6Hu5gL9eVbXCoB3LHTdlPLyBlodH8YQTpT+vIYIesGh7 ZI5HMNyymjWWU/eH1I7OMiflt3HVlAQH7oK7zCWwS87WaO43o3PP6y7xS+iyaVeVGjuheu8a74E/w tpnANR1IPSLTMVeVuowRpemeaktWOn/Z2rVgjgB8hjRIERm6hR3bdq8PhvhLSWDKU2jEl60ir59Ma gAJ4uBWQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s36ci-00000001CKX-1MlN; Sat, 04 May 2024 04:03:44 +0000 Date: Fri, 3 May 2024 21:03:44 -0700 From: Christoph Hellwig To: Chris Li Cc: Ryan Roberts , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, david@redhat.com, hanchuanhua@oppo.com, hannes@cmpxchg.org, hughd@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, ziy@nvidia.com, "Rafael J. Wysocki" , Pavel Machek , Len Brown Subject: Re: [PATCH v3 2/6] mm: remove swap_free() and always use swap_free_nr() Message-ID: References: <20240503005023.174597-1-21cnbao@gmail.com> <20240503005023.174597-3-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: nae65g9fsn8qdyonapo811okuba8sar1 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 868A11C000A X-HE-Tag: 1714795442-63182 X-HE-Meta: U2FsdGVkX19dQbbWhry6Jc/dO0crd5omOtt6fw/LwZU2HgL3WbQuMAkb+s2GY9uny3Q/wwV/DTW994uohmohDfm8y6rWKZIM8DLhzvReEZcnpzA0ucG/sq7AtswrxFWhIPTIGxPEbz1zJxWB5l7bD/DvHXKb/sjPRahOozm4BfMPLMrwxp4LofqOFfa2YflQi0rYeKFgoiOcY3zlE/xNlVWYE1mLGwjZW3Yi/xBHofmf98LXQMsMiIoY/gAXk96q9jGtux+WhwT+ldNxZloUIVHpXF1SkzDUng0hUtg+go482p8chNuNZsjcBcpfz/IqvSPhnPaZA9fNFhOrh9ptIS9mjMf4IonC7Y4V0Mq7tia66BGySrD98BDRU2xrlljWZ/WueYGCpYJyb0G9pHTQYH+6+HzLzWIDStxI4HBoq1TgCDsTjtX6Rjxmxe8BcI/OD2vaM9lXAXCmjUvy0zsk87YcEAHZUHGIuWGXYEWshz7U+zuImD4OP1R2VTQFrcUF1ynnaVoqmMx0k01900ISMSQ5B6yliv/yUBbpFdElwkkeyvJ/zxpUhmv5MWPA/zZKdhcjsCxq6Z1GVwlpbVi2PEBKaFc7DwCc4FGzHlQ5PwDIUTdzorGK01YTVxPgVVSr1I7ECitZHT5WWifrgs/hVUVDEjYOUYT7D8rDjJ6ybQaVrytjYPMhkW3qX77xFzhoj1Zfzvmpre8hjt7cSmf55whMaddgH8k/TCu0z39eHBzO1yYO9RQZmKsh3AwiIZrZ2sTkjsSDws3dgQ/iURzxvhBbSePNui/krF7G3q18BXV334a2kT/G1Sf3Z4idjKZalBwCi/tZB4v/eYSwhbM5S9rqLAnnyQDEhIF31u3SzQxbhBAzWLv4xVGvxxqbLOMSJQ7ctyf5cAdMoLBCivM5irfcccmOz4NglCZYYuq3sLFcVB2hdM4ObmktrdGLeMOOQRZ5qarFK6AJgyZJMVY eMy+Hu36 Rq+mR5Yfwl39bSMH7Ye2LXrICQ/zy/8UsJtqmak6dOBRN+JQooVDGCIo4QSYVgmvTxnPDVwTeu2vx0ipe5u8+Ie3E5dOZiSev0snH9zJild3W93tVGriIg2kfgEtP1SinVDcNl05lZTMbSWbhuTbDBAr72SlfQJ/aVYtgk6w81Kl8DCN+llmOrU5vXEewn5ntJw+flwxKaERMFf1XyFLYrs+ioNNvU2M8T6d7oaquXhH1M/IqqwB8mfNvdvD40Ln4Rk0I0GxkO4YzaBVSRDSt6V2gd/A/UhKq0fuM34i5WPycK9Oi5tEVsBZJNJenn1I6v3HzjRs5EFaTZNtS8zs4dmoRlCZCkU754HrdSXhhxc/wF2yACadUT31vWvG7MX2kVXZYECPrXYIwk62YiVjNEAQWF2LtbED+M346VEhPFrmEwvJwxJK5E3QRBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 03, 2024 at 01:37:06PM -0700, Chris Li wrote: > Either way works. It will produce the same machine code. I have a > slight inclination to just drop swap_free(entry) API so that it > discourages the caller to do a for loop over swap_free(). Then just ad the number of entries parameter to swap_free and do away with the separate swap_free_nr.