From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 133EDC4345F for ; Sat, 4 May 2024 04:29:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AA946B0085; Sat, 4 May 2024 00:29:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85A826B0087; Sat, 4 May 2024 00:29:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 749286B0088; Sat, 4 May 2024 00:29:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4F5F26B0085 for ; Sat, 4 May 2024 00:29:15 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F1680A0518 for ; Sat, 4 May 2024 04:29:14 +0000 (UTC) X-FDA: 82079433828.27.6FBB77A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 5E011A0007 for ; Sat, 4 May 2024 04:29:13 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KGULOWHY; spf=none (imf15.hostedemail.com: domain of BATV+f0dd96bc0f36f5e1fe10+7559+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f0dd96bc0f36f5e1fe10+7559+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714796953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Mc/W5wliGZHIgIeiC6uGR6vzkpWeRAuvbWwCco3vFc=; b=Oa9ZDYerTDNlFQCYIGNphqn3wgnH02b0qLgu8ny0rXSRrbVPAuUCw8TSIdDNPPhRVS9vEd nviM9VIDoknFNUUTPXx3fq21r7tCSkEc7FEJbqvtJ96gq5kONy+yevTFnxhcya2kIoa8ag +5QzqU/5dSNtz4AOS/9xTBc7mZFjUBk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KGULOWHY; spf=none (imf15.hostedemail.com: domain of BATV+f0dd96bc0f36f5e1fe10+7559+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f0dd96bc0f36f5e1fe10+7559+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714796953; a=rsa-sha256; cv=none; b=bBNtFkHYPeDEih8R56R/nu7pcDwpF9nqqzB9MKPt4HOiCjN94WIJZa+wU/jZki7ad1KgWg Da6/TxNKrkqCUbgNNOjlpY3ZnZZGTwoMFP+/SzZlp+XCyWeybXYb67DkwhF1XWxtZH4+ww M9SOLRjKaN9qoOsFDTRcUV2sAcWZ/X4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8Mc/W5wliGZHIgIeiC6uGR6vzkpWeRAuvbWwCco3vFc=; b=KGULOWHYfgJAw064ZVy1RaAwD/ sHz8Dtq79eTjRHBdmtcGS8NTiUVNQ3aVWWLoOOrlwyr8L2ZgyzswfsPYNCNkCvG0eE7DsV3bTfaSs /mHKOlNHTtbdzyaq+cp29PA1yx7JI1ox2qXngUtd9iNX83ZKYzO+jSgj3X4YEpFRAjcXaHUyFE9OO VIhPxmzxuUtSFZJpOC+5zOCdewBb42HE2LgTZPk4j885Ek7s+RGtaz9wsY6yJt9ElY4GyW8lmHozn /sFkPN6zRRGEol4B+GohX6Tze4trDoeuDzHLI+qDHnxxIVcmqk5q8PPtO0bKjWgSZoKNYNi1ai239 uhoRh7gQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3715-00000001EvB-49jV; Sat, 04 May 2024 04:28:55 +0000 Date: Fri, 3 May 2024 21:28:55 -0700 From: Christoph Hellwig To: Barry Song <21cnbao@gmail.com> Cc: Christoph Hellwig , Chris Li , Ryan Roberts , akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, david@redhat.com, hanchuanhua@oppo.com, hannes@cmpxchg.org, hughd@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, ziy@nvidia.com, "Rafael J. Wysocki" , Pavel Machek , Len Brown Subject: Re: [PATCH v3 2/6] mm: remove swap_free() and always use swap_free_nr() Message-ID: References: <20240503005023.174597-1-21cnbao@gmail.com> <20240503005023.174597-3-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: fhfr1sr91jmyj83y7kz3ffo41gdnpo6a X-Rspam-User: X-Rspamd-Queue-Id: 5E011A0007 X-Rspamd-Server: rspam05 X-HE-Tag: 1714796953-691044 X-HE-Meta: U2FsdGVkX18b0BUFFwijskk7nnmdrzivOg5p4wNZ+SCeZY98cAgBtY8e+vs1yCygLtsHLhF41dxx2ot3N1zh/nzQDrCwvyzZY9Cr15JDGSLUz5upLag4NsfBuK2cMy9GbaKF48r0jDAgjPFK9NDQl/RcsQ7BsIjrVUabZSw8pscVYHz2HKwrsgbFHUBWXKgUyMya081JmSnU2S9tMs3f0Jf2AQQEjM4fLI17S0R83fV7sFOLek+e2IRVfIskNpOND8oo4gmyNdDe0AUS7g1EhfZADrlyh2kRPub3PT8St+kTPdTyfkCX9T9XcjCKFUsSeCkTlesinFw8/6h8+qqcSbmBateSxYA+tA320RmY3w9YZxHHWsCJ85DGgtc8ikIXXrUBN0Ic1jeQUn3M63XY0XUaNc154EUiOBBzIiJRMWjfkuVDjcV/YbNx2IrdvDewk5LVKKcSPUYPQhJjHdif4oLSi8Xo64TQC85hxnCLfQeP7TvSOmFWxt3HtMeZOvEusOK1Kj/vAsnuB+uKQMGVGioTo9nj4qDwy3CyU5fYbtYzFLyLNQpJpPa+3KEyuOhJGEt+mHVEV+DAKzjAWTqo3saFvphE9+FDpId/2UcUwl6AifFms6PCNgd23phi5tlR6oGE6+tWMbBN4jbC33DX43snJ8ZJXPWweI19Q+lYhcVUrrCoOqCHTAroajkNf+by4MPc3oItSqKdcwnnlk0S3hoX4//00xm5/s9UbuFrv8IXHDkwCpcQfjMkSAUWYdyPm1aldHGi1rS2B9AcUZNeQOBVSqUk2T7a5QcO13Rcme5+oj6+v4mRDENQupTboSnA+ACk8nZaRNdt8MIP5mnUxlGhflOksy46QuMbUWINsjMythCcZkZ9JhMafytnQnH67KOPq9YztTyhVwB+Pbp6cX0RXL4uTdWG8S4P+bPn5KRIA3kNMedybR35GK9BGiPIyJlytJLY6oEE3ED9++F /9+T9lck SF0WWwrzJgB6h/y5grf5z49FR0UzMjLFk1/3Vp49DIcKzWWvofGWwnkKLWWeBKUUvP492qRCd6vdScrwC2jp/9meuQulGBM+l/44SNDxFpYhHdOYum5IvU2w6TzXk0dfkm5453khNxsjdtCj4LkrIjELYWI4Fbg3q85w7AI45WN1rOVLesHnBCespDVrS9mrhGjdhmaWi2NjL6C/PLv7BYk80fTWLarJBgj67pbKNJxCGm1PbzWsYBnlc8IR2pUqABAmKxFjqxKY37h1GphIz98m7yDpPDE8TJDnmotg8KPnZu/lDgw05P9NXY8Cymvt2Y8pD6nanwaQ4LHpXgDJXIa2bVTBrGoJDpviaQ8vJhPit8E2RHWPR+Lg/bY9xnFwMMUN+wi2c9KTRKJo0+lVa7Br/BOpyOCt5o5d8DMXRAELIilfj91uAtkAvLUcsFCbflPXRZ/erLmWq0XsRIc8hSiCdcA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, May 04, 2024 at 12:27:11PM +0800, Barry Song wrote: > swap_free_nr() isn't separate, after this patch, it is the only one left. > there won't be swap_free() any more. it seems you want to directly > "rename" it to swap_free()? Yes. Avoid the pointless suffix if it is the only variant.