From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B94FC4345F for ; Fri, 3 May 2024 19:51:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1493F6B0088; Fri, 3 May 2024 15:51:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D2F66B0089; Fri, 3 May 2024 15:51:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB5CA6B008A; Fri, 3 May 2024 15:51:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CE8C06B0088 for ; Fri, 3 May 2024 15:51:16 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 53045A1796 for ; Fri, 3 May 2024 19:51:16 +0000 (UTC) X-FDA: 82078128552.06.21BE08C Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id 1DDE61C0011 for ; Fri, 3 May 2024 19:51:02 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Vcue1ghk; spf=none (imf18.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714765863; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dT/tZ4BeVrX503tjBuNztLOilBaPjVoqnxlR5AjEN90=; b=qua1J3RtD4y1ebkpsxJr3TZrmYhloJ4DirQnX2hvcjVDCbTCzxB5ZcA76C7XCe3CqRPzK0 CjZxXsF0/7iwWPTjeyrNmpmCohOkHDXs8cxR3YavSerbEw9KVVqY/S1oWablNWt4fTQzX7 et+8I1WJC0XCK89G+fRxQUZ1JYH4g3c= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Vcue1ghk; spf=none (imf18.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714765863; a=rsa-sha256; cv=none; b=DaiWxUq3/dnRNMSMpEYlooCzXrlUeZsvLlVv97eXofkF9RIDJpBQ1qgSfbJMsBFlmoEI+i A2avaX3akTGFE5HuIbmYYhHQhAlr7Bt7aU2EbtWerdsYHWnOmYXwb42NJh4I8ywjUvccZn A45VTI+92pSmclSkz817bv6/ncQfk4g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dT/tZ4BeVrX503tjBuNztLOilBaPjVoqnxlR5AjEN90=; b=Vcue1ghkLjZN/Pe40AnCT5GmP9 p8Ci91b4oylITVwrlE0lJHNHQ8hYq8UsAy82XhSPcb+39l0pSU2jMCfwsg7UsBtpZdXW/2K3xIxGK u9HR7Zh2jJwR8nfJ2le4iJHsE2UB+SHcXEycw6svdqdqv/C/4U7+4JyRa+LItfjvHwd2Ds5L1J61F NTthaERztVnLYJ4DMtLSk5GPab0AxaDZJmRKX7Jo8NFhujqnDUmCjPDEcrf0hO5NLpC7lg2XzhU69 fnoJsP0dMW8pBG/xWO/jjigWBxxAZ1sUDpqirxvfJSUOJp6BTVnpp8l394Zwx7d2VYgPLAvr8HYML e/xZoG2Q==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2yvs-00000000EEx-2NIY; Fri, 03 May 2024 19:51:00 +0000 Date: Fri, 3 May 2024 12:51:00 -0700 From: Luis Chamberlain To: Allen Pais Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, ebiederm@xmission.com, keescook@chromium.org, j.granados@samsung.com, allen.lkml@gmail.com Subject: Re: [PATCH v3] fs/coredump: Enable dynamic configuration of max file note size Message-ID: References: <20240502235603.19290-1-apais@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240502235603.19290-1-apais@linux.microsoft.com> X-Stat-Signature: z3ei61fwyartii8rmundr8q4sfezh73n X-Rspamd-Queue-Id: 1DDE61C0011 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714765862-467195 X-HE-Meta: U2FsdGVkX18gmdw7zC/ADAJ3cMnprEAz+jqzx2VPojjT30cJbZcAjrjRB9y385+u7HK24V/YKDdbaUhWywFJLPoWH4rtCEtp+R7QYNMLZNNGssagx3WAyWvq920xxHROST+QAiPVtZOsEo0ozOzdvpZCCy4eHrCge3KnhkkdKErRgKiTPQFHhToL/jKKDlSJgX8MIxGe/0NkKsbmuDad9doiZvYfFzifySYS0LJCTu22Pw1XjQmPrfeEaz/KaNBQSM81H/aneDWuVNbQUPbYOAiv3e8N8tloMZXQqg5XA+2dyjULxTaKy4VI8C1rD+OYc+I/+vbu2hbGi5y4cKQGCCTW3JfS9Kzbn1guEblhWEdOW8zcxTE7ZOC4ik4fXaAobE+LzMWOV/BvdlxYr/K7NHCKoWzCI4ZnhML30gXGEoktisWrtRehgDMNA6sOpY3Igw4wjX7AdeE37AsBmdGJfyyagKmPu5Q7L9BHzpqgO9sHku49/xKB3BQCIhRZ4lGBYs1Ne9waJJogRxQy+0hffx8L8+AlxF5+ffhVhDrqUYP9RGHEcgICl5l2ybOZUyw1dlOFBSE7Ueix8Vm3c5jwy7cqUTTQ6xt9EiLmxo415BvkyedG+F9bzroXnylrB/LGzZrdSZ8CtKzrFDDr+H8YIpOcrpNkcqgQ6OOoMphAY+VSRgDCO36jvayHzXRiaIlUKAHipS+fOcOwUu14cRL0RNYWtCCOY/hehbnn75z5ij7mqSoK5YHSgONzNmDYQ3DvTwBxdo6a0LcL9rzHBvTzM9psOweHaO4qzK4ZiYGziuLPVZXaeuSGYJew0M9lFaPwvpTLeHYRgltF6grQo/jGu5RsTprLrFO8U+3eXu7v/b87G5V6XzTXXzrqELADBnniOS8BkK95VthffyqoKDhS70whZnbKjmGegFRwle1+diiKZE4zPTXkLajyIjXDgmNLItdYWqE0IdfV/S3UrlV UQKPBylj fIcOCJSL7orJeH8xEqZ1qCafBZ6gQ6AhyuiE1UNmF0fLdIrclde6KhrlCrLf6LJL/esfncFX/awOzLPPU4fBKR8yj1KLmIOr2EUXvv+OJxdfOCICa2ox8vx94lFtgiuzWVJE1BegwX46dcR4Hf3WeZS+DZEkY5MNkUD25EkrBqazCCc5GEniUDEFlFkgLKz2Zvro0G7za+zmy2F6+tIlYENJ5eDXZGBhzBpafiiDUnHcvzMONEmK5TF4z2WWpLu9r6Pze9ANudyERRkD4bCUaaEqrDf4qFhAfQ3IylEw6nLMho6zyGAlYoPXkRosjeC/QN8lx2PZahjIrj+jFX0jxFAWo2dUok9BgT5Bs5lEq6QDMa3byiFXQeCt87MsD824BAt5D X-Bogosity: Ham, tests=bogofilter, spamicity=0.004922, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks for the cleanups, this is certainly now in the right direction. Generic long term growth questions below. On Thu, May 02, 2024 at 11:56:03PM +0000, Allen Pais wrote: > Why is this being done? > We have observed that during a crash when there are more than 65k mmaps > in memory, the existing fixed limit on the size of the ELF notes section > becomes a bottleneck. The notes section quickly reaches its capacity, I'm not well versed here on how core dumps associate mmaps to ELF notes section, can you elaborate? Does each new mmap potentially peg information on ELF notes section? Where do we standardize on this? Does it also change depending on any criteria of the mmap? Depending on the above, we might want to be proactive to get a sense of when we want to go beyond the new 16 MiB max cap on new mmaps for instance. How many mmaps can we have anyway too? > leading to incomplete memory segment information in the resulting coredump. > This truncation compromises the utility of the coredumps, as crucial > information about the memory state at the time of the crash might be > omitted. Luis