From: Roman Gushchin <roman.gushchin@linux.dev>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Shuah Khan <shuah@kernel.org>, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
Waiman Long <longman@redhat.com>,
Yosry Ahmed <yosryahmed@google.com>,
Nhat Pham <nphamcs@gmail.com>,
Chengming Zhou <chengming.zhou@linux.dev>,
Valentin Obst <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH 4/4] selftests/cgroup: fix uninitialized variables in test_zswap.c
Date: Fri, 3 May 2024 10:56:29 -0700 [thread overview]
Message-ID: <ZjUlTeLGqyJubyKr@P9FQF9L96D> (raw)
In-Reply-To: <20240503035105.93280-5-jhubbard@nvidia.com>
On Thu, May 02, 2024 at 08:51:05PM -0700, John Hubbard wrote:
> First of all, in order to build with clang at all, one must first apply
> Valentin Obst's build fix for LLVM [1]. Once that is done, then when
> building with clang, via:
>
> make LLVM=1 -C tools/testing/selftests
>
> ...clang finds and warning about some uninitialized variables. Fix these
> by initializing them.
>
> [1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/
>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
Thanks!
next prev parent reply other threads:[~2024-05-03 17:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 3:51 [PATCH 0/4] selftests/cgroups: fix clang build failures, warnings John Hubbard
2024-05-03 3:51 ` [PATCH 1/4] selftests/cgroup: fix clang build failures for abs() calls John Hubbard
2024-05-03 17:53 ` Roman Gushchin
2024-05-03 3:51 ` [PATCH 2/4] selftests/cgroup: fix clang warnings: uninitialized fd variable John Hubbard
2024-05-03 17:54 ` Roman Gushchin
2024-05-03 3:51 ` [PATCH 3/4] selftests/cgroup: cpu_hogger init: use {} instead of {NULL} John Hubbard
2024-05-03 17:55 ` Roman Gushchin
2024-05-03 3:51 ` [PATCH 4/4] selftests/cgroup: fix uninitialized variables in test_zswap.c John Hubbard
2024-05-03 17:56 ` Roman Gushchin [this message]
2024-05-03 19:50 ` Nhat Pham
2024-05-03 19:06 ` [PATCH 0/4] selftests/cgroups: fix clang build failures, warnings Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjUlTeLGqyJubyKr@P9FQF9L96D \
--to=roman.gushchin@linux.dev \
--cc=cgroups@vger.kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=jhubbard@nvidia.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=llvm@lists.linux.dev \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox