From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B51C4345F for ; Fri, 3 May 2024 17:55:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E5356B0087; Fri, 3 May 2024 13:55:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 495506B0088; Fri, 3 May 2024 13:55:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AD376B0089; Fri, 3 May 2024 13:55:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1F7266B0087 for ; Fri, 3 May 2024 13:55:31 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CDD2A12101A for ; Fri, 3 May 2024 17:55:30 +0000 (UTC) X-FDA: 82077836820.16.0A839A8 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf20.hostedemail.com (Postfix) with ESMTP id 106CE1C0006 for ; Fri, 3 May 2024 17:55:27 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=G2jsJzdv; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714758928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cNuFKKqLOLJhX8SMJaQF7/ByglEMXWCW5PIO2/lIa4I=; b=eucqhGMZM6E0MhYNM9H4vNvKsd6EnGi6YxRghY5jxOhidSewRptYiUkMCqmnlbolLLqi7f Wa7jCV88ocg/jEFI56oaNLa6kF2dPhyisoix2Gp3UXLWgXIrV8/hQ3+ZQ1cc12APenz+YU MnUVF48SiaPDCamgYY96IOYrujmsYkM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=G2jsJzdv; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714758928; a=rsa-sha256; cv=none; b=iEq5YLr4o1I5y9wq4H1W+tPqry/gLDpzBpV7kXxtmgKGrRIEjD/qn9tWt901hkPh8/9anE d5goDB96LgpsBbAMyKYQCCQsuVmP6eFSiBu9l4+wdxM2cnqsZJI3/MFuGiCu9QJZKiv13d LTKj8BSdVXAs1mswe5hqS8RZns+x/F8= Date: Fri, 3 May 2024 10:55:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714758925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cNuFKKqLOLJhX8SMJaQF7/ByglEMXWCW5PIO2/lIa4I=; b=G2jsJzdvuUZLp4eVhkc8hSzuT9z9bvTkl0J5Q0mseVFULP7/68+AzPCz89WfVZFXA9LVrc 6LhE6NmD0yFvLnnUDePInuiyk3TBhDTnw/qv0m2zg+DHau2DtgaDKLsmCGlAZwTCs52jZo 0ppd4S6dB02WPP20Vu4C7t0AMo3Ys5k= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: John Hubbard Cc: Shuah Khan , Tejun Heo , Zefan Li , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Waiman Long , Yosry Ahmed , Nhat Pham , Chengming Zhou , Valentin Obst , linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, LKML , llvm@lists.linux.dev Subject: Re: [PATCH 3/4] selftests/cgroup: cpu_hogger init: use {} instead of {NULL} Message-ID: References: <20240503035105.93280-1-jhubbard@nvidia.com> <20240503035105.93280-4-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503035105.93280-4-jhubbard@nvidia.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 106CE1C0006 X-Stat-Signature: 5nicrga8wzsh9eqfhafpj7e7k1zxseer X-HE-Tag: 1714758927-876004 X-HE-Meta: U2FsdGVkX19WIPI5hEY4FH7LZvSHYRtM7axuF4Tc71s1WOAq6kqfahbS0YZ8f9mlujoTux9u74qB9RYBxGxGBSoWOPpgJHdhPwzElFH51hA4JnmRBZ7kkMIqIAgFUSTKYJF1oK7sFxmGH5vTMeoRQqFV/LGqiEhKcEQVPq2F+ET8ub20353/Wvfzna6HfPs6yNn63CMtliyIVDbJcC6saqSF3DisL7wG9XjqpYBxbbkIhbBXd2Iqx/NtaUBEQM1KQmmRssm1zW7YLQRxVguAH/ab5hQLGqOUM+CXGQcn+F9EqFLqYNrU7JSjm1PAW/uk8fJvBzKWHtm2lT0B0EKX8uqEHo9NWbg8B2/H4eQtwRCDp//X23GuSINI9igJ2qITLLF0QmjQLkNc4yxeRDN1RnwKHRhcDuuy0RjO2j9y0RXQGT7sNqFCvGcknhMLXpGH0rG8WGvak5/crz2+kDHtCJ85eR5T4KxdjzwxHlQwbdVDW4ZbQ6pWYMfRdWlQRvRvepM6IE3+h1kU7cJX0uHkh5txu+PtBtNMt7T2SmG2mzZW0oRXKgDTlpLpGfG4pLtl3Ipq9hYRJagzkRsrZjwhUmcdL2+Gi+ocFFIbj2sFaxPyj5qylnNmWq4P5zFTldnT5tO7td8y58WV50bOCNDFzeoJ0tcP/FFXmnKn87Vm8pW8I/4XUvEsVJ1TcwCTl6ZMRCNX1z2unZkmqR50EODXmydeaNZBIoE2fQ0izcwQWU2LRqNdKsvHtxzcyNomCba2AuReAMUPO8Ng7cDzAdAGw/xPC+eD8DXbuMiNBzcM3UUecA3zMp/TqdEgHgSn7fIiov7iY+hdegA2g/vT8PVQ74ZcU6KcWCIF3CbJqPPJxVYFZtLdcZogasdGK7O7XVM9t2O8n7kB8GS4IItcROMODlWIZ4ZO2LI9n02QxTXe6plCa3ZhzTeQKQ5wfg6pzp6Ln3GwElijFw9t7nXR7HS df+D2wtz U8q6lbRg2CcKAJ7j/4LGo6MoOrMN7Pv+2uM1kobJ1SN1wIj6mCMMeIpHKpj+QEZCWs6NXTsEpxzrHl5WxFh/mbBc5OqRc341peNLsTTrUU6AWU9KHSCx0Lq+nmVR8JjZCznmuYFmjLLAGGJOxhOc8GWMckflW1c+6bqpWFyA11/n4bbRghzIaM3r7hRrpMFOnql9m/U19nMv7hwY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 02, 2024 at 08:51:04PM -0700, John Hubbard wrote: > First of all, in order to build with clang at all, one must first apply > Valentin Obst's build fix for LLVM [1]. Once that is done, then when > building with clang, via: > > make LLVM=1 -C tools/testing/selftests > > ...clang generates warning here, because struct cpu_hogger has multiple > fields, and the code is initializing an array of these structs, and it > is incorrect to specify a single NULL value as the initializer. > > Fix this by initializing with {}, so that the compiler knows to use > default initializer values for all fields in each array entry. > > [1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/ > > Signed-off-by: John Hubbard Reviewed-by: Roman Gushchin