From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C53AC4345F for ; Fri, 3 May 2024 17:54:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DF076B007B; Fri, 3 May 2024 13:54:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6901A6B0082; Fri, 3 May 2024 13:54:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 556FF6B0083; Fri, 3 May 2024 13:54:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3659F6B007B for ; Fri, 3 May 2024 13:54:05 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 90D621611B1 for ; Fri, 3 May 2024 17:54:04 +0000 (UTC) X-FDA: 82077833208.24.6570546 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) by imf01.hostedemail.com (Postfix) with ESMTP id 9C98040013 for ; Fri, 3 May 2024 17:54:02 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="ZctGSkb/"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.181 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714758843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x0XQCMnsbYkYwtaS+30vq6EUAn0n4Ulc3+8JbTfZjrU=; b=v9zR2JEqMfD3k3rgsz3C8fuEfXEloDt3EMsG4PU7Qud1TBfw4C6OqvSGVH9/Vqc5FRUuiw +xgFjTQm9YmyQgIZ19/ElZflshjWOxHIYBJVFvkrf53/JFcKFVjp9zQ2ikPjm7UJ3BGqu4 DRdYRgaHf2blil4HHy2rFkinWBE2XQM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="ZctGSkb/"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.181 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714758843; a=rsa-sha256; cv=none; b=UsRL5pYzKqmMyaAk/KwRMeaSl72ffrKAc/5n3DYzeFwnxRYMaha9omT5U1dwBBft2lLSPT Ot5sqVa+71HnYm/4WW8QOyCstVplSElSx2HlnYYz4N9sBllzAE9kajxroDwtwKBW2d6sqa CyTsfnqFGfq5y1fHHJSU3XWl5RBHTl8= Date: Fri, 3 May 2024 10:53:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714758840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x0XQCMnsbYkYwtaS+30vq6EUAn0n4Ulc3+8JbTfZjrU=; b=ZctGSkb/BdmDJ3EmsYgUjqlACWFjy+wtUCPB5wpK9c5hQuQEhXvroesiWdCKe01cerZhl4 lZc2TSh3k0fCMjFNX3qYzv8AV5+b9Uo1RSM+OJL5ZuEQ1aSTBZwiQmRr7UjKQO5J6VIddu GriUkbStsO1LOxVEf7YwERAckrj4XkM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: John Hubbard Cc: Shuah Khan , Tejun Heo , Zefan Li , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Waiman Long , Yosry Ahmed , Nhat Pham , Chengming Zhou , Valentin Obst , linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, LKML , llvm@lists.linux.dev Subject: Re: [PATCH 1/4] selftests/cgroup: fix clang build failures for abs() calls Message-ID: References: <20240503035105.93280-1-jhubbard@nvidia.com> <20240503035105.93280-2-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503035105.93280-2-jhubbard@nvidia.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9C98040013 X-Stat-Signature: 4cwh85kf9bx4m6r1wa5w6zn5powkf94a X-HE-Tag: 1714758842-450603 X-HE-Meta: U2FsdGVkX181Yr1fRLIl7XBYK/jbI4EvOPvMFsnOpjiSyJZrWjEzsf/siuzc0biF3XDiS11+qTCd0+xXnk8Z2LRhbji/qlHkXBrTAnI482n2uSu5zf2IgjBH+a5/Ilk9cgrvzEAJnzR3pByBekq9H9Lic7TZXAEKbmlnnb0Z1a0ihSNwRGHrux14pZIUDW3eOvKEyKw8OC+9abp143Gs1sC5Loiz6NKR36Azah+UBepqRthzhG4SSRRr4VyTI73SrFd+tdRK5PmqGjAxs0mtGoKgz5DF/e394kHGibadDjIqNlcC9RtPJQ3tiJzDsUg65pdF4YeVfrNJD5aqPjBCSyIZga6DtAPdiuoB5HvEefWlzIO1QqePyK/Mjfwkvb3sMF/asE3e+1Y4magb+MDlZ6XBOp1hoqNIPhZ61ZC3qXkDGRakLRhb3W7nlPwcM+LRE/2Qp6SKirumN8+64ofQo/Ga+rjoIlR37+qQDKRR4L4laSKZFFIqsE/y8QVe1lxqyebibq1dKq9s3sM7Nok3uL4myGYBEUzyRnoAyeWrbZmkf1xQS/IhXmEYjbFArf9dw8vJBjWPCw6wpTklIsLdyTN0aTmLQL9pd291aXLsQ6H36jNPEMTpCA22EMUwTqmr5pvVFOa1JsMqg+ZpJ9yR2EyLzSPKYMeuVJlftoAVLJIlQkoskhuOla5cnuA3lK3dpJD5orcfBywCxZJp1hbloE9cPRH9lDklC3pXrZO8z8xLFNAGUZH3bL19+CjSKQxGExFqN5qi8NlWAzYKlvcXopcRTsoflZNZPXvXwpEzWkzgZgRC3N71App6oswXKuMNJ3pT4z2Osy4i/e6eAc94AjE+JK3v0k7wq6cMBtDuRVIG/ITn6CU/IxPf92iRpth+8ggGIu5+el84BOVVG9Oyy292RUT0HPj1HEAHPgJgOQlnFiD2pLXA8yqbL0SPE93gQOTFjWMuDLpLPpnGYms M0U7jxLY rLbrssq24UCHCarZnGHxZa40MdSXa+0kvplzSYKOqyabnqphgdvRHMeEO7RxdnxdA0rd/h+Fb7gw+NiNzJH48iHlWnFfi2MWG03WJysDn9guqIhDRZSPUiFUQM5fpnOSeuKYxLdMiNs7++6UOkkJjE2zsxfXooLyG/Cntu2UrXofPwko= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 02, 2024 at 08:51:02PM -0700, John Hubbard wrote: > First of all, in order to build with clang at all, one must first apply > Valentin Obst's build fix for LLVM [1]. Once that is done, then when > building with clang, via: > > make LLVM=1 -C tools/testing/selftests > > ...clang is pickier than gcc, about which version of abs(3) to call, > depending on the argument type: > > int abs(int j); > long labs(long j); > long long llabs(long long j); > > ...and this is causing both build failures and warnings, when running: > > make LLVM=1 -C tools/testing/selftests > > Fix this by calling labs() in value_close(), because the arguments are > unambiguously "long" type. > > [1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/ > > Signed-off-by: John Hubbard Reviewed-by: Roman Gushchin Thanks!