From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59F85C4345F for ; Fri, 3 May 2024 17:54:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D49D66B0083; Fri, 3 May 2024 13:54:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF89A6B0085; Fri, 3 May 2024 13:54:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC0886B0087; Fri, 3 May 2024 13:54:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A11B26B0083 for ; Fri, 3 May 2024 13:54:46 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 29A12A218B for ; Fri, 3 May 2024 17:54:46 +0000 (UTC) X-FDA: 82077834972.05.1E1B55D Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) by imf04.hostedemail.com (Postfix) with ESMTP id 4604140018 for ; Fri, 3 May 2024 17:54:44 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=w3LHePTe; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf04.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714758884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=viaLAewCzGtCTKetlsX4e8AVwuJyrmIUfGHPX1vb/sw=; b=Y0IRl08zxYilbXSXhGDYeUvPkMr6WOLZNEsoU6fpzCZsMmX4XXFfNTOXFaxznGHx0xqLkx iYVBAWme9s/sRcMuuTCHbPZHSmer0Bq5Zp01Eemp2wdjVHHkrtQof+/AHFn+zOhQ7Pq7ng zwd806F8QfrKrYjjppyJp5M3cLi5xQ8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=w3LHePTe; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf04.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714758884; a=rsa-sha256; cv=none; b=egagrvQ7Bw/FnGzMEwhTqvWg7fKREkaOBAfL8/7V28Qm7OmSdeqFLtnMY6n3c/WuSg4EKc Y0jQOA0rOOm2OmWm9UIDXeKbm084EuB4fsOaPKLTGixdcqTuIu960nyQAIRTv85yj22/Pl KMWDOmGfMZO5BMeCwzEWxbLCmM4PaaU= Date: Fri, 3 May 2024 10:54:36 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714758882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=viaLAewCzGtCTKetlsX4e8AVwuJyrmIUfGHPX1vb/sw=; b=w3LHePTeLz2K9FRYMUNxS0jF0kYOiNeduwQD8+4Y7GA9YHHWJydFV5bJtZBGuhwbEHjcGY NjvQKoPD+odFWT6rzgaNHNzKFO2j5VP/PsjME0UqhJMJEDtZLeAP+Am9BJ9V7/D4A3/68r rJOxx5DkCTOJOpWB87WtS80/G6IA2UA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: John Hubbard Cc: Shuah Khan , Tejun Heo , Zefan Li , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Waiman Long , Yosry Ahmed , Nhat Pham , Chengming Zhou , Valentin Obst , linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, LKML , llvm@lists.linux.dev Subject: Re: [PATCH 2/4] selftests/cgroup: fix clang warnings: uninitialized fd variable Message-ID: References: <20240503035105.93280-1-jhubbard@nvidia.com> <20240503035105.93280-3-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503035105.93280-3-jhubbard@nvidia.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam01 X-Stat-Signature: yjkqzmy9wqeq886z9gwwpcakia5p437m X-Rspam-User: X-Rspamd-Queue-Id: 4604140018 X-HE-Tag: 1714758884-827386 X-HE-Meta: U2FsdGVkX1/RCgbG+HVrARFwUzMeyq5CdV0VVZoK1ctbYjOem4PvRIZQgIn+OmtiA64peshv+lXmAxLVimuTvt5f60ErzEi0dMNyzd/966kLgkUfRmBKvyE1jHN7B8H55VQxI3MJHqP3+EPx/SsWFCwBBhLm1PRSaIcurgSKFyhZq2fIKjXy+iuRk+GXkk7ppzaW/MqQjneyWgfgqkXhYBpw1x1JrodwSljjNT2g0Dktgfd+s6NM9sbFoArkgjEqyPTr6sQZl6r7GMyvoBr512n3zlTU73NJAJyCS48/O8MBuYOOwUYn/FoqNNUqYqkfLWMr/HhtV1ao6WEnoayVusJE/0hDIEKQw9k0hr4CrSKnAmdpkJnNq2qzLSOdAx6hJssu1drDoHZpRd95NkjkzUVa2u8KkdQCkJ8i68F0SQKkqWOQurW22oQOCLA5mS3QH/14sqmqmKfXR38bxwXLE9SbUmGmbEqBX/ql4tKxymelEzNIJGOe+zrc7KqZQtoqXPoJ4Sf/OjF+GHpNEkc/h/EHpqJZmu3BwwxYGd93xJUddR490nRo4KL/HbO1R+QiIuR1JYL11B7yNsIES3IvwuC3gFlcyprQsASm1TLafH4VCh1ebgoK2Qy2dRLydgkocUGqYWEXJWY+RWFrFeemLTbD/78+QnO8bkoxu6Snik5aDcJjKDhkK6LJAl/Z+A4+c+519rhgm1WEpA6tXhlKQWi//uqoBs68ZDtvRsBfaxSsBiK1mM6CGBX8ebfs7qo0OhOUR7y5XcWPpepfYN0wPhNus7xii9xnnYI62JSoCq5rj7YsjwTiZcLvPWg5Um2dum2KQkWxPttQ91lSjqOfF50//CYQbKuHNPb91waFzUKvIwjL++q7gMYmc/NRTpU6oUYnyRf8C8PEruV55cDLmGXZcT6itPfIQyg48kv9hF3hue1tEsX9F4ohF2uwHZ5jnUw5AGQVSWsWwsCYq08 qZsVCdB8 j6cD7eDlEeGiZYJx9kcmvqjyUKEO03HcYg4F9fFMb+GjNX32Vzn8+P3aAuG+9TMywSsqXNDZPzMmcwbPlZHw8ExSIWIbeszhxjkzCAWudwWS1JfefQGYloG9zomenwebVLzjq2FqyoEPJIw9iWYC66mek1IIYaf/abZbXajH5XgCrGug= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 02, 2024 at 08:51:03PM -0700, John Hubbard wrote: > First of all, in order to build with clang at all, one must first apply > Valentin Obst's build fix for LLVM [1]. Once that is done, then when > building with clang, via: > > make LLVM=1 -C tools/testing/selftests > > ...clang warns about fd being used uninitialized, in > test_memcg_reclaim()'s error handling path. > > Fix this by initializing fd to -1. > > [1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/ > > Signed-off-by: John Hubbard Reviewed-by: Roman Gushchin