From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE99C4345F for ; Fri, 3 May 2024 13:29:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C32516B00AD; Fri, 3 May 2024 09:29:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBB1A6B00AE; Fri, 3 May 2024 09:29:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5B9E6B00AF; Fri, 3 May 2024 09:29:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 83AFA6B00AD for ; Fri, 3 May 2024 09:29:24 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 341561C1826 for ; Fri, 3 May 2024 13:29:24 +0000 (UTC) X-FDA: 82077166248.22.553E807 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 1B0BE1C0005 for ; Fri, 3 May 2024 13:29:20 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vyLLstx7; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714742962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B4vGEHzdNP0JI6MVfnMEc2HH+iREkCFMbJn5Sb6HqFk=; b=XOlZMqa+djrOnj4kd1fRtsc8OWaiQ4FUMbpTiKOwVDV737+zYMiSGOPCeWwn/NOWtTqtSB m8o8O5OyXJw2X9NV0p0VzLewPcgxbIBJwBuFwPMbuVZ5u0E99ttx9Ap+cn9Npg4+dGjZuB sBhS2QwEWb1b2ypkBxVtw37Q6WffP/A= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vyLLstx7; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714742962; a=rsa-sha256; cv=none; b=NOwURx2GHQsjPqM0b2RgtFJWY/UhDIsJPyJD+TiTWiHPtFay4dtiy5r0BjjmHuioWaRiB7 JmNiwyGRPB7CQuEVYh9r3djUcETpIWW3D9QOgsbnlp9dSL2ontSrIWTWBwh3Suuh5FNf1N gn8ibMhNO3b6qrIEu90ompY9wRY9X+M= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=B4vGEHzdNP0JI6MVfnMEc2HH+iREkCFMbJn5Sb6HqFk=; b=vyLLstx71zYQ4dLqtph2CDUj+p 4fnR6BL+Okz+uf4nf849UeSXiDvMt+xq7tyKuk0lm914JHid160ckzKjMqDnGRrB92NX/rV4DG/4J DdQZ2cFbc7fMdr1eLEOpLfXaDJb42IX9fPpf8TfE+uib6H2/eY22UbRTA/SH8GTX68ufvPrAch9EE ABPi6BKh+FehylrEaqHRW5UPjwlPUztLXVkmasu812PxMNZ3gNcKg15FrNpj3d/EikJ/f1qJ+jLkG RuzWOMg4g3xEY1B6oOy6K9m2VBMDGLXDOqgcAcN2A+ORCVk0u5/AspambjlJfRt9TROFVnZaox04h NKMaPoIw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2syO-00000004AOu-3hKo; Fri, 03 May 2024 13:29:13 +0000 Date: Fri, 3 May 2024 14:29:12 +0100 From: Matthew Wilcox To: Kuan-Wei Chiu Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, nathan@kernel.org, ndesaulniers@google.com, morbo@google.com, justinstitt@google.com, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, llvm@lists.linux.dev, jserv@ccns.ncku.edu.tw Subject: Re: [PATCH] maple_tree: Fix build failure with W=1 and LLVM=1 Message-ID: References: <20240503095027.747838-1-visitorckw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: owoniicbq16syuhzj4jwkxp3fwp1h8uj X-Rspamd-Queue-Id: 1B0BE1C0005 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1714742960-311977 X-HE-Meta: U2FsdGVkX1+5QPRPSb6nDRnwgKA1cAzr43excNdTA2sSv5J+F86zZPyNEByE7B3Fv8ZQjMfVikIM+2+QgWLS8Qooi7wAt2m5jVXpfM8qFfF9RbTkPUWzPKW3oLASldpaRMwZ7SfmP1mbWWCN79wdv1ELeDdDNL9a4OXkAbnkXtDfTvF1TdvleOb5ftKcvNCy3bODKDpfZDV1xaWkBGqyfYp9fzvjaxUbSQyZ+nwRQHHx0Cmm9Z0pUzEYQocG3YCvpXe24XMNswcjQSS5YrUpZEDZttuCj7lMzBIUmAklLjbe7aiBWYTPxPBDBnboafTok4xACUxNruU7FpJz0dXlyvx0h44IapXv0D+NLsLp/dQWpxYvoWnOxw/dZ841FBlN5NBXud0pdUhw+8t7i/DVnKXWqMCwFHb7wgtpygFqT6N9oyef1eMQFZ8/1ZQAnzDvJrx5AfTbEuNHLWdiFrJMALOjgjG1/8tUlraL8F07Vmbseya5OnsZGQYWbc82KIv3jf1pAbIC8FWrIlG9YNer7m3uM55+WcCFODVkWpoTxrcEHs2S/katZ4M5kxoGKqv66ZYx9GIiX5XOcz72zeixJ1eyQOoXl/yknT1+tNlUVU76UjxMAost+Sy+EdZjRZzf7ZqkXMn8y+3/osVp2DwMIQqo5dHdvOyL9JBPe7Bu/SkYXo8rxeKaFb8wo1BLCl3DH7QzmhwKpWJRjEnvEz4qIp+9+DAq1dg4M5aWvo7Wx4ajsZI2Zlca1MMaJkHumm3RcPjtN+yg+m5vuJij/jTirreDSdrDqmOQBMdDgsiKhAmlhFw7TJvAgWGiN1Qjch3yz8f9exW7gsVOp1WsBqkaD582RIfmSQMy3OxjOmaxKBk0yDwP8Yju36DJXmV0hn5hfwitJMrG+PzEQ3439CWIaMS+STW7+nV/W7hqes+BnCOpslk1FBlqOm6xTckvrh9Ex5F1DURs/ARE63tOFDW jRy26cPv VQIMusNpt5gSMg5paKvh2FBUfsCBK9NfawrrYydSGcetnDTAq/D/h8kMbvVrsaIZguXVH0+QZYgM/d6ACJO+flhl5JbtAm4XpMdjIdc/E13WLWxcTjQZ/X1xy/k4K9+cN3YBixEqUVtaJ65Lepv86YAwYraXQVAL/hNa65sN8YVf9I4+bgvXDrJZlPStDyN7uB/s8U6JxLLYDVNDTTiOaarJbxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 03, 2024 at 09:01:06PM +0800, Kuan-Wei Chiu wrote: > On Fri, May 03, 2024 at 01:20:32PM +0100, Matthew Wilcox wrote: > > On Fri, May 03, 2024 at 05:50:27PM +0800, Kuan-Wei Chiu wrote: > > > When compiling library code using "make W=1 LLVM=1 lib/", clang > > > generated the following compilation errors: > > > > > > lib/maple_tree.c:351:21: error: unused function 'mte_set_full' [-Werror,-Wunused-function] > > > static inline void *mte_set_full(const struct maple_enode *node) > > > > Uh, clang is wrong to flag these as an error. They're just not used > > yet. > > I think it's because the kernel defaults to treating all compilation > warnings as errors. If you turn off the option to treat compilation > warnings as errors, they will be treated as warnings instead. Should I > update my commit message to change compilation errors to compilation > warnings? just don't use W=1 and clang.