From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA02C4345F for ; Fri, 3 May 2024 00:23:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F43C6B008C; Thu, 2 May 2024 20:23:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87C736B0092; Thu, 2 May 2024 20:23:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D08A6B0093; Thu, 2 May 2024 20:23:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 458C56B008C for ; Thu, 2 May 2024 20:23:37 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CC30AA0D62 for ; Fri, 3 May 2024 00:23:36 +0000 (UTC) X-FDA: 82075186032.22.5D1FC8F Received: from smtp.dudau.co.uk (dliviu.plus.com [80.229.23.120]) by imf25.hostedemail.com (Postfix) with ESMTP id 13D31A0013 for ; Fri, 3 May 2024 00:23:33 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of liviu@dudau.co.uk designates 80.229.23.120 as permitted sender) smtp.mailfrom=liviu@dudau.co.uk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714695814; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vvbm6f1KTBJNSflUe4I7QM7JUn6otYIneqJrw9kx1wg=; b=5TBPXGTzvCiqNwNlPI13hi+yBhXPx5jKHKauiqXmSMLWIUOH81BCmOLrcAQe5CMTlA+cNt sAE0Kic+V0oMaLUwL2H48/L81KDErxBIRRsWGBQ4VZIWeQ4gSB4BNITeikC4ur3o+ncY1H em1IDPDRFyx/Ej5cb2VbdIgtZbtfeVI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of liviu@dudau.co.uk designates 80.229.23.120 as permitted sender) smtp.mailfrom=liviu@dudau.co.uk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714695814; a=rsa-sha256; cv=none; b=7AIma//UcSm3FBQWXNQzVzX+N2UTsdDsFces4do8HC+k2cHLjFcGnVIDTSsAhJHIUa13h0 LO4XjP4pG3EnPGlCiPALWzEZXHSr6qPcrB05lpVSzza8INOXhmft+skVkSKO1AiQ36pU9K kapGagPnwrSICHB+WjPTXeWOQKm+7Xg= Received: from mail.dudau.co.uk (bart.dudau.co.uk [192.168.14.2]) by smtp.dudau.co.uk (Postfix) with SMTP id 2D79141D12F0; Fri, 03 May 2024 01:23:31 +0100 (BST) Received: by mail.dudau.co.uk (sSMTP sendmail emulation); Fri, 03 May 2024 01:23:31 +0100 Date: Fri, 3 May 2024 01:23:30 +0100 From: Liviu Dudau To: Luis Chamberlain Cc: Mike Rapoport , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Mark Rutland , Masami Hiramatsu , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Peter Zijlstra , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Rick Edgecombe , Russell King , Sam Ravnborg , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v7 00/16] mm: jit/text allocator Message-ID: References: <20240429121620.1186447-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 13D31A0013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: gijxq5h7oku5ytjpmhxqzj9ocrucu8r1 X-HE-Tag: 1714695813-416068 X-HE-Meta: U2FsdGVkX18OwKkyleUxj9/hwXoWGWQ40gSCAcNkUeG3rdroPA2iueGzxzmXSYGg5nEGQLnZOHLjG+IqWpkCa8y/TgzuY8N2MgSVgIVWJ68+yd7rNo/yX9qGlRAeVjvHSxm6uD17e+6uNX3uDBwXfYjB7Nce9sMthQ7kxUQOzSUREplXP3jUxvJe0yrKv/41PLp7VAJyrMygTLRXBLGECsWMYHTvV2xhcQFkMh7PTA/fsL8VFSg7od6gkIxK+U/vRCBVy9PGcMnC6wnEYGDfrfNBUfThdHeUu366OhuXx7PoQjXF1FLF/58vkmFiIrOkz6shI0/gFFUaa0QGEljDFNaZfKbHZ81+7r0BJkvkTvGE1Ro1vbxetEgC8DSPl0PIGwLQ8wrFziy0HHYFaK/aPayn9YoIHSFbvti388TgN7n60cReoWTo+826+YgyQf44645kLuVA4U5hjkHe1I6hsuO7KeJgyEXS/EJ9S6IvFcrb/cb7FXcAN85CHdZx+YJvfPYGA5QWxvaAg6RD5nVt8a0zHt2aENbkPqJctCEuejD82qSLfLUQvz4wAIW6vPgIKAKLYJcV2y3/xOx49h4b/mnLW4kuRc0Loimh8vXPrUDXakhjSJ6CIBDC4BF9Jpmo+/IZLDxr3LllA3fSRHIPXWGZ3213uD1k4IVPtmkvIbrVkG0TBYVnME/vwf5XN+fUI4yEAUeomfUt6aj0AXXLn7BQ78FF/Xntkg8Z6GSjRbiOd5eihixG9PjjEIBNdUNf/HeesIe/PvjRz+pr1XxRkrNuCkJVFXlgMs3LXmebuwiVMhXt2ZMlDXsr+8AWz5IyQMLLtMxDI5k+2L9Bs78+XlBtk7VsyO2cjFdM9/9ecnmyLkYOaFi7JQzHh638ZsAHcLjXYUq/we48fsb3NAMGcnB+UTTIxTJ0pkmuokaQuN+TiVEwvkcWCRLWtbwXL1ziUUDBbHQyPI06sjiHgdp KovpbIrf VZf5xnPGHnJvtj+soGRJJO+UiXnm1g4V2nVryYOc6XKz2eG48g0aTx5mv0F79IKvjefCUAmgLZGNb1DfPK5zCeN9Rkagxz8akbtSgGcBh4gAhRbBARIkFVQpjmAIWquiQS1zjZbQJW/iK+wTTX+PyOzbUutKUNiYh/k7M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 02, 2024 at 04:07:05PM -0700, Luis Chamberlain wrote: > On Thu, May 02, 2024 at 11:50:36PM +0100, Liviu Dudau wrote: > > On Mon, Apr 29, 2024 at 09:29:20AM -0700, Luis Chamberlain wrote: > > > On Mon, Apr 29, 2024 at 03:16:04PM +0300, Mike Rapoport wrote: > > > > From: "Mike Rapoport (IBM)" > > > > > > > > Hi, > > > > > > > > The patches are also available in git: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git/log/?h=execmem/v7 > > > > > > > > v7 changes: > > > > * define MODULE_{VADDR,END} for riscv32 to fix the build and avoid > > > > #ifdefs in a function body > > > > * add Acks, thanks everybody > > > > > > Thanks, I've pushed this to modules-next for further exposure / testing. > > > Given the status of testing so far with prior revisions, in that only a > > > few issues were found and that those were fixed, and the status of > > > reviews, this just might be ripe for v6.10. > > > > Looks like there is still some work needed. I've picked up next-20240501 > > and on arch/mips with CONFIG_MODULE_COMPRESS_XZ=y and CONFIG_MODULE_DECOMPRESS=y > > I fail to load any module: > > > > # modprobe rfkill > > [11746.539090] Invalid ELF header magic: != ELF > > [11746.587149] execmem: unable to allocate memory > > modprobe: can't load module rfkill (kernel/net/rfkill/rfkill.ko.xz): Out of memory > > > > The (hopefully) relevant parts of my .config: > > Thanks for the report! Any chance we can get you to try a bisection? I > think it should take 2-3 test boots. To help reduce scope you try modules-next: > > https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=modules-next > > Then can you check by resetting your tree to commmit 3fbe6c2f820a76 (mm: > introduce execmem_alloc() and execmem_free()"). I suspect that should > boot, so your bad commit would be the tip 3c2c250cb3a5fbb ("bpf: remove > CONFIG_BPF_JIT dependency on CONFIG_MODULES of"). > > That gives us only a few commits to bisect: > > git log --oneline 3fbe6c2f820a76bc36d5546bda85832f57c8fce2.. > 3c2c250cb3a5 (HEAD -> modules-next, korg/modules-next) bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of > 11e8e65cce5c kprobes: remove dependency on CONFIG_MODULES > e10cbc38697b powerpc: use CONFIG_EXECMEM instead of CONFIG_MODULES where appropriate > 4da3d38f24c5 x86/ftrace: enable dynamic ftrace without CONFIG_MODULES > 13ae3d74ee70 arch: make execmem setup available regardless of CONFIG_MODULES > 460bbbc70a47 powerpc: extend execmem_params for kprobes allocations > e1a14069b5b4 arm64: extend execmem_info for generated code allocations > 971e181c6585 riscv: extend execmem_params for generated code allocations > 0fa276f26721 mm/execmem, arch: convert remaining overrides of module_alloc to execmem > 022cef244287 mm/execmem, arch: convert simple overrides of module_alloc to execmem > > With 2-3 boots we should be to tell which is the bad commit. Looks like 0fa276f26721 is the first bad commit. $ git bisect log # bad: [3c2c250cb3a5fbbccc4a4ff4c9354c54af91f02c] bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of # good: [3fbe6c2f820a76bc36d5546bda85832f57c8fce2] mm: introduce execmem_alloc() and execmem_free() git bisect start '3c2c250cb3a5' '3fbe6c2f820a76' # bad: [460bbbc70a47e929b1936ca68979f3b79f168fc6] powerpc: extend execmem_params for kprobes allocations git bisect bad 460bbbc70a47e929b1936ca68979f3b79f168fc6 # bad: [0fa276f26721e0ffc2ae9c7cf67dcc005b43c67e] mm/execmem, arch: convert remaining overrides of module_alloc to execmem git bisect bad 0fa276f26721e0ffc2ae9c7cf67dcc005b43c67e # good: [022cef2442870db738a366d3b7a636040c081859] mm/execmem, arch: convert simple overrides of module_alloc to execmem git bisect good 022cef2442870db738a366d3b7a636040c081859 # first bad commit: [0fa276f26721e0ffc2ae9c7cf67dcc005b43c67e] mm/execmem, arch: convert remaining overrides of module_alloc to execmem Maybe MIPS also needs a ARCH_WANTS_EXECMEM_LATE? Best regards, Liviu > > Luis > -- Everyone who uses computers frequently has had, from time to time, a mad desire to attack the precocious abacus with an axe. -- John D. Clark, Ignition!