From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 867B8C04FFE for ; Thu, 2 May 2024 21:35:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B186B6B0085; Thu, 2 May 2024 17:35:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC74F6B0088; Thu, 2 May 2024 17:35:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98FC26B008A; Thu, 2 May 2024 17:35:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7C0586B0085 for ; Thu, 2 May 2024 17:35:26 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 01B5A1C159A for ; Thu, 2 May 2024 21:35:25 +0000 (UTC) X-FDA: 82074762210.07.9B69A3B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id E3BD340068 for ; Thu, 2 May 2024 21:35:21 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=kMWDdPq6; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf17.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714685722; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tlFW8nHNMe/kIplt0cgGnakBNynrklQOcrWEc7IQ7x4=; b=lqthd0S3I6UX+/l5bcMoTqT1n+2jIFrA7TQDi3ab002iSlbgkewTfr5xuItc/M+ldo92on HLHaL32JcHuvVLR7EJJJC8tU376GMR1Ustzvn6gGnYJuRJM6jZl6ozucBA4UWvxajgqal8 +2sbCdi5cbjeEYhkYxw8xbaIILQBxiE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=kMWDdPq6; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf17.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714685722; a=rsa-sha256; cv=none; b=vzDmV9pSa/9kWTixB+FwFu5JshQIlTvu9N5X72gsz9VZovLahVgQAfS7Iw+zkdSXcFRDkv 9MZNSmaLKalmnSMjgAZtlJGi9UxiyD41i9aohN5su2a3p6z/R3mAfvQIN6E5XV0AI9/g82 Uh8RlYanYD9Ojtferb+9fG+RkW2IoVo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tlFW8nHNMe/kIplt0cgGnakBNynrklQOcrWEc7IQ7x4=; b=kMWDdPq6vs1CUwS+IRPUbgpLoA IC8dWLw6FaCljPdIJWTkh4MImGo5Ty2XG0jnQ8eMOHqj4i6byL8Sstn/I4JOXliEjY5jvCvoKaXl5 3HNrPT8//2gKQfyGPO+EdzOS84mlIe4MG55TupkdB6W/+SMQsanlE73aXBjYgUvUyd6BkYHL91/PC 3M4qdcaMnIyXnnb1dGoniT1IqGRPS3wXcU353S1r/zt8TQAKllsLUF25JhzlqPgToXZl+ifv9vhfn IMfo4YL3OH/6ADo5OwtaFfxrA0OzfbMUc5ufFQ+yul6Cvb1v5xzR0CiEPQC4UOXdXQKpsEZhZfqOc fBEUzOmg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2e5C-0000000DzCy-2lmy; Thu, 02 May 2024 21:35:14 +0000 Date: Thu, 2 May 2024 14:35:14 -0700 From: Luis Chamberlain To: Allen Cc: Kees Cook , Allen Pais , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, ebiederm@xmission.com, j.granados@samsung.com Subject: Re: [PATCH v2] fs/coredump: Enable dynamic configuration of max file note size Message-ID: References: <20240502145920.5011-1-apais@linux.microsoft.com> <202405021045.360F5313EA@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Stat-Signature: e5xdxr7hfhsp635hzzwiqchgt34mdswi X-Rspam-User: X-Rspamd-Queue-Id: E3BD340068 X-HE-Tag: 1714685721-814499 X-HE-Meta: U2FsdGVkX1+MWshGAI8xlSLbexStqIo9zURpN/JjbivZOqAgAxoFn9BSOUc/Nh8z9Wzi1Jeu3PVkdMyEn9z7Mz02QxAf3FeDFcfy1THvEXflQEhO174smHpAAxp0xgNdT+LKVtqkOzXByEn0v0sNYLz1cbcKvCpbyvVJH61D1gQfGOT6pE123Yq+Gl6BlKQmJaK8mqsIpS1NuZfxbs2KhcQGK3VrCxr+pvDIWj37hW5U+abe3T1PtUka3lodjybXRIG0/1ZkI+Di2YtKv/33ZuN+Zz1U+iNRn3trY/mXAEMe+DMZAQbCQHczSqPOWLoPs+WjpA2VTTjMlEG5mIKcnJTZ3gpEl+mpicdminqJ3Z0C9fe+Y/Tf3soyclNLggy+32vwthZUNQD3LRPGyiYvkZnWM6kuWC5cIulSJMgbLDdGl9bIOWbKLErxVgUMvFDIK9S4Q8rzYec2KLHoK2TmErJ6Nf1jTkOFJ55DIVF9HnRDg4UivvkxkQooqx+eSopoSEiTdvkdoq5itvNWK4y2TGzfU8u9xvJNgNCVUv5lY6qvimFYtYAZHB8Z2+i+EgW5hNF2AjI6kXe2RsHtOkEbleso765TVjkwiWYSV1/D9N9Pjv6qB1IxR+AvwyJJmaTn00bB0gQrVdpyCaUxbfmQ8dM4X3WcNNeI4PH1jHedTzeS78VQbTUCZiHyMz7ZHnQW8jInIqbBByq8MRTLpCojQ+1K7Kk3N2wlk0gZIx9XOsd2eK1+sCP0RUGhHHAVm0NcwaWTKszZHfvnOOOS0swtPA7XNGb+prHMFqs2jS+z+wGy/gFOtmtPA848axzVLd8ZI0z4iBeACJpxm4wJi0BVVMSZ1bKEYDzV7p9Kc/wY0PXPaGKQy0MI/8uHBOjC/ymQoBMsjcOMGtK1fVKenpJCj+3IFBvkZZX1naz2IyGNe6DyeRgT3HC5Fj8RGMDR3ihGK/oRDnxn3DQWmyjD2A/ 493xzai0 +XIkfkHjGusArMZqph7QwITMg26Hj11Na2y7g8X9wzi7p/21lOx5O78sZr/KpDq6V0pMxuUeNm9HSiEmtdDXcsMEAMljlgBnW+tDDcQ3LrUftYzEdE3KB2n7+vf/LcQCdaz0mj4ta4tOs4MTCyJQ3SnK/ORX1zt4wwZ8nGa57Q6hlfm0Mshp2ExLCIBfdrARWNbFY/KvTJQSUtNZZ/OcyB8WaUtpNTpEnbXKTslQU2zHbUtIb1avmxRbDaC1moNaQWzy/YwCEeMaoN3lTNl6pwbgql3IRLLNS8uqCHLAU19UCf1SU7IdNmJAE9mZCnCxtLxKih4FvUHmu76yWaAOWhey4sn3ae6zguSFJLMTQ4grYERkeJdo1bh1npXci6vUkIV/1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 02, 2024 at 01:03:52PM -0700, Allen wrote: > +int proc_core_file_note_size_max(struct ctl_table *table, int write, > void __user *buffer, size_t *lenp, loff_t *ppos) { > + int error = proc_douintvec(table, write, buffer, lenp, ppos); > + if (write && (core_file_note_size_max < MAX_FILE_NOTE_SIZE || > core_file_note_size_max > MAX_ALLOWED_NOTE_SIZE)) > + core_file_note_size_max = MAX_FILE_NOTE_SIZE; // Revert to > default if out of bounds > + return error; > +} There's already a proc helper which let's you set min / max. Luis