From: Matthew Wilcox <willy@infradead.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: John Hubbard <jhubbard@nvidia.com>,
David Hildenbrand <david@redhat.com>,
Alistair Popple <apopple@nvidia.com>,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-rdma@vger.kernel.org, linux-mm@kvack.org,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Leon Romanovsky <leon@kernel.org>,
Artemy Kovalyov <artemyko@nvidia.com>,
Michael Guralnik <michaelgur@nvidia.com>,
Pak Markthub <pmarkthub@nvidia.com>
Subject: Re: [RFC] RDMA/umem: pin_user_pages*() can temporarily fail due to migration glitches
Date: Thu, 2 May 2024 19:44:58 +0100 [thread overview]
Message-ID: <ZjPfKqMJYU71iCV9@casper.infradead.org> (raw)
In-Reply-To: <20240502183408.GC3341011@nvidia.com>
On Thu, May 02, 2024 at 03:34:08PM -0300, Jason Gunthorpe wrote:
> IMHO pin_user_pages() should sleep and spin in an interruptable sleep
killable, not interruptible. Otherwise SIGWINCH and SIGALRM can
result an early return.
> until we get all the migrations done. Not sure how hard it would be to
> add some kind of proper waiting event sleep?
ummmmm. We have a "has waiters" bit in the folio. So on every call to
folio_put(), we could check that bit and wake up any waiters. I need to
think about that; right now, we only use it for unlock and end_writeback.
Making folio_put() heavier is, well, quite a lot of call-sites.
next prev parent reply other threads:[~2024-05-02 18:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 0:31 John Hubbard
2024-05-01 5:10 ` Christoph Hellwig
2024-05-01 12:10 ` Jason Gunthorpe
2024-05-01 17:32 ` John Hubbard
2024-05-02 1:05 ` Alistair Popple
2024-05-02 6:49 ` John Hubbard
2024-05-02 6:56 ` David Hildenbrand
2024-05-02 18:10 ` John Hubbard
2024-05-02 18:34 ` Jason Gunthorpe
2024-05-02 18:44 ` Matthew Wilcox [this message]
2024-05-10 7:54 ` David Hildenbrand
2024-05-11 0:32 ` Kasireddy, Vivek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjPfKqMJYU71iCV9@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=artemyko@nvidia.com \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michaelgur@nvidia.com \
--cc=mike.marciniszyn@intel.com \
--cc=pmarkthub@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox