From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D322FC4345F for ; Thu, 2 May 2024 13:38:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 569366B009B; Thu, 2 May 2024 09:38:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F0006B009D; Thu, 2 May 2024 09:38:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36A1D6B009E; Thu, 2 May 2024 09:38:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 15FF86B009B for ; Thu, 2 May 2024 09:38:41 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 92F2280A2D for ; Thu, 2 May 2024 13:38:40 +0000 (UTC) X-FDA: 82073560800.15.F5B1231 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf07.hostedemail.com (Postfix) with ESMTP id AAAAA40004 for ; Thu, 2 May 2024 13:38:38 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NyZpiwm6; spf=pass (imf07.hostedemail.com: domain of vdonnefort@google.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=vdonnefort@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714657118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y19TweyZ1KjMmIo4xW3n0XYd8Twm3R3dqBl/XKJ2/GA=; b=sVchqVZEgmamYEVGO/z77+5grs7uQEznM2JNB/H+XWGmDlzAWfnsvxLJ2P1ofNnvlgugqF SLE4k0+kqmQshcTSAp9W6HyzJC/xCTer5k1nXre3L5gY0+ngEOmbhsC4trMV3YDDbAeedj SU74jjaNpwkuRLGbG/rN8pGT5Y4a2ZU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714657118; a=rsa-sha256; cv=none; b=H3bBh5OLziUJLtXHP/oG2vYrDZKbwaMd3u1zo1zXmek/4zT437P2CgDmGdLt/XTx+Y2Ub5 8ZHxHSz7XaxBn7uusUQT17Z87hNKbPY3+5GpAj2a6/VBUxYqGtpAQ5bQXd39z44eq56gQo yuEvwTj6tguBXI7liUROdZPOP4DUe+Y= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NyZpiwm6; spf=pass (imf07.hostedemail.com: domain of vdonnefort@google.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=vdonnefort@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-51f2ebbd8a7so729337e87.2 for ; Thu, 02 May 2024 06:38:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714657117; x=1715261917; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=y19TweyZ1KjMmIo4xW3n0XYd8Twm3R3dqBl/XKJ2/GA=; b=NyZpiwm6VlDOgki+b7K0JfVwqqqWPWA3aLVUDJTn2Zy8jLBjOYVYPUpKizfrk3+aaK Az4ReQAYriI9CSpTKbw67L9mnQl7+0kdPQuE6GCGqHAqCzvGf8MRZFs+U3ccY5AChaLt cJL+a8dBCa3952BB39S/MGQ2XJJ/Zvb2RX4IuKgSfe1eU242sNxf00HDynsPmXYQyztQ Xs8yBvFXcTPiix+OfT90r5txzv8dndGn9ed/RNqJ/AnHGCmWur2KOrwS31Slji2pVCOz orcJ5GYTsm+OdJVylKGjCkqPESOhS/BzYWmlJQc8GRxm03ZVFklQdL77J/NZmFE0mqfq clDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714657117; x=1715261917; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y19TweyZ1KjMmIo4xW3n0XYd8Twm3R3dqBl/XKJ2/GA=; b=vDNLjekh3HEKvpDvo/yDVnQsG4sKIpmZfYgbamwtk1IwelYW/g+zKH7Gl7FJTBb6ST GIA+PJYg4WvgRxw/ifgjjtRRlSNH92yOILG+llBLkfviHL9AuFZjtiPKO07Puip4y/Yw 5vyFaYVWO2M+aFeyy0a0/j2t8huBUmYUQKl+RlVME9Pqoeh3WHetYxCLU3afLVJs8SS6 OXNwOmCkspok5GBtEe0gBnS1fmKyxzYBuxa/81wFLW4+Xp2VrgwiLcK8P791ED35scpQ ZxYccgcITFa5n/vgA81cEDduPHqNwg6bPGUcLxRaxnARjt+XDoNIxMXqce04GE8O2Z2h LONw== X-Forwarded-Encrypted: i=1; AJvYcCVOHV1xVruXZVtaGzb8HHOiMhqacsa/3jNdICMMicurhQCUk/DG8U+3q054lv3LPkRTgjhtcAbTHxnjSXRgqqL/5Sc= X-Gm-Message-State: AOJu0Yw/UEHYrJ27N7I716L0mS28sky6an5mVNeUw+PZTznaYiPMZiy4 iIpay7EUvdfQu/zjaO2qbNmHewUyyp/LY/YgaKJtXJLBYyEbgAmnV6lA65exKA== X-Google-Smtp-Source: AGHT+IG2RlbVsy/QxzmOQcZwMGxzJIvMVzR+A/xkThaRhY+BkG8J7xN8nSCssUzWHbF/M78GCwlHmQ== X-Received: by 2002:a05:6512:3c83:b0:51c:17d5:b56e with SMTP id h3-20020a0565123c8300b0051c17d5b56emr3948387lfv.11.1714657116382; Thu, 02 May 2024 06:38:36 -0700 (PDT) Received: from google.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id m3-20020adffa03000000b0034db974d7a1sm1287085wrr.81.2024.05.02.06.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 06:38:36 -0700 (PDT) Date: Thu, 2 May 2024 14:38:32 +0100 From: Vincent Donnefort To: David Hildenbrand Cc: rostedt@goodmis.org, mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, kernel-team@android.com, rdunlap@infradead.org, rppt@kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v22 2/5] ring-buffer: Introducing ring-buffer mapping functions Message-ID: References: <20240430111354.637356-1-vdonnefort@google.com> <20240430111354.637356-3-vdonnefort@google.com> <78e20e98-bdfc-4d7b-a59c-988b81fcc58b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78e20e98-bdfc-4d7b-a59c-988b81fcc58b@redhat.com> X-Rspam-User: X-Stat-Signature: npwacrz8cxuztkyaufs15rhx6hjratyg X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: AAAAA40004 X-HE-Tag: 1714657118-258529 X-HE-Meta: U2FsdGVkX19TxrAh8j6mN6qQKWhj8ncgWpr9Af7TkWTk0gfQMeQ74ph+Zqo1EAjmzmGvuz5ZksWXIFfcQlSW6HiFE/g8eHaRdW+jaTT3jL8+PDwukhuoCUABagaUIEZyUAUgt2oetoEtlgDxLBdyCR5Ze6KPt3B3387E2qVc4dxMJTTbPZap1r7OWTqd8TWRxoXCkARTROpg2AC5XdxjwcsRQ8HvuimU5qvg+IVPhPKh4BHh6ZpEyrahUsMRkbhYPwR1jIrzaVmsM6b6yxAM2u3vGMLi5DJE4vKfoHjBqjUhxPtbaJ+ZmQONmfChBTlUkfu77ZwreON2R0Lb9VhxhIm4AbtXIYNXnFDVTf3wuO2oiZ2lf3uQ6XuleGrFzANc9kPaS1f0LWCMl2N/aLJ0bnKfWjrpvbIcpEKWzgmP5yY/bhlXxhCwde8TyGgfQl5iq0BKZJq4sHwEuDDHZrieZ3y3/adQZIf3WVOB4EaI/fWK3k0ghXWisalLYfkj/H0B0BVAV44/q1YSTHrlgr0qLuCW7p+Ik3ctzz2WsEknzI4xz1a9p/Sb3ybeYKl+xXGpUmMGU8I+1kNuhVZYpLVylN7o8cyOiVl+YTffxs58IxHubr4Nja3xoyCNjNamCEa4Fig5HzMioBZPacqfFUZ1TJsrfVRfw2CF21PTZoOKwsqsQiuiQYVgXs5tT+nPUsf+B+NQvdpbbYF0A3FnyPhyPlbAgDsayMImj6mubPqySCeq3XFOCQdl+MCntSM5MjIBDIcHFkPS3FTL+yhx4xiLl9Qg6O5afdgdl5CFitEi2nypSAry4fleWONA+EqbFeW4/bqFHe115OvqSCO8QN+w119j9VZoj+E1pJDYzAvxLt8nJ5MpsNhpYin2zlbm+nvvLGewpyF9Df4JjQ/MEW3lBBfWF5yvXyJtzbarkpgcDMAq7IJC7XYCTe7abJrAtz/kbCSVPL+6mVXTsuDGNjv X4JRX2mw tvdE/3aTreuO+gQQiZySEnzlFNF+8pBSGoaOWh+dKcPm0Nu4kFsNRspeAZUgeDDm8vczqK+xFVj1VEC0NheihZN9vXrMlrgKuPSNUcPIyl6IOMzczdma5BlmOPnU8RZhyAHLYPRE0XmWbQv9b3GpiU8UpetkQ+TZr50SkUIlPcEYL7T5eXzFDJMkqLNyBRU6ZD5hd+6o3a+PKlv+rfhhciKswkOpn21x4mzy1423hU3kUa3WTKSzxPc8ra2+CKju8pgGDsAfXJPMzydpP6z5Dk7/286fL3XcgPeUyXAlqqsms/ARH6Ott8Ug27ld+fGOXqTBVFmycCgciZqXQvG56dsWYiSbW0iQVMqL4RWaMyRkURjFo9iZof0ol1yxx4QZqN9mpjiIrgrVTU06GXxZLUXGCYDlvD1FK4Faca0JJm4sTMUuwyZWDv2twQJHolp5Io4nVMToAju2xK8mCP3MmYiBiMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 02, 2024 at 03:30:32PM +0200, David Hildenbrand wrote: > On 30.04.24 13:13, Vincent Donnefort wrote: > > In preparation for allowing the user-space to map a ring-buffer, add > > a set of mapping functions: > > > > ring_buffer_{map,unmap}() > > > > And controls on the ring-buffer: > > > > ring_buffer_map_get_reader() /* swap reader and head */ > > > > Mapping the ring-buffer also involves: > > > > A unique ID for each subbuf of the ring-buffer, currently they are > > only identified through their in-kernel VA. > > > > A meta-page, where are stored ring-buffer statistics and a > > description for the current reader > > > > The linear mapping exposes the meta-page, and each subbuf of the > > ring-buffer, ordered following their unique ID, assigned during the > > first mapping. > > > > Once mapped, no subbuf can get in or out of the ring-buffer: the buffer > > size will remain unmodified and the splice enabling functions will in > > reality simply memcpy the data instead of swapping subbufs. > > > > CC: > > Signed-off-by: Vincent Donnefort > > > > diff --git a/include/linux/ring_buffer.h b/include/linux/ring_buffer.h > > index dc5ae4e96aee..96d2140b471e 100644 > > --- a/include/linux/ring_buffer.h > > +++ b/include/linux/ring_buffer.h > > [...] > > > +/* > > + * +--------------+ pgoff == 0 > > + * | meta page | > > + * +--------------+ pgoff == 1 > > + * | subbuffer 0 | > > + * | | > > + * +--------------+ pgoff == (1 + (1 << subbuf_order)) > > + * | subbuffer 1 | > > + * | | > > + * ... > > + */ > > +#ifdef CONFIG_MMU > > +static int __rb_map_vma(struct ring_buffer_per_cpu *cpu_buffer, > > + struct vm_area_struct *vma) > > +{ > > + unsigned long nr_subbufs, nr_pages, vma_pages, pgoff = vma->vm_pgoff; > > + unsigned int subbuf_pages, subbuf_order; > > + struct page **pages; > > + int p = 0, s = 0; > > + int err; > > + > > + /* Refuse MP_PRIVATE or writable mappings */ > > + if (vma->vm_flags & VM_WRITE || vma->vm_flags & VM_EXEC || > > + !(vma->vm_flags & VM_MAYSHARE)) > > + return -EPERM; > > + > > + /* > > + * Make sure the mapping cannot become writable later. Also tell the VM > > + * to not touch these pages (VM_DONTCOPY | VM_DONTEXPAND). Finally, > > + * prevent migration, GUP and dump (VM_IO). > > + */ > > + vm_flags_mod(vma, VM_DONTCOPY | VM_DONTEXPAND | VM_IO, VM_MAYWRITE); > > + > > + lockdep_assert_held(&cpu_buffer->mapping_lock); > > + > > + subbuf_order = cpu_buffer->buffer->subbuf_order; > > + subbuf_pages = 1 << subbuf_order; > > + > > + nr_subbufs = cpu_buffer->nr_pages + 1; /* + reader-subbuf */ > > + nr_pages = ((nr_subbufs) << subbuf_order) - pgoff + 1; /* + meta-page */ > > + > > + vma_pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > + if (!vma_pages || vma_pages > nr_pages) > > + return -EINVAL; > > + > > + nr_pages = vma_pages; > > + > > + pages = kcalloc(nr_pages, sizeof(*pages), GFP_KERNEL); > > + if (!pages) > > + return -ENOMEM; > > + > > + if (!pgoff) { > > + pages[p++] = virt_to_page(cpu_buffer->meta_page); > > + > > + /* > > + * TODO: Align sub-buffers on their size, once > > + * vm_insert_pages() supports the zero-page. > > + */ > > + } else { > > + /* Skip the meta-page */ > > + pgoff--; > > + > > + if (pgoff % subbuf_pages) { > > + err = -EINVAL; > > + goto out; > > + } > > + > > + s += pgoff / subbuf_pages; > > + } > > + > > + while (s < nr_subbufs && p < nr_pages) { > > + struct page *page = virt_to_page(cpu_buffer->subbuf_ids[s]); > > + int off = 0; > > + > > + for (; off < (1 << (subbuf_order)); off++, page++) { > > + if (p >= nr_pages) > > + break; > > + > > + pages[p++] = page; > > + } > > + s++; > > + } > > + > > + err = vm_insert_pages(vma, vma->vm_start, pages, &nr_pages); > > Nit: I did not immediately understand if we could end here with p < nr_pages > (IOW, pages[] not completely filled). > > One source of confusion is the "s < nr_subbufs" check in the while loop: why > is "p < nr_pages" insufficient? Hum, indeed, the "s < nr_subbufs" check is superfluous, nr_pages, is already capped by the number of subbufs, there's no way we can overflow subbuf_ids[]. > > > For the MM bits: > > Acked-by: David Hildenbrand Thanks a lot for having a look at the series, very much appreciated! > > > > -- > Cheers, > > David / dhildenb >