From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D73BC4345F for ; Thu, 2 May 2024 13:18:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C0CC6B0092; Thu, 2 May 2024 09:18:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 070D76B0093; Thu, 2 May 2024 09:18:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E53886B0095; Thu, 2 May 2024 09:18:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C61146B0092 for ; Thu, 2 May 2024 09:18:26 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5BA5F1C15CC for ; Thu, 2 May 2024 13:18:26 +0000 (UTC) X-FDA: 82073509812.13.66752EB Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf12.hostedemail.com (Postfix) with ESMTP id F12D140022 for ; Thu, 2 May 2024 13:18:23 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=DHXEplGZ; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf12.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714655904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XN99BF71thSSfY5SqQDfuMkL/hrnNQt2dqkH+sfTj0o=; b=b9VGF4cywqTPivowFCPPk5pPImCnVWLYQIMs6PbIt6zop+K9VCEOyRr8lPCi0Nm3V8oB2r RBax7ZoyewpFhTr46Ctj8FUejXEVN9Hx4IKxy8Le579dJIbBRpUfunn0rwetPO1XEMkyBl 9SQ84/JvduitfjHDh93jdnqbwBmR1uo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=DHXEplGZ; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf12.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714655904; a=rsa-sha256; cv=none; b=MDhLqYCkhSrB7BM59Mp/eux1wO6EYaFHf8Nw2bVBNDzIZRZPDt6GNPZtCYl6O/jy4YE+8O 9sJ28NyZcOX6YRmXd1kMycDejhxNMK/m99FHeWI0BROzNEHJE+81J2Ye1lmL3gJSjphLQa pq65QzzxEFV7gieKHwtkAhOnQweQ4oY= Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 442Cv9LJ029749; Thu, 2 May 2024 13:18:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=XN99BF71thSSfY5SqQDfuMkL/hrnNQt2dqkH+sfTj0o=; b=DHXEplGZp8ioVYGbxto3cHIrNbtkQtbgZ69TPO1EY+gOzkpUe0PM1anwWjrkg4j0R11a +C65LwsOt8WD+1Sc4KXksTzPM8jWm44QxSgnmekpykUJ/bfXaGbJow810I6ROEdHRYZS FZVWzmsOlSk25ZriqurIieEFkI9YTgGmrAo6JGfVxzLsG1F/Li2q4Dr0pBHfo0iE0eA9 AQAPWat0P5PZniLPh9rFW5DfbUaqNNJzbWC2XdP+xk0SvPK2/bqAE3E2pWMVLoyeY255 GBTVR4RbxgUU6gTGeCpolYkg1QX8lVQAUnJxBtENnO0og3j56uEz4zfBxfAyN9VM6aRf Mw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xvb9mr30n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 May 2024 13:18:15 +0000 Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 442DDQ0U028210; Thu, 2 May 2024 13:18:14 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xvb9mr30k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 May 2024 13:18:14 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 442AnYYc001450; Thu, 2 May 2024 13:18:13 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xsbpu8bj0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 May 2024 13:18:13 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 442DIA9w51446098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 May 2024 13:18:12 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DF0F220040; Thu, 2 May 2024 13:18:09 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1E062004E; Thu, 2 May 2024 13:18:09 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 2 May 2024 13:18:09 +0000 (GMT) Date: Thu, 2 May 2024 15:18:08 +0200 From: Alexander Gordeev To: Zi Yan Cc: Andrew Morton , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Yang Shi , Ryan Roberts , Barry Song <21cnbao@gmail.com>, David Hildenbrand , Lance Yang , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v5] mm/rmap: do not add fully unmapped large folio to deferred split list Message-ID: References: <20240426190253.541419-1-zi.yan@sent.com> <5FAD7FB6-4AC0-4427-B56E-4942A95DB68C@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5FAD7FB6-4AC0-4427-B56E-4942A95DB68C@nvidia.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: BhJXFo5jULS1X6MGd4EQvaIkCzsPI8zC X-Proofpoint-GUID: 1BuLqmGV0xhRbwjDw_Q2SRtfZ5-i6DOQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-02_02,2024-05-02_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 bulkscore=0 adultscore=0 mlxscore=0 phishscore=0 spamscore=0 clxscore=1015 malwarescore=0 mlxlogscore=999 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2405020085 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F12D140022 X-Stat-Signature: h61tiriuw6t443yg3hjek9icwk566htu X-Rspam-User: X-HE-Tag: 1714655903-444029 X-HE-Meta: U2FsdGVkX1/JyD32Z8sgH+oz7jM4v8n0SyiCFXIdK68Ny6KD6b0DQEhQ4aHcEK44KPRUKAlJDZOPVEPu+B+2OgdYJ0iLm/HQaVBdl//cs2S3drAPdbLsMMaGswnQDm5SlIP3ctx/7R7qBe8AqVx396nzzNooH40QXrIrb7tvBMW6qYOLoi5TXS3mPI64HVL6MiWWas2NvrRhtmGbWIQdhC84ZQEZwjz8ZWW2hFmA/9ziSpZ3fFMhFVesQu0jl3VdQqxzdda2GHc7pBUnZj9hLuFJl/uS0mfWD/SJ9qA5Qg2pwkejTKxBgb6343q+vj1Qe6K2SeE9swofXw0mKKvkRiwxmcmsIgCAt3ncyEhucaLALOVLEXc+0fqyzFCRrEjMn9/wQAcBxwWO5R4BhiihWKacquz5PD5ML5A+5/wCY3KEmhP34Sp3DYFV6aRk8SoiQb8RgL14hqPntLJzufE+8f/iPIkejKWDLPU1HlPwxxM+z/eqDq1HQL9YXPqDjMjGiT4tPSSDkPaQq4O8x+rAa433Y5271ufQpn8e0euQTK8c1TvtGonyI0nyIjAxr0mUe/r/ONBlC7aVIGFf14rpelEliPgpWpyOk84hCuV3THn7k3gF6ti7AjyXkJJPl/bhII8HgZaYDOxKBhonnzawgtJDZjX6CVYiM7wdsqdZ+QKg1Z1jhvtA5mDWMQV1gaqHcNFXBFtQ71aF5cuW71WdycQOzGph3/AEFYWafN3YYv0tE7lk24pOVw7J9RzQ3/4iXyUHmEkibz83Hat23jqcOMgjJP32ZNshLasqcFAi4aUZGKn722F6nfl/vuBM6oiSXErLxIFa3EldGEzEHdT1OIhbRWGXBq5BLr/NRTNgIjqQvK1NPM6WnRc13QKzSvKnujJMgYPHG21KvhINmO8wz0djj566JX9WtWGg8S43STKurs+m08xWGoGnlIRLwQ0T0FDCBb5qG7NYRd673n3 qIAJiiOx DWb98wP792veZHLQCW5xddfXzVhmRkO8SiVJ3kei18lG3yD0OSkwJQ0dgxd0kauUNIn8CaiXMkpN5nOmrkMHEP1jvDDCGcmh9xjUFx7xnaAhcNoIns4fQSFLqaexNVSK8MYJo3qDj+bEZnJdrIUzT3dWn3mvk+ok3cx9j9DGjBYBqWeaiwdcznhsyiC8pn6MLvcZQeHXCFMHFelUQzcDKrm3rRf9Q3YZ5mt/4Psvdj0DAwYaLQ0egXIpnH3omE4/hK0SC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 01, 2024 at 09:38:24AM -0400, Zi Yan wrote: Hi Zi, > @@ -1557,9 +1557,8 @@ static __always_inline void __folio_remove_rmap(struct folio *folio, > * page of the folio is unmapped and at least one page > * is still mapped. > */ > - if (folio_test_anon(folio) && > - list_empty(&folio->_deferred_list) && > - partially_mapped) > + if (folio_test_anon(folio) && partially_mapped && > + list_empty(&folio->_deferred_list)) > deferred_split_folio(folio); > } That helps. > Best Regards, > Yan, Zi Thanks!