From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56D90C4345F for ; Wed, 1 May 2024 16:41:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB69A6B008A; Wed, 1 May 2024 12:41:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C667C6B008C; Wed, 1 May 2024 12:41:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2DEF6B0092; Wed, 1 May 2024 12:41:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9397B6B008A for ; Wed, 1 May 2024 12:41:00 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 995B914080C for ; Wed, 1 May 2024 16:40:58 +0000 (UTC) X-FDA: 82070391396.09.13D640D Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf10.hostedemail.com (Postfix) with ESMTP id BF0B8C0007 for ; Wed, 1 May 2024 16:40:55 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gvFG1eMG; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf10.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714581655; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vUMDq886brWG/iK3lObFVRTNP/KpgYi0SpmrG9l3pfU=; b=06AVjq4yhRY4tjBdzQYhpkKGC1wX+fuxtt9LuaW1fZZFOmUo6a+XxU9hu+JGjGQ2QwMx3x /qmqRtEptiMDpzRVAUeIcWrn/8tSke1kUaYzc4m92UZpB98xxTXpGQTFl56QTi9x7oqjg7 ofeWaxTYn4n3/8/6m/rHxe7s+VPTxpw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714581655; a=rsa-sha256; cv=none; b=mXD7ueiLwOlTHmW2UvWng4UL0PEc5cAt9A25SWGo0pTYJZ7lGAD0mnL9pCwzucWVvWev1h UFyFwqchiqg+sOphsrGhxJkPxZ+TxiRcdwOptTNkJLKUjRDxa9OAiQmgcuIsQ+VEMQnGpe RdnfVfoLOH5o7moQ49WuK9nahlPmayU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gvFG1eMG; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf10.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=htejun@gmail.com Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-5e42b4bbfa4so4292566a12.1 for ; Wed, 01 May 2024 09:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714581654; x=1715186454; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=vUMDq886brWG/iK3lObFVRTNP/KpgYi0SpmrG9l3pfU=; b=gvFG1eMGGNhMnMvEhl3K70Hhm1wacQjyCgHhzsYxuKqiwu0LNjw0AGm41OOKem+aBW y055yvFqobLbnP/nga9h1MDmKJ1JB8fOcltZHK3YIlmNr0QuSxP+Wwh2yJilA2M6mHiN BO2QpdJ5MVLBO6E9aF5dd3whKtJE+FLN3d4hTvUK15XJooTx5FpVlY1apH49Ov8T2dAN CYTkiqMosVAr6qhJtaB0v5cIkQgcubejItn2XiVIBaCCtozP7CdsZ/Xss01iEZWnBRTq 2bd0wVEKbsCo3CzhlN2MUd/TD5kF5xGJd00knlRjSoXWQnJDEgNaCgnOzS+xsyEpJqW8 Qlow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714581654; x=1715186454; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vUMDq886brWG/iK3lObFVRTNP/KpgYi0SpmrG9l3pfU=; b=hHlgNQaastaLSYrm18l5ed383GkwrQuc0l+StUoR7IMTHCwszhCH+Qotg1KkhXWE7V OQcTW0H2P+yKS+4cURXPq+PT+eoUBN2IAMavK6KAnDgWJ7YBGDzSgLfZkgS6ICrkTG0s BniG9hLbHozz8cqiQwCPb6n607d/b50Ks7b/S6hmJEN5UWJKV5DGeLXhunfk6zQNT0Xl I0FERTITue1zVhWaUhFgab0RepXIh38LcNcFKkSXhfO9CXjr2ubBNC/TVneUwQhNgmKA ecuWwsptGO4FygZ+VfhUQZO8ywlGonnBil3mV4SYbJFTyq8FLM40qqGkyG+NFWW67sAb cfMA== X-Forwarded-Encrypted: i=1; AJvYcCUkag9VKgUHXqARfzRoLWe0lYOzpC5vBbcQWKNw5BuoFxgqReMjPItgCenqJJGhMf2FRpUxdILgaMTeuQnMyXaiP5Y= X-Gm-Message-State: AOJu0YyPVIJVSsytVB9XYs2t0S7SN7wmtlGQ1CGp83bCtzmuZNFluRPE rN3B0kvoNxJGiiRk4/NxowY/vE6KA55nZeicDWNmWvXp0IFmz9OW8MlAZl4i X-Google-Smtp-Source: AGHT+IGORi83PoZPdA3rN9Nzl0hVavuekUtxyDHDG+F20qP/0jKwaPzyRimTL9apcEdpyCq6kmUnFA== X-Received: by 2002:a17:90a:1fca:b0:2b0:7f15:9155 with SMTP id z10-20020a17090a1fca00b002b07f159155mr3004322pjz.31.1714581654409; Wed, 01 May 2024 09:40:54 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id sx11-20020a17090b2ccb00b002b1750f228csm1546999pjb.7.2024.05.01.09.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:40:54 -0700 (PDT) Date: Wed, 1 May 2024 06:40:52 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/10] writeback: factor out wb_bg_dirty_limits to remove repeated code Message-ID: References: <20240429034738.138609-1-shikemeng@huaweicloud.com> <20240429034738.138609-2-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429034738.138609-2-shikemeng@huaweicloud.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: BF0B8C0007 X-Stat-Signature: jyfrw1mrys15hcenddwtm3pu5h6mbq3b X-Rspam-User: X-HE-Tag: 1714581655-336741 X-HE-Meta: U2FsdGVkX19vaNOPDee/kyqD32XcTiVrlTB1wGU/BcIrAUfI2teZcB7INJpDke7zVYj7m/wdC5325q7lmngaluhHOFJVIOdeTI7t4/+6L46ygqaxSrc9TFDUSVeysKnX8Js2xESBNUB0/hsaSaG12cD9ZzXoimbKaMvbSeYCnRTEQtYrbzuH4y1G7N4T/RMi+lhKHU7Qq04HXNDP3oJrRX5QLf8wPf0pHg9qpHIPbqPo6S1YD9C1kk3L7PFcktU3GpIu2o87ZWLshqF7ZDlf6GQTw5VNMhPd40kRy5tvmVgBOv53kK1ludnQdMbX+O6K2JjSlFG2bie6ZMyu9tFhovOugph6xO3Wh4pkdBlFvnkM+hRDKfCqEQvaAIN4WGgUU9YhlRthIqbMv2atLwraZvqJDP4FFYxzu8bTOWTPP0PJBWLwIIDqpOKM4cnFaORZqa18FCUGKX+Z4xUIMZIpu9uRtXKMlcGDoMZNCM26mLzE2cii1J1CnojxGdqxlo3PeDdSI2xCcCd6qDLQdamQpTCrnFLr123pmEe6ASNdKSof0KTbLN6Trs4UemyyOaJUDwf58sg+W1WRjmCq4y/N+uqECnp1BGGDre34NSliBa3jzTNpiFgBqbd8JopXbJcYXxIKbFFnWqFymwGCS0zWwiFRPJu7J7GH67/jWDQH/PPCX47BC1B4L/6XacRmOId+BOheVKcBvO05UnPbxBD7LU8bUTTnVfKsvXKfxjenAJayhrRX8WC6wL5w7ybHxDDhT/G6BGN79xWVLBX88SbixJGc6LWyofkfad3s95zWyfZYJdCxZNJU4mP7+ZVsyQKoxNnSuSzCheojEFasBUX2RYZWr446lZsQTEcQsZ0fuVVoDjiqDM1pZOP+Q+4YSrgl5GYI8w+dfcE+MS3yKqVi7ZiAKqLKtTw4RkOXFshsdEGilz616zPGrX+wOMgnEXLBqbLwezxYqoT8znGYitg XjMJeeUm REo8D9h9edEDUBZtVJldDE3b/5tkHJgrpOWbJ3SNJyX6N1qYcOE6YYU/kE+Vc1hEps7753Js9IHjdDw99dFPfpNMzdiUB21Tlim+iQ7LHhjL6QH0QL4OyB+3J19WUl27V+LIr/19aKexHp9BOoIBaNRKVdyD0qUtwb40stzweZvMdnWCFYW7iXkwo+yLKMN7ZCb5T+Awi1oBfWxmANr+QvbkEP6mePpRipqPEF5SNNY430FwPIp7IvGgfYJ8/4JdytuOae4ESWpH7aoYYUh6nHTkrsv5GCvLtUTLYmazMlOOQ+8esvGBIWZX6EI8nrC2r5OOAMPnLV78F3pOolO5wOkTDwmaVzfHj3C2pQGT7LfMICFo+6LKMtZ8A0pZPdlkoXsCxtQcZfWGSiEHT+MoLTUXaQYwRFNyV+Hgcbf/l29dn79uZKpH32Fhzk5S3MMb9APltPgYauhbaVzMDUzEhJyuMvuexHoguEohlT0Gn0512RkCHf6/XFcETvTmX+kglmXh+rc2MSurnPaWY1SaNmcPY8kzbgvY8nwKUJ37beOf3H+DWAXyL8oNTOQkpqfUx27VapOSbi/HD1ZhwOoWBF/RGFBWwfEAHc7PlPbU+lu8XR7fNaJ4BsdBhPSa26iNPprBVVww8DFy2oUU10qspZizxwg8qsCa2NPil X-Bogosity: Ham, tests=bogofilter, spamicity=0.002008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 11:47:29AM +0800, Kemeng Shi wrote: > Similar to wb_dirty_limits which calculates dirty and thresh of wb, > wb_bg_dirty_limits calculates background dirty and background thresh of > wb. With wb_bg_dirty_limits, we could remove repeated code in > wb_over_bg_thresh. > > Signed-off-by: Kemeng Shi Acked-by: Tejun Heo Thanks. -- tejun