From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAF35C4345F for ; Wed, 1 May 2024 16:21:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 466396B0083; Wed, 1 May 2024 12:21:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 416F16B0085; Wed, 1 May 2024 12:21:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3068D6B008A; Wed, 1 May 2024 12:21:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 11C176B0083 for ; Wed, 1 May 2024 12:21:01 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 01923A0BE0 for ; Wed, 1 May 2024 16:20:58 +0000 (UTC) X-FDA: 82070341038.25.CC87054 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 05EAAA0017 for ; Wed, 1 May 2024 16:20:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bPDmPEsS; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf15.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714580456; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tjgf77IIk2561iTG74wh4geQMCuRRrs/zUp24uYddO8=; b=vJnFkIwzpZ6dwuvx2WQ9c+oeovCXLHLSPYtOwft7nOwSfSbKnX8bIxKHUeMsjIhxeZLo9w 8UNJh1TZv+L3GAK36guK9mcA/A2UZM9HJx8RWwDPI6mxNyN0Iejdz1nm5rI606vAVI8ksv QohbJSDSFa8qMWvVGmiMS9Io/+DpHsw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714580456; a=rsa-sha256; cv=none; b=G0anTHHJTRba0ScFTkNW9FdnyCCEm3BEKkIcNCZveadMgtJkWOaar25xzxCxjAZ2Uw1Tw6 DpRcpTH0pf1RKsqq1OfoiP6ug/psxQ12PGNT+cBt2tdezOojdVPqzTJUZXM5nBGEOCANTh C6Oft3hGoX8two5J3AtvRy4rEOb6sCU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bPDmPEsS; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf15.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Tjgf77IIk2561iTG74wh4geQMCuRRrs/zUp24uYddO8=; b=bPDmPEsS432TVrjl7ahve/ztF3 fft9mZ5PVWO3PHU/a0bd23amDzVt3URh841Y07YZVGbMycRAYV+a9OF4dO3oCeMuRN2G+bOJLRp4v FUeiz3aF72WJdcg5AtFPMfllZnEt/1BpVMnhdh8vFj2eOWWXc3NoH8Dnza/lsnx+8zqfAb2m3kmNP O9rscKt1hUPSbOW3E6EbxuKT+OlTM/TEQIuPczRr5PEaXyDuF/r6ylVImBuaIwXbnWjKuGSn52Yla ywlI83lJFmCIIw+YxAifTIpVaOv5x+my6g45uRE+QFm4wwgTrIvq67i2j2jorZ6o539JsxH700EGE LuQ3vjJw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2ChR-0000000A7ac-2BM5; Wed, 01 May 2024 16:20:53 +0000 Date: Wed, 1 May 2024 09:20:52 -0700 From: Luis Chamberlain To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Zi Yan , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] XArray: Set the marks correctly when splitting an entry Message-ID: References: <20240501153120.4094530-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240501153120.4094530-1-willy@infradead.org> X-Rspamd-Queue-Id: 05EAAA0017 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: g34f4czsu3o6t9qzzdpeetc6pnpkmor9 X-HE-Tag: 1714580454-419271 X-HE-Meta: U2FsdGVkX18aatxJXjsyEmLZocAt8nTjt6fEdO6nEgAWYzki6+5XlgIiPtRVEl7mjwJoK/HoDAdUqv5qZcp6JZg2TGwQ6593CQ/5uxPXkfPWxLSWqcNNWnLk0brzwbnGAv5BzIJjLvD1U+9VjPa7R9AtY3G4SWwRcpO+fH693AOwLDBt8NRDhdSxwYgBkGGdOvyyspku1LvltgqAFBFqPhYp/iVM8CO88TFpRkK/SDvRRouj1G3dMh9app/7YXdgwWWbYBf8DU5WIFhhLYIT0D5cwVb0pTwO51r+lqbqSjTnUSd7bgsd6vcEqzl8StifNMs7grHvpMDJtlamC0OOp3iYT/MkzXK8b0JtJIw8E10f6QXodU3jjCWYPPswX/PHylZ9EcZQs8KxD2B8G9gxSbs6Q/ksaUpLvWyuhmB3DHIN8TCv+3HHeU3t9nBrAHEG9Pa8csV/zLR9tCpHcduq9K8yXylffdV9wq9C4DRF1gXMh7wvKSCP5/MAHUq4ml51hMtFmq7jc/NC8UQNvbVBfF76lpvW8+GNlCqA+RTpDwkMmY66PzBXO+M9h47a1rWHqWCnMRlVGTCjliaNyzLoC5ABU0QAQldW6aoQVRb6PTGFPRcrje7LcKhIJcfJKvZdZL6PXqMk4bYU0EKCEkREaewzb27bsCYgAONT2KCBJMJo8tdSexvm676txYscSAW0DuZwBu/QUgpM7WoGN0q+p1lVQIWUv4E/fRCtpCZNYsJUY8uAZaiwFTBvGyZ93rTz3He93ZW0t7eRzHYaoaX7dHRai3ithcBW4oeoTTCYvt5R9lhu4M7dGK81dvaiDB612nZSNeDytWOPOeNdFXmV4v6MHNMsfdePxPMrb4b9igFMxqLGcfWSvP8Kr8hWakGK50q6Q+gqLN/TWXOp62DhEeG13jdrflg0xiZUDRLFzwCunu3/f1j8hojWNrymBysfpX1BI7aUGN+xV86iODv gtcKckFI ndSL/xsudq9rIlVmAAtbrHG1P5mE7rgeUUQgxP4Ym1hVUvjalK/HC3Mdh5ua22gEOwvuow3Fx8f1Q4L+XHY89vqEWeNjybFRnu/xgCTAWnIZcAx2J41uccahLlyxz4jHFGsEvfM5gM0WCkh6uyHvGGMBgHv+sOtAVsbmy5ehF3+KG6TaufJHqbWUSLCX+PjTxr+nBMdqOFMXM44AlBD+QBPtxZLZP7AeBvR0/am6ij1EG9mmT3Sf80i85YMfzkEpHzYKjB6MoMgUUSpgk0kqmJP0St+ckUGPuIvFoouiancaQGwzPw41l167zXdtculJDuNiO3SBhQd7Xzbb+vQKQh24HEd0NseQ3QxB6RzHX7+kEBJceLDcWlc7h+REaOP7c79vZ41HmWOcRddGiwgrgSOvODSPzMQFw9amZWM0fBEVq38A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 01, 2024 at 04:31:18PM +0100, Matthew Wilcox (Oracle) wrote: > If we created a new node to replace an entry which had search marks set, > we were setting the search mark on every entry in that node. That works > fine when we're splitting to order 0, but when splitting to a larger > order, we must not set the search marks on the sibling entries. > > Reported-by: Luis Chamberlain > Link: https://lore.kernel.org/r/ZjFGCOYk3FK_zVy3@bombadil.infradead.org > Fixes: c010d47f107f ("mm: thp: split huge page to any lower order pages") > Signed-off-by: Matthew Wilcox (Oracle) Thanks! Tested-by: Luis Chamberlain Luis