From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98DB6C4345F for ; Wed, 1 May 2024 17:28:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3409D6B00A4; Wed, 1 May 2024 13:28:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EF2C6B00A5; Wed, 1 May 2024 13:28:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B6F76B00A6; Wed, 1 May 2024 13:28:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F2D576B00A4 for ; Wed, 1 May 2024 13:28:52 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9DC8D14090C for ; Wed, 1 May 2024 17:28:52 +0000 (UTC) X-FDA: 82070512104.25.4A8398E Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf19.hostedemail.com (Postfix) with ESMTP id E61011A001E for ; Wed, 1 May 2024 17:28:50 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e4cKjaKs; spf=pass (imf19.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714584530; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/z3qwZ2T0f1AcIzMY8k1DdsGurc58CRUSveN9mEOGBw=; b=4zVB1Yx3MFLrck2rFIiMdxnZqJR6ZlYydSTxsHEWSJw1xsVZIQIx8CAwDpBB9Q+1gnndh2 KltUoQMCj75dvcfkUNCYm90lN5d/pT0Q73RcVQLDWMy2SlFLtkDFu/YZC8d/1Yvtma8fSI Bf6nCD12/43fEpUmy8zbQ96r2+CFWNs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e4cKjaKs; spf=pass (imf19.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714584531; a=rsa-sha256; cv=none; b=AvUZ6yvA2xMPhWzhuO+1BXSgVM2opQzZFxXxTP81kZjlB7AJ7RGLmlLwSbQw62QGAleg/j GBRiNSqiY786jyaxW+47r3KoVBP/tMi1+u3U3dS4JFDpNACEJXoI8HqHbydnQBqiIMUII8 kI3hXXL4sIYnsZT5hyPg4v9znVYDdMk= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6ed04c91c46so6715663b3a.0 for ; Wed, 01 May 2024 10:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714584530; x=1715189330; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=/z3qwZ2T0f1AcIzMY8k1DdsGurc58CRUSveN9mEOGBw=; b=e4cKjaKs3Oihn0P+xCYWq/OM8O+MTp9KKulYAJ0J5vUqGVNzh/SI1WlHhrdejXzmXO fYVe0Vsb0RewiiCwY8+1gjymVr0xt1FynO1lo+wGGWJ98mGhDsqF8IvMF5uBRqHKMcgF E93I99prz0OQc62YLfMdI3owytJIuf7fDe98nkpAnuG1cQkCzhfyb3IhWaI/bx6Ttq1c UEUGQAO9VrQol1iLsDsrnZJ5AwJvb3m6OIBi/MfJnw2XkSvBwZlajnsybLytkILsWK7z +H4BskKUyjMHuU0J2DzRUNlE7CJQSCTW6Me3B2k3kR72W+j54NlMzx7DH3TZZ5R39wMR pDuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714584530; x=1715189330; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/z3qwZ2T0f1AcIzMY8k1DdsGurc58CRUSveN9mEOGBw=; b=nOpWkMjh1ZW4asHS4sesCxJ5oaf0wOnmJaHIyVgRR+I6V2zS2v4KQtf9z5MO/OP9b/ 20oXDwxj/i+KDqQ/yQiud2xCQLX9CqP856phpxglrOy6u7Mbb9Kv8EkmN9E27q557iND 5ecuD99kqjyHyPVZNRCFUytEf4d2xt4hakXffsL7SJFWKVV8DIWxA6+Qv1wRk+s2UJCX mdpG39Oy7HD3uhYE4eYNL2N4gk7nM7MzXnD9O+rffNOlGus5tYiit5DEcOy8Mkpmhwr8 X5H2hLR2kKJR35GDO+nCOM8+oRyRZ/yp9QH/0KQ0FArcJMqDz+FG/Z/lOCDibJbruslu WWzA== X-Forwarded-Encrypted: i=1; AJvYcCWNRhRad993HiU1w43slxtT5/nyt7TFmklIdUHQ3g8JsOm4wdUwU316ke8uXrJgU1eXDRi2A3qQTrgrOOCkct+oDP4= X-Gm-Message-State: AOJu0YwWDUEoF4cQppT+icTv9hHGU3yFJdXZ2LwMnCnp7XrUVetVG97a qUChQcfXwDPj8j6BzpcBsom2IKKythXoLdDJl1IM88+KhAsxICup X-Google-Smtp-Source: AGHT+IH+nW1nZbrDkFK5KLEoS5L4brAnP2C/EKD2m8b1DlKQM6YyKuTyZE5zX/wqdIzp611O87FXWw== X-Received: by 2002:a05:6a00:4655:b0:6ea:dfbf:13d4 with SMTP id kp21-20020a056a00465500b006eadfbf13d4mr3353946pfb.18.1714584528767; Wed, 01 May 2024 10:28:48 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id j16-20020a62b610000000b006f423ab373bsm1156887pff.126.2024.05.01.10.28.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 10:28:48 -0700 (PDT) Date: Wed, 1 May 2024 07:28:47 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/10] writeback: factor out wb_dirty_exceeded to remove repeated code Message-ID: References: <20240429034738.138609-1-shikemeng@huaweicloud.com> <20240429034738.138609-10-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429034738.138609-10-shikemeng@huaweicloud.com> X-Rspam-User: X-Rspamd-Queue-Id: E61011A001E X-Rspamd-Server: rspam06 X-Stat-Signature: kk6qxe395koux8fx939q8h3gk633jy5w X-HE-Tag: 1714584530-893874 X-HE-Meta: U2FsdGVkX19O7sBMxSt4/oQS9dQ2LhpWWsivoHFMt90F3sSaT+AAQiQW+4ypg2yA3IbynCCMDvB5J3JQttf6PLxedk7N19vwCf69v6X5f84R9cAlYPzPVu2IqtzyG1Q+If+NNx8ZhsijynSm0dSpHV6c8FCTKsmZ/r+IdyoESXAPmyemuGBmURgrw0UNMzDONYRHsqe7KNLWUUz51f6h9NBuNAoCV7GKElmVjJWdFVtEUuetxs2g+jBro1u+PF6iP99h7xBsumpHkzH/O4zBDipvl6PZc8BLRsIDmI4b3uCkrE4eiS92x4QhckS/MYDqxMDBRtkP6xs66je+/pCRyB8NIX0xCVEX2oExtJq+8k9MicXTbheZlXZ1nyfkTpRSMaWQ8OhuH8LVf2KhPGxzrljd3cT9W9WUUZc1iDoOlKpD7PSsTw1tA8dcOy2iWzX+gIBI/P1pMchBNpkDTWjSADJ10E3SHJa9YxdP2xHKC6cf2+xGGjUGDbc6e/xUdkrud3prvACqjX7JAOLbcIWDePOBltuu+OXut0zoalZnt4zotbsKcYGzXeCYMkVsupQ56Gd0Dd3H106PuJl6R0GX6aYiTvS6tDKMj/TTLIAlFGUnS1Xxx04EoBI23CviXrssCDfyGt+096rJ1lHL+0uOdh9sHJIgECpDpTgZ32/U8v5b/Bs+/mlS194YRIqGa9rWNT1ReNOzCnocP6ethqV++bRFsxj9SKK9KvH8Eq/hqxVKmSmy0mL6ACe47ctRHlI3h6BuO4PbSDnTnLcMQ+LhQcytQnUNFr9bM0LPJ8RTWXDNFNzMdPlLV4W8jWgK419KDseZuBqluf9CenQnuTKLF2GUwvYjwEDxBoR6q1iFxzEnnjuJJNQNlPURFhMtMS31rIwjBtB2AknFg0Cd3qI22A73/2BRcEfZTS4oZOe9fMAhCTZ5pQja8XfLjCar3gUrccskrvtysTVH7th5zWi uwodVNGz i3G0ly+G1rnF105BeH/n7tQfKYDDka52WuFWIDMMS4SaxZ/WLxQZmYfufLH6X5evLwhjoAYd74CX4bQhNbhWe5aO4zkYjYKY81d58FxZZyBJqbjuffU5cGuAlM+ZFv4b4kPTazWzg2IuRcvQrJ27dc52K1t2YsKrfZGFEVcDZ/zpa/xBHNbCRaH3Rq6jZGsluIaszcMxOi/vB8GCYk6qzta5itbH+tK5amHF3iKb1xBYeGSWw3AeGK98WZeu9DfmQp1+QMPntYll9SNirhXRfM4ipMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 11:47:37AM +0800, Kemeng Shi wrote: > Factor out wb_dirty_exceeded to remove repeated code > > Signed-off-by: Kemeng Shi > --- > mm/page-writeback.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 68ae4c90ce8b..26b638cc58c5 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -140,6 +140,7 @@ struct dirty_throttle_control { > > unsigned long pos_ratio; > bool freerun; > + bool dirty_exceeded; Can you try making the function return bool? That or collect dtc setup into a single function which takes flags to initialize different parts? It can become pretty error-prone to keep partially storing results in the struct. Thanks. -- tejun