From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91A73C4345F for ; Wed, 1 May 2024 17:15:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED0706B0085; Wed, 1 May 2024 13:15:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E80156B0089; Wed, 1 May 2024 13:15:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D472F6B008A; Wed, 1 May 2024 13:15:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B67B46B0085 for ; Wed, 1 May 2024 13:15:24 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5436380B51 for ; Wed, 1 May 2024 17:15:24 +0000 (UTC) X-FDA: 82070478168.26.D98837A Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf17.hostedemail.com (Postfix) with ESMTP id 6B0BD40030 for ; Wed, 1 May 2024 17:15:21 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Dbczkbdg; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf17.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714583721; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y1sTmKUbY7Erj5o9iGRoOkNetvvPf7EoiqrNttYoous=; b=5NjiuKJ7kYYwHQsz86z7W21jEi26raTpk8gd8rHNXCzmXaQKCUmDXrl+lm46omLeutWJbf ijdESsAY9hs4o0ZeOottPOQQgba4wQj/JFzVIQZD0PEEFvKJCORAQyDkjVKSV6lY3UnDGQ mF8OTAIe+DI6e3Zj45K+5uuS0eCRfC0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Dbczkbdg; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf17.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714583721; a=rsa-sha256; cv=none; b=WaO2U3z4oiUq5FUsmF1uEiR3scUVrfibmCOMyfi5WZhZO82DJ9fgEQtsmVoVty0qBWy2Qo buNte33cnWvNF3aj7R28rYJpHXDVh5GkceRdifgpkBI7S4azIrgsCkdhzUVXoiEyL53XlF G9A2pBtwMtM8lXan+kK5Pdj/LGQUeYw= Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-6123726725eso2905954a12.3 for ; Wed, 01 May 2024 10:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714583720; x=1715188520; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=Y1sTmKUbY7Erj5o9iGRoOkNetvvPf7EoiqrNttYoous=; b=DbczkbdgZQKIdX4AtQIqG2NqOZ7Qrs6EDsFUYV410mL5pkPM8unx8JHPysUBxhpvFW JmylFwGASoq4diwt1sAaQs/QpUJhAsCmLdaFyUkKHFzJIHQDkp03x9OJX03wPAOMwM+I Qw+nCOhWZeXvGCImNK4VOFHuEig4L+gERKz7ydgACXnVu543hlJb7NLrfokMrIAPU1gg dzzn8htezeJjxgpxPSNaFMtmU9k8fcUCPRIR7DNJ3Gyq8MzJjOUJIhFeMkIlBSlKWidn LYo0XVzfaDX3xkLO73AoCI8bNQBfFZwHv1X73ub/ZEREvWXDuyyLyOza/R/B2EqAZgPt bvVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714583720; x=1715188520; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y1sTmKUbY7Erj5o9iGRoOkNetvvPf7EoiqrNttYoous=; b=aIkrYAxTzbJc1qD0oqQrNmEXMQHCuVhRuyeXy9YUc25A9hReEISyHjMZzz76yOHxaV OFfiU6luRLiFYwEZdzubAViOtEzsOMumGzh3mkNefOXXpD8EIWcfTai4RYBpiqnA9JqW kME/8M5w8QdoIgv8jGgFJHpSt6+TKzrbtXRuXZJGrES15NWJLFYg22xfDLh8vcC2Kb62 h4+RwJczcEtNVIdH8SN8eAkrnSGfgRpWritukmEBpap75ceaz9N3xOyAZaDzXW2dEY31 e3Yaw2iPpPGjH5lQiizUtTrZEJBzG4vmZvFjPJuoVXFm7NpBigBi3G8jPw2Smw6Zh/7W /k1g== X-Forwarded-Encrypted: i=1; AJvYcCXOBKyyx1axg9UsR9ELlg2zMfKCJUIj0YWEvXfgjJMU6VwPovzBzGbnfSGIFLD0EQ0ZtqKu+cTx6kszRDy59GKWFrM= X-Gm-Message-State: AOJu0YyTfpCUlUPOitjsZGnogcr6FT4vVykUTMeaTIyQT2kt0HW/k/ZX wLYGBC5YeZFXrapGL+Wntnt5ecLa5cb2IaD9ODhwfBJpBMQKICnX X-Google-Smtp-Source: AGHT+IHToyNU976i2/tu4fzc25QnAIFb7zURgJSBPg02WmcCuaOef8SkHUtdI0ud/W4lwlBRwqzu8w== X-Received: by 2002:a17:90a:d48b:b0:2a2:1900:493 with SMTP id s11-20020a17090ad48b00b002a219000493mr2783537pju.40.1714583720163; Wed, 01 May 2024 10:15:20 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id c20-20020a17090ab29400b002b2927bf5b6sm1592177pjr.16.2024.05.01.10.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 10:15:19 -0700 (PDT) Date: Wed, 1 May 2024 07:15:18 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/10] writeback: Factor out code of freerun to remove repeated code Message-ID: References: <20240429034738.138609-1-shikemeng@huaweicloud.com> <20240429034738.138609-7-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429034738.138609-7-shikemeng@huaweicloud.com> X-Rspamd-Server: rspam01 X-Stat-Signature: q6dujtiituturp5ia3dwqiu48sc4kgh7 X-Rspam-User: X-Rspamd-Queue-Id: 6B0BD40030 X-HE-Tag: 1714583721-731617 X-HE-Meta: U2FsdGVkX18RXWAiJLQNdi4dkU7WYl1xvJSgE98FtAwKH0WnUsSm4Q5FR3S//r4FXz90DsKYPhpG1HEFMubS16AXPiR2UTsOJEhq22CQOo3QKxjhBImY6rqoQeQiX28cPygN8Gg6xKRp9zLe/K5IMNAkI+P9F5cRhBvSKFWVm3oI5T6yqpb8z/9j06cqTQoUVPEa9EAabTkqadcTZ8JoqIjzz7SfZQVHdDF5mi13/benBlz86UgNYaxLcQM6gk7NzFq2bAsZjF6tSCCxHYb1RXgm0eedpMg1/hKfnrpYZuYt0JxKn1GdB9vVqLFz6GGe4fOtp3TXasZSDQCRmQgKh6quLV5eqnDsle2YEWgjLBLeNtLj9h8c7I8dJ35l3PjCV6k9ur9smonwV3kU8JWCGrb0GfqnFMStZNAZIm1AyaAAIpZV/aR11jJVchNO9htaWSxQa5z802GOIjVTMy1a5e4/NfME8jGywLDhv5xbgF/cZskCD5eIT3LlMQFOdH+pVuVhZrG58ZIIzbbE3Cqc0MhSYTBDa4DXK+gIt6lP2xYrYF1RWzyRiyzduYjEelajLvw7lmxAeYsQGe35RRX/+dOS5fLtAYiomyay5bqxxNez0n9ocvRpS1c1MLmtaVbsOQuRWWPJ/SnGYRvNBeuW7kPeQHlEbyvUKvmoq9EDp2QXyLlAIJddLG1qGP9mtbZCHyDddyMA4RanTqP96nq7tCQ1GF6NoSoCIIDO4UnyfnzYzXdv18ozBa5lmFFKfq7gZ6+su6pSnKLo9Mtavu6HZJP37erUht3jNoHBWDkF1Mm1nWsHR4J/ngOXD5TcmPntnNY+16vaqizHBPKwa951WHljHJ66/n3yH8biqDrYLMQ/kYBnaj9xiHMkxBXHVNKOJnGHdmRPYxN4EIe8qoESxvnVuM2BR88ZZ3rEdjpABYVAfBjVyI6CtM7ut2NKVBPpKl2bpz9xS8YXJ+/B6Ru 4uLIq41n mRjro4OkfscKWncjIXM5iFwPcv5Gyqw+W/ZaPS7Q28AUtY3GEsgNu7gaV1H0a2KTHJfVwFU/esEpb4HtpJb3cwJiuvDsJVXL6hG8+nPDR36e/gvZLoQae4P8i9YvkzVyXFsFSqoUE5//gcdIxX9bdPg/GKI6gDNd5fmQeQreaD0sgABQ/xrOjXmMIXXTypphGUKwIf8tBMPoMwXVg1ll7E2kVsDJlqNGa2seW0YQuvoMtPNZZ8cAfowhotD1JUxUFdeq5N9Ax+CTjCsxk2kOijH9+U6MAeKvrVCVmoLqzOh97gdrrgRsCoQ8LCbeiw0hIFbEIoF8ypxuLJKPASsbMFCIAfUns3zfktG2oh/k+bXXQWmuV+KJjldaoogghlZoOtArGDCWYUaA5rHIVnjHcFMuIaGxHxiZvciA9QJ1fYw7yvivMIZlrb20MoDLpxVQ87RJAtc4PAdC9zJ7oJKDmBZ+LGKY9pDihpgWPGVggVz7gfoDcANnc7BOO9XRPoeOOolhaTL0ETDLwijXmqP/El7Ro2YENZ+PUaAcBHfqiDdS3AaEISxXQCkyGKGbXdMAgr+Cd2uFnTrRgSrM7yGw7Q/D5u5/SwAQZNsLfysEOuq3zb74= X-Bogosity: Ham, tests=bogofilter, spamicity=0.154064, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 11:47:34AM +0800, Kemeng Shi wrote: > Factor out code of freerun into new helper functions domain_poll_intv and > domain_dirty_freerun to remove repeated code. > > Signed-off-by: Kemeng Shi Acked-by: Tejun Heo with one nit: > +/* > + * Throttle it only when the background writeback cannot > + * catch-up. This avoids (excessively) small writeouts > + * when the wb limits are ramping up in case of !strictlimit. > + * > + * In strictlimit case make decision based on the wb counters > + * and limits. Small writeouts when the wb limits are ramping > + * up are the price we consciously pay for strictlimit-ing. > + */ Can you please reflow the above to 80col or at least seventy something? Thanks. -- tejun