From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B44C4345F for ; Wed, 1 May 2024 16:56:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8BBC6B0083; Wed, 1 May 2024 12:56:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3A136B0085; Wed, 1 May 2024 12:56:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C02286B0088; Wed, 1 May 2024 12:56:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A15AA6B0083 for ; Wed, 1 May 2024 12:56:37 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3A3BF1C041B for ; Wed, 1 May 2024 16:56:37 +0000 (UTC) X-FDA: 82070430834.21.EBDA14E Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf27.hostedemail.com (Postfix) with ESMTP id 88EA440017 for ; Wed, 1 May 2024 16:56:35 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QtATMNs5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf27.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714582595; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tjVFocR8HRNJS6GQuQDt5En/FwiwWy5FzW6t9DX2PPU=; b=io6AzEvk+4C8x6G96A3DbGt/F5soJpPJ+gM4uY4m+KSS0p80hjg0eX7B+FTlGV36I0XA30 CSUIQ+tJZXn6yuBYxNHazHitc164aMQW6uDwXFcoN/rND6+PoB4fTSGLbbt56jTyWE+Spr K9VjhO0UHfIbES5Swhv9TN+oPm1BoQI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714582595; a=rsa-sha256; cv=none; b=nPMUzaDGP4Hf6l7EeLTdkNomDjTo8xQRghytBYpb+/Sr3SNpIeYIkPZosL0xHCfQJUweR0 nfLRjVu+gehbrXVKeocZDs7dSdHN9HKpLID29k8DaL3gkpFvssqLjvnYHXpxju5xsXI2c8 65IfMZZ7Syhs4fwdr2mVP25451I02eU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QtATMNs5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf27.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=htejun@gmail.com Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-53fa455cd94so5376474a12.2 for ; Wed, 01 May 2024 09:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714582593; x=1715187393; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=tjVFocR8HRNJS6GQuQDt5En/FwiwWy5FzW6t9DX2PPU=; b=QtATMNs5W1Iwfj1DzO5L8zRutUbiYGWTp65S7WXBOvRJBUzJvhOBBtUDAjuAH3vbWO vEfBH7HEQiuMKrMzu27TiOVaWnuKA1etH4Es3CHWnBs8F+NR/Ba0si8fg/T4Rc6SJt2T o9cTEbdXY99R+MAR1ab+q5HbrcIdJTyWlzJiIcrVhymKx92OMAb3dRsK5+zLHIFGeLzI gZer1VJjWyugSrGJlyA+cLUiSRQR+8QZwYV8hcnSiGwFyjehDJTuJi5ZtLt4CtBbfLpa GMSyRT5cx98baswhw1+M9BEl9RiuOAV5Ys5BIqC8ZbNbe55mCTMojr5YvSa5IOTXU3/G 4ZEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714582593; x=1715187393; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tjVFocR8HRNJS6GQuQDt5En/FwiwWy5FzW6t9DX2PPU=; b=D5mKwfzlmCY9uea7RJhbaC+BeT+7c8wKEEU31r4xJLso8gOmYm0NzcygPkhTduiVan KpWH1qP5ThOrh01V5oJFS0Jm5SH6/EFhUGUI+3wslRkf74E0ZiqRALC7kb3xDWcUlBre X1z2Y6qdksuvE9H+Bij5i9ywxUSbVu9CSeI97xndj98nDuPzGxly7H7q56Pe+UeFygys +SHunraozoyGZzaMqYyaiHsPDo5S6uP3Qw1OX3V4kJV+Qpukne3Oz8xtmv6CnX46Zvkv XNptHlvadnAxTGJOA9zhYPgQ+Ab6Vc14CAnKTkAkqHas94oSKm56uFAPQNLvJQMwq13n VICA== X-Forwarded-Encrypted: i=1; AJvYcCU4HbmSPzew1WlcFvMS9APC7Ni02SDET9S8dnUe+fM89+NM2pce7P8fHXFuTxelJ1AqXdKF9oItep9pkqQmaAMD7QA= X-Gm-Message-State: AOJu0Yw1wvuknPusvaPw0IueXc3VJ4qoHYqciBfx67rd8qYJmGCKkBiw +vi3Gly4SLD81/8XpQv9nHzwAwBI3KKoepbGPBqr7Vck52vJV6Xk X-Google-Smtp-Source: AGHT+IGkYSiO+thE/tfIcL11qO/RGQ8hfJ0DuDW9PTxBvBNqA19mckAL6RMPxVEZ90n1ugYGZPCGQw== X-Received: by 2002:a17:90a:4906:b0:2a5:3399:b703 with SMTP id c6-20020a17090a490600b002a53399b703mr3151680pjh.11.1714582593236; Wed, 01 May 2024 09:56:33 -0700 (PDT) Received: from localhost (dhcp-141-239-159-203.hawaiiantel.net. [141.239.159.203]) by smtp.gmail.com with ESMTPSA id y13-20020a17090a1f4d00b002a2b58ee4a9sm9264634pjy.1.2024.05.01.09.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:56:32 -0700 (PDT) Date: Wed, 1 May 2024 06:56:31 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/10] writeback use [global/wb]_domain_dirty_avail helper in cgwb_calc_thresh Message-ID: References: <20240429034738.138609-1-shikemeng@huaweicloud.com> <20240429034738.138609-5-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429034738.138609-5-shikemeng@huaweicloud.com> X-Rspamd-Queue-Id: 88EA440017 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: sdxxrfk9za3o7um5wpjy4uuuq5nc5jyf X-HE-Tag: 1714582595-904343 X-HE-Meta: U2FsdGVkX18Izbof87tHjsFkFzLLe1AjX8jswV/wtewijEyKcDwAikcJQNQJcWlKYShTgpmU1ZxEn6t6IRceyk+IRsnArJlqKwi5oZdBnFVn3QmeWiTD1vix41Q1nO515BG3SL5WcUbtBi2IQxZpDmEcxnQFADyVAp6bQW6J8Bo0BGo643ZZJwvve7pMnG4tZ/bMUvjU68DgjkL/U9h+OwkudPMA3x55LD60/Unv3ZpKyu9+gdMOKMT5BQauw19NlASaZx7D9TXsLlU1sUhSA5kPbEAIB44FUfvhro+TcKwJ89+BtNVp1mMV/VjqXXoKQUAm7zy07mpE67jkmU5gsLpEvJ5QUa8zAz/u6Sk+nvn1h1QzuzHcML0Car2JvfE4PLX1iUBNCkdPKFqYtbNY0a+IMBXpJI2ysc/N01wvFg9D50i3+kd45fJMpIrkYwkTqSqsFUnkG7+SQ1PgxMLYzAtDapGvlQopoBKWneN9HzbRqHpxiTdrCHY/hBEybCMKbaEEzTR6GrFMhoqiu++Vzg6FG12K67RoaqMUCaS6UUl9mgOuPpjg6s6zMaj+5D8/F2JI8AlTWotNSjP61FPMwYP3hPxqzj3LNir8T5WvQu1dQJI3wJUku8NjdYVHv2w93JznsCHQN6MaIr3fp115yChztRwh9Rue0OqPmf98HpsxgbJdzeMWA08Irj14eR5MN3FbBPAxzwourka20sAkWBqcqZNI0JtFMFjJA65Dbnhb5zLg4KtN7q/AxgqizwWq7o4CZ3EU1gRPlrB3cYgPZx6395q9t8tynAoizOyAO5IZ+JX1R02wfB6neXpwZ1sT724kmtOSR0UVHZhR44G7/d7/p++RdrfxuuJTZa13lT8MHLIzXzeeOPrJ/fRQQa9r3WRU0qZtJtQ3/Nv5zaCrvcrzIIYilXXswlLHZpoXoV9XWg2iaz+o8LT49Ed15ob79CTVVPGc24g4ulFrotV BvPXqzBm 77CcSYYtFZv93HYoxkzuwciWayYVsmmJI44ZPGPjpycipWyZ25dm+y0oEyiYXYlnOsxVdKd5iNMoQQOFA/18tVq8kgQyQhnMN1/1nYTubTNCV2gFssdht6O8UB0E2YRDS3zaMxRxf8eQ2SQe+VeznPF7M+Tv2/RRD8tfx1hGab5qgA6VAAvaLttRGI0WuQouJ5XPw/PHVM1VKXOhSf+lA8LmRMerJ0TcpANnY/VLEK4Zbcg1egXd57D61eyDigYU25MzUSUNFlPICaz5TCKZb2sjoKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Mon, Apr 29, 2024 at 11:47:32AM +0800, Kemeng Shi wrote: > Use [global/wb]_domain_dirty_avail helper in cgwb_calc_thresh to remove > repeated code. Maybe fold this into the patch to factor out domain_dirty_avail()? > + global_domain_dirty_avail(&gdtc, false); > + wb_domain_dirty_avail(&mdtc, false); I'd just use domain_dirty_avail(). The compiler should be able to figure out the branches and eliminate them and it removes an unnecessary source of error. Thanks. -- tejun