From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D698C4345F for ; Wed, 1 May 2024 12:07:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 221E36B008C; Wed, 1 May 2024 08:07:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D1DC6B0093; Wed, 1 May 2024 08:07:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09B3C6B0095; Wed, 1 May 2024 08:07:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DFC506B008C for ; Wed, 1 May 2024 08:07:45 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 87580120683 for ; Wed, 1 May 2024 12:07:45 +0000 (UTC) X-FDA: 82069702890.26.9B68089 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id DFEE6C002E for ; Wed, 1 May 2024 12:07:42 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf28.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714565263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BTOQ2Q1R3Evah53a4Y8lQIjUlDiQf+ZrS+xwKr9y1bc=; b=1exQG/mGQvKaS341nj8Ui2kBkS6i38wfN4NEA7lib+NvuS3OY7226IuAqRIjacXIE6QOyo KJVu+0XUJDPG32gJoWe0aUmJmvzbB9bIqZ45SGtVvKVQvvhvS8T/Lmmxdmn8/A1mMh4Q0/ NcrXo5Khhb9SwN8a148XVJuPCVbZEsg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf28.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714565263; a=rsa-sha256; cv=none; b=C3Kmw86Rv8kHD1qKeaWq71MDeazTVTrrw00KTWQraOaNddFSQhyiaSch+nVoyFIABLqqi9 8Jgm5dyrGH5eZgE9IBvJafQ766bFk5UdcD0FdtUK12gwQA/KpiCXJaIu7shYKmnJAnEVPZ 4Ft59tvHYFwT/AZH8YLoVoKdY8msuW8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C5A7A616AE; Wed, 1 May 2024 12:07:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CE03C113CC; Wed, 1 May 2024 12:07:38 +0000 (UTC) Date: Wed, 1 May 2024 13:07:36 +0100 From: Catalin Marinas To: Maxwell Bland Cc: linux-mm@kvack.org, Will Deacon , Jonathan Corbet , Andrew Morton , Ard Biesheuvel , Mark Rutland , Christophe Leroy , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ptdump: add intermediate directory support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: wusjijhxb639ho74i1ergidxpftzh31o X-Rspamd-Queue-Id: DFEE6C002E X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1714565262-118299 X-HE-Meta: U2FsdGVkX189w3bFbvDiiT9ILrYALa6wbBUG8LgNDNH4LMHBDvh7BFk1TLDeI0xdAGg7PAtr5hMREYwvoBc0+oJ66PkvZuGezIlGRM1Q5+Cs5W5i1R+pWhz7Pxz4NrAHjjF/8ba3B1aKQXbAeP0KtjvzBke5wKRmC9kCHzfOhMaqAD+qDRtT2i0vJXC/JZsQzQOCVLkh7VCz28ahGW9d5Q+3h0BK4JCO2Z4VG7uTVEcqFAJJ4s+vjX8iATZQ9JIDbT1uNGd4TH8yIamxA3W/M4eqsRz/KjdoZdyGvMlD3mp6ujY0xB9GRJEH020ZJAvoAX9Z1KzQxMblK4h4Tex59/1G1N04cRyV3qSNNC8UbiY6Ld610X7U0jsYKSUuVb/FuATnLcfwI0kKNOV7uXrMAjs+M3qaFrgv0XcdfjJLQaUJ3pqgukHRYqRLQUa1Y8Pt3p7SOF1AMlA1PqjTrx0eTPIuxZq2aCI4zeAHgDAVmhpZtJ4vI+RxSVKkv/2ZdHtWA86rBa0OAVD9M+gx2JXdKptlDY3hoUUJE7aRlt9VGPETGoP+sgq7JBfHV0fqdpjZcEscqTX994N2tJbnurg8yZZ3wvBFXtr6eH91Ua7Wpq10C+AZCy1cERxf4t0YIqfgDNbt8dOET5rmXEgKNEqkkjt+bgzRImqKM9dtPK6vrVAZxr6PfushQn3HZ/sUhx3Zqqk3vYY/4nCO4qXtvC3MIho5mwrwKd0xjduLL8YNTlpuR5taQzvN5FocjpYfYxDX32IqyByzGkSlxnWQmTV0sJ2G6KDgcxBlU60JVooWrD0wdmJsRo7EJVLMFojCjhDThoroPlQZYPWArYpLkJZ7Y9/YflREljVAvwltWi38MmjYd4Ap5Eq5i/EvVXmwP6wskMeuEFbTBDy7ChYCjWTB9YyUQuiHBKa1Dtu/7VuBpcLuSTIzD6tVJZvutTv2lLJrNdQ3nQaM+6+ue0SX3Yb qoj7mdA5 ++296U1+xDPmelRSer5XvvC/GIZo74tmoohcgrb+tegy2266tf1wQsMqxQoAMMJ2c3ntzK2xax/Ng4vwAt0VzbBCS7/Rzhn4oUFWbNk7KY5RsED7T7vTreHYXAe4YuPCKCcHJWYewLk1S97cC43JHlRyLGN51Qy8jfRA4NoFjnnFvdDiI8PINEEx/DmpEro28AFiN2OCRrGO5Jrc8IXAL+9EylzqrqY7kdAtc3nrAHb0/9l5EdflEIIGtWsJW9DU65/AvJ8vrZRSs+bG6XoIwr1ujgW+X5Pu0MbbN8WS39gh/JOn5DvQk68W+AZxOUTgxREEAd0zzXiozcBIq4tagnp3DSKOnULMa+HjaTzRSXsg5BNLi6CmHsr5tI7B1qUfTMh1/KmaOIV563Qk1zcPLD/8cja2y3i+cZyUraCuJnwF5iBBdBCFuqbmtfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 11:05:01AM -0500, Maxwell Bland wrote: > Add an optional note_non_leaf parameter to ptdump, causing note_page to > be called on non-leaf descriptors. Implement this functionality on arm64 > by printing table descriptors along with table-specific permission sets. > > For arm64, break (1) the uniform number of columns for each descriptor, > and (2) the coalescing of large PTE regions, which are now split up by > PMD. This is a "good" thing since it makes the behavior and protection > bits set on page tables, such as PXNTable, more explicit. > > Before: > 0xffff008440210000-0xffff008440400000 1984K PTE ro NX SHD AF NG UXN M... > 0xffff008440400000-0xffff008441c00000 24M PMD ro NX SHD AF NG BLK UXN... > 0xffff008441c00000-0xffff008441dc0000 1792K PTE ro NX SHD AF NG UXN M... > 0xffff008441dc0000-0xffff00844317b000 20204K PTE RW NX SHD AF NG UXN ... > > After (tabulation omitted and spaces condensed): > 0xffff0fb640200000-0xffff0fb640400000 2M PMD TBL RW x NXTbl UXNTbl ME... > 0xffff0fb640200000-0xffff0fb640210000 64K PTE RW NX SHD AF NG UXN MEM... > 0xffff0fb640210000-0xffff0fb640400000 1984K PTE ro NX SHD AF NG UXN M... > 0xffff0fb640400000-0xffff0fb641c00000 24M PMD BLK ro SHD AF NG NX UXN... > 0xffff0fb641c00000-0xffff0fb641e00000 2M PMD TBL RW x NXTbl UXNTbl ME... > 0xffff0fb641c00000-0xffff0fb641dc0000 1792K PTE ro NX SHD AF NG UXN M... > 0xffff0fb641dc0000-0xffff0fb641e00000 256K PTE RW NX SHD AF NG UXN ME... > > v3: > - Added tabulation to delineate entries > - Fixed formatting issues with mailer and rebased to mm/linus > > v2: > - Rebased onto linux-next/akpm (the incorrect branch) > > Signed-off-by: Maxwell Bland > --- > Thank you again to the maintainers for your review of this patch. > > To Andrew Morton, I apologize for the malformatted patches last week.It > will hopefully never happen again. I have tested mailing this patch to > myself and have confirmed it cleanly merges to mm/linus. > > Documentation/arch/arm64/ptdump.rst | 184 +++++++++++++--------- > arch/arm64/mm/ptdump.c | 230 +++++++++++++++++++++++++--- > include/linux/ptdump.h | 1 + > mm/ptdump.c | 13 ++ > 4 files changed, 332 insertions(+), 96 deletions(-) Is this v3 replacing v2 here: https://lore.kernel.org/r/20240423142307.495726312-1-mbland@motorola.com or it goes on top? The patch versioning and subject change confuses me. -- Catalin