From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A36DBC4345F for ; Wed, 1 May 2024 09:40:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27AE36B0088; Wed, 1 May 2024 05:40:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 202E66B00B9; Wed, 1 May 2024 05:40:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07CB26B00BA; Wed, 1 May 2024 05:40:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DBFBB6B0088 for ; Wed, 1 May 2024 05:40:12 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8BE431A0434 for ; Wed, 1 May 2024 09:40:12 +0000 (UTC) X-FDA: 82069331064.08.F055A33 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf12.hostedemail.com (Postfix) with ESMTP id A512540022 for ; Wed, 1 May 2024 09:40:10 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=cwJUqsjk; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf12.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714556410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wT6FpY3G8icgSQcw7GLJpHBZGPLegu0OyLVBane8oNQ=; b=NqzIBw0gMuwlmK8LOV9clnTt8TRrNgPV0uIPa5QV0RREHODuOAbgux5pnuFMVa9s+MGli2 GqvgNtpaftedCCED1tNk48Sdmfpt705NH7XV04y1HKT2E6AY4XoKSkVNY46bbTMpIfdh+Z AxxXEX1a+Y2yuIoA5iyCpF/2R9/Sb3I= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=cwJUqsjk; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf12.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714556410; a=rsa-sha256; cv=none; b=4tYDZWoc71w5mDo0J1PGhBLgy5ffNBoWrw7ZtnTGPbockcE8Twan8sXQFbEP0T5Ez3iWU2 RgRtiYD43XMLE3opfhv6XZO4eGRD/SdJ/7pSb6MUYYD1ZHO7Uo+05YS3kNN8uVXZLV3XtC OO1BVcebv6Z77dEyBexUyz16e0MTO8s= Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-60585faa69fso457469a12.1 for ; Wed, 01 May 2024 02:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1714556409; x=1715161209; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wT6FpY3G8icgSQcw7GLJpHBZGPLegu0OyLVBane8oNQ=; b=cwJUqsjkxqifnhpqNNpRBRkjzll3xadnAXgQ5OyoUfw9AoFf8LnUSiTdZw/By1sNQ1 vSgvCjMsFnNeeZzf6Lr7HwvJtWtuW1CWC3X6SUv6oe4xc2H6kILZCJ2146GXOXLs4WkP wY1Ib5KvI/7dzuTWOivXOyKSX/mLH+WCLu5U/BfCBn6LVnVRRstaMw6ZY+VzXLsXZMix 4wPiMpg07n0R9EQ1/q7+QsNMYT0OM4GkHJPIvsuq3yUpiSO7MDX7y1bahBO2vvUa+myK 0Vy/VTRDWj4ZGbnaYLBpH5TuVE+b3CgBd3MKjpSrkwAOo3L55cwY92sI2JE2dhF/yDCz ogkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714556409; x=1715161209; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wT6FpY3G8icgSQcw7GLJpHBZGPLegu0OyLVBane8oNQ=; b=pc7UeFJMbfe2g1UyZvkdZ+Ja1WEqTGhwaNnc3uovVRliIL1semHl/KDfa1RsnuGQ+l WuMJoM9GgK3JHJjEDcHIglFfqIHcV3iQjj09UdpFDtNoJpGin8mIebhoF9QgCKOCkbrt S3mqh/SzQXMagim1/3uqmKd/05aS4A1qG4RX/Ix/K0fpvJNr4oCT94TXCk1tKjx+JLot SELBQaHF87IOVDtn4nnc04EoDuuiH1Vg2Q19Lhk735OqIC8KLhjMSVxUZ1LTWSGKzPVI uV7lKoalqcKZsUWDWuX4F/mFsMmp7Q5L85a8u5TXN+2kNh6sL6TNOrekXoGrL/hTmpiF 3ItQ== X-Forwarded-Encrypted: i=1; AJvYcCWddf/HQrqsuwjkr4hZEzym/Ndk1jMQ7Sv7PfRhg1wqt5yKN498wNnBadgUYdceNBobnIDAHUJrnxgu0/qJiis+EF4= X-Gm-Message-State: AOJu0YyyrmogVQLHg3HAqt2tSpO7rUlJTCsOI28GwepXmrribnQFk0B4 cDIXYkZ68YvY1yATv1GvTKkgUXkNWZ2pTOP11ncHnP8isZheVYfr0qye5CVxB449Rw6BzROgkHo V X-Google-Smtp-Source: AGHT+IEaOpqOneqIif2Te/uo4KR9GvWB9QZnymHXhoZDlcycKWWY9JInC0Qe5XsLY7mFCgHMhhrjpg== X-Received: by 2002:a17:90b:605:b0:2a2:fec9:1bbd with SMTP id gb5-20020a17090b060500b002a2fec91bbdmr7291676pjb.17.1714556409282; Wed, 01 May 2024 02:40:09 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id bk8-20020a17090b080800b002a51dcecc49sm968664pjb.38.2024.05.01.02.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 02:40:08 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1s26Ra-00HDgc-2Q; Wed, 01 May 2024 19:40:06 +1000 Date: Wed, 1 May 2024 19:40:06 +1000 From: Dave Chinner To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: Re: [RFC PATCH v4 27/34] ext4: implement zero_range iomap path Message-ID: References: <20240410142948.2817554-1-yi.zhang@huaweicloud.com> <20240410142948.2817554-28-yi.zhang@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240410142948.2817554-28-yi.zhang@huaweicloud.com> X-Stat-Signature: mkozjt46wuopqi5es85aexs8greade5h X-Rspamd-Queue-Id: A512540022 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1714556410-381568 X-HE-Meta: U2FsdGVkX18DIswVsGJToLKE+Ut7zt7YA1iJ74CjfR4Tr38zkOqj9VMfYbWd59pBBaK8qd2HLiRXMo3d0DxuU+loHITX4wQVdOU9bzMXOOJ26++2sQtscd+igslRdZFqpmKcbf+JDbcIze+B6v+l6ZTiW5T4P8Cqb96f7KtmGgT1o/d8pACdrzDLCi8JPFIPTYNccxERa5RC96IxXTaBXPRu7DRuiAbeNI1PnUE1HJoCJdRf1jyu3iyOEi04yQht2VktoRnJH1r+dA7rkzsscxpyi+5woaj6C4waRjRMZx0zGKq5M7AfklaRoO1piywd4NWpwMsBEplSFqiIydNPtiA+x7ZsvSAhC1eUVebDp/jzAyCU5RnJa2ZKzb9MlKK6STX7H4PBjLas2kNimgYOEE8+wq3q++HWFblAGK9h+OjkOAx9hYgPus7rGpfO6+R/F09eowJzZb6qapNkaGzXmgZc/1PzJTIgO8Mwjn0nADYngohX1RDYvM0zALOBvifnwG1Pp4K9hbjW6FkTtuYLkaOgxhQmFqsnFpzc673SiAvIV1Sh6SLrlcKCVFd5sjhJpmubxHhzsEXMJMw7jnm76xJ8dMQ0s71bGxWIZkyCXgRPciReCKu30mKOLP4UcXK8Cdt+bPuMUC3ilWYSyvTjK3FFUxEFBT0AXbuMcMTTq7qfA1lyHKaQFQ1QVhRoXFxuOE1RDiZO/j5uzSRdltwN/27ddujT4bO/TPuJwPs1YYCtGU73RyzuoQzlR4j5Ka+3DhWQyBlIzAiq5iV5pLmHIM9IhBYLQp2zWo7mdM68SG4gakBgFBNDH5blSDWTY6DL9RYLd+BdQ+1euiFszdWTg7Qhyx1IQZpw1E0GQIggP9X7wxbMNbfnxZl+MNA/Hiamjg/s/BMTNbTI6fjCpajSf9qJfcyT4b+6qCuuhrmJehE3IUNmktIvXKM44lN3y/yT4S2zJXLynXjuwuwWA08 NlDAa4Uc dzq6zc+i0HP2EU7OX1Hzj0XPjiIjCTbeyklrKf1qn9AEGJlTm4Q59hsyXLpdOqAtDsaQVoLGsLgWYrO3iZZ2SdORUJvU3mhlC/m3GmzkzuSwtFpd68RtWt0CK/xa4ffMN56D2CqPCSn3O8gCP0SXEKSgLFyGVXFOPM+miSRoGQfFHt2O7b5BXTm6f1iVh/StAhOWafiDRA5CNk2f8prP8G8E8jcwh6c3xuu/ARSFWMDvgP5SpEeBEjV2zDWUbslQAqsTdLbeIcMLfLX+W6vva36CJ7J/G5kmVCO02rGPZQss/Onj71zob9lMPcGVAAcb7zakKpdKOf6MLV86Rffma/8Ww8DTY5Howr4FDI3nfghEqd9W7Vl9twXF/lGCrY+oG/5+791B7Xx/o2Ua5iZ82cCVDTMc2PrVKXatyoraDP7sNw/ZGOG16lZ6H2XpLeLKLqNyUkK0vGEV+WV9NvqlyosG5rJAB5c4urxYvJ4zy5vMaQ3XLoHYdtiGuX6/Pxv/hK6thXQKFvZpGPwSuy4EvbYsKCVSbefppNr6tkBG5QWzfJgL0S0khmXehE43SfkacOAPsndlgVoo0yL7JRYYVEjJROg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 10, 2024 at 10:29:41PM +0800, Zhang Yi wrote: > From: Zhang Yi > > Add ext4_iomap_zero_range() for the zero_range iomap path, it zero out > the mapped blocks, all work have been done in iomap_zero_range(), so > call it directly. > > Signed-off-by: Zhang Yi > --- > fs/ext4/inode.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 9d694c780007..5af3b8acf1b9 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -4144,6 +4144,13 @@ static int __ext4_block_zero_page_range(handle_t *handle, > return err; > } > > +static int ext4_iomap_zero_range(struct inode *inode, > + loff_t from, loff_t length) > +{ > + return iomap_zero_range(inode, from, length, NULL, > + &ext4_iomap_buffered_read_ops); > +} Zeroing is a buffered write operation, not a buffered read operation. It runs though iomap_write_begin(), so needs all the stale iomap detection stuff to be set up for correct operation. -Dave. -- Dave Chinner david@fromorbit.com