From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68802C4345F for ; Wed, 1 May 2024 09:32:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 000B36B00B4; Wed, 1 May 2024 05:32:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF3356B00B7; Wed, 1 May 2024 05:32:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBB0E6B00B9; Wed, 1 May 2024 05:32:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BE36C6B00B4 for ; Wed, 1 May 2024 05:32:55 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 614CF120829 for ; Wed, 1 May 2024 09:32:55 +0000 (UTC) X-FDA: 82069312710.21.BE6A241 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf30.hostedemail.com (Postfix) with ESMTP id 847FB80016 for ; Wed, 1 May 2024 09:32:53 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=ZH4ECIeN; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf30.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714555973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g8kpyhny34Sijm4UGjTcnGqLvDZUER/KHyPevVfWv1A=; b=QdnwCkQDdjYp0CNZKC1biq3yUfw9woYHDZ5+Qm4m7tC4yZLDBpOeDss7y5YjncOD9MvrUt g6xg4uruD+Q+GcmlEzjEpYSIzQhrtroDhnnM7vchnSK/kImJyJJoA9tuQWL2rzGg8n7NjQ yUWFKHzxCoJrdamPRFJPPVe2cNs569o= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=ZH4ECIeN; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf30.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714555973; a=rsa-sha256; cv=none; b=L/Vn2wRN9zTD862YrgzDn/WV5aWHaT4787Uv5vMEjFvt5TllFTa5OA8AuPnaoK5sc1MX+w RN8AUorxpVrKdzN7i+qBJ0NOVipYuYsLpSqO8WTBBMvXT4tuQthP672nHpss+0x7mp/O6f lA8OmPxm7s2lvelCpoWNz/vT1PYntDo= Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6f103b541aeso5583664b3a.3 for ; Wed, 01 May 2024 02:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1714555972; x=1715160772; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=g8kpyhny34Sijm4UGjTcnGqLvDZUER/KHyPevVfWv1A=; b=ZH4ECIeN9Qw5xIiTD1xKHykaBU0k2ljTckZr/TQW6PhnR7QM/fnytqWdlK85aFZOec OKSw1A11d8K+ycHHMCrerE/L12axE55p8zRS4jNaE2FMWZMwp5G8078cAC5Mgl7twbkv 7T1nwCbCMSbVyRGYm5sp66R90hymK1RUdG1BWzmL+J2+x2pipS8bGekb2r7AQaZjR9lu /1rLc/cqVWtz1jdtBhwuy/RWa39budmGhP0DSDF0FCYZ0ILpgYM7VvmNBrg87C2osCSy q96IKs1L2LSO74cSAd/RxUNFya4igvQj1lvH3kO/xJXbV4YbXlRNvxmcrA7tt+SPidLD MOrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714555972; x=1715160772; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g8kpyhny34Sijm4UGjTcnGqLvDZUER/KHyPevVfWv1A=; b=HWHnBlMEdkVg9XeRnV+6en9u1MM6U+Fur5yj8JleSk7iywhgdwhlEkC8QAgZAerHqQ 4JO1pjg4uR7bTXZtSi7eDnvSdHFNJ0p0C3l/GN/KRJbrYMtR/DG6kqgYUdQvlbmCSilH asIQHJM4UWUuDE58ODIjlE9ORdQZCQ8e1ccIkL5HrYGubrSDdu7GWAjlv59nljqqPRKt 8hGWjtfw/YeIWz0/JpO8kRaIY+tA1Bysvx+0XwyvyYMW0vj0s6vEav2w+6hLOO8TyqMc NH1VVV7KNho/adr+Fytf/RSkvHv/HCuXWcZietX1fIdT/SY0Z4FJ+x0gSlOkwyuL9ESg w46Q== X-Forwarded-Encrypted: i=1; AJvYcCW1KolfmGyTf/nDBce+My//UAXxaxZp0NQhP04fZAUEEh8X/hhdx19Af20UTFdtXygiDHJRqknYmFoYUdr33ssAmng= X-Gm-Message-State: AOJu0YwWoMTdTKuktcG0lLgIzC4tHOl8WwIOqThnTn2GFjQol/3MB4cv Mf0DjtYPXgPZLPvuuUZ1S2jt1/9+tEkSLajG1DD+5r1rwiGFft7p6cLuRQnkwqY= X-Google-Smtp-Source: AGHT+IH0bIugehaR3h0BPg9B9iAy4/R0yTCrY6GCh03Oc+x1Ek3PGyNgMf041myAZ2k+mYUyYZR40g== X-Received: by 2002:a05:6a21:1f1e:b0:1ad:9150:631f with SMTP id ry30-20020a056a211f1e00b001ad9150631fmr1566779pzb.36.1714555972064; Wed, 01 May 2024 02:32:52 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id j12-20020a170902da8c00b001e27557050dsm23833306plx.178.2024.05.01.02.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 02:32:51 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1s26KX-00HDMz-1V; Wed, 01 May 2024 19:32:49 +1000 Date: Wed, 1 May 2024 19:32:49 +1000 From: Dave Chinner To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: Re: [RFC PATCH v4 29/34] ext4: fall back to buffer_head path for defrag Message-ID: References: <20240410142948.2817554-1-yi.zhang@huaweicloud.com> <20240410150313.2820364-1-yi.zhang@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240410150313.2820364-1-yi.zhang@huaweicloud.com> X-Rspamd-Server: rspam01 X-Stat-Signature: e1mygs6mhu8spi1uxiqyw3i78uwthkxn X-Rspam-User: X-Rspamd-Queue-Id: 847FB80016 X-HE-Tag: 1714555973-50047 X-HE-Meta: U2FsdGVkX1/lGzveSYBMbp3RRjhgY6CYeHDMgtxT/7u38HQgpccN/a9FLmiI4G+Rk0fs5rKBBn3CenBS8Z0kwLAof3nFA/uwQPGSJb+t64gDKgMlg8gv3C9+tk4GkGKG5pSYgrANck+RAUsdDqLggnpgrDPM7tkk2hk1Wc7koXNXGz55qcQIdjUJjp1m5h2dFunXJf0ykRDXvidw+bZhiMKmkhGJTKxwxMTnvbXkKOqXTndFv4vq9iANmbv5bgDWB7vqweIpalP2fN15IuW6ZCtPBGQjolX7psBpvZ4gzE2gKT1mC2iJvs+zYUC5pu5yfX9n9qVoKzKi337aWV5vj+ibHQ9EmfzD0SO8uJIbbTyAyuauLAK6oJg15mXNYRoTPpk9CpwW7Aq9M4ySWcYNv6ZgTYyKoNWar4JBTvcWnOE8abgvKlEM4PQx42Fjdt7+2mxx88TTDgTuSimOKMGbc49bVBQJAMaU8Q0zT0liacRfh7sZGFXeev54gOxTyAMTw5UVpJ6T9O+DYTslf97no+2uVE5e0LeuQ3bd/jgr1tYiGgBUY5HG3Ut9wHOLw0BrCYsi1agLJSjl8RoJOdaszJ7NHYPy5emlAklI3NWzJKfNhQHk5zbbBnNAoy7RSPKky5kJdFVOr6ep1m+MnIi3HdjsjAs+kEGjhGSaXp192T/mdk4eMIpeTVQcW+/nK4Ybu2ZL+BuXNvTSdRwaCAb1m/1pnSVZcV85RWNTUevrF+v3LjlGnUTWPmc27lk/ckrGbt9rCFzLQFvSnnQQwdKxuVcKQhC+HB1hsfHbJG+pHZo/XctuL2d27m1Xd0kgaqIVlQqBEcODRs1tRfWFYjoaH9M56rRVZxyW6rz2Xb4ri7tE4RM2eE3zY0+Hti3JLh7BNSJ4shZBXCF40dCWklvWyWxj7wJ9WUtF/VNxGrBoeHJSxh6OonE1dU6CdgXi7LuoRzUD6lodefBIGYfoYRA aua/XscZ pm6i0zocOQC63Z1jSmJOZCIfHVEGd78Iad0Ln5Dz7xjsQGfLIgEdILeXpAX76aXf34bzs3EFzYePLES/LYaoSE6ZRiDWDgCU9tx3e66J6JinhNJcVoJtNSJRxkD4RMOa7Zx7V0rTgSGg6QIVuMn8QoC6sC046BQGeTGTnpVABe4ybu1lty8enR+G03aB0mzxSGRQdjywXtOYd2tQtWCzkdyPVlcqRMhliPrwqntlWynY6uGcBL4Kiuk7iPQmw6ouGNUzd8WRKc0oAACNTG+jBqa2kc01C+saSvN85qnIWd6TArCaf3OZmNOREi+AOsoqw1CTLr8mGXlR5Mv/SbsyPiE9BPKpHktzEQJJt+iurTXh5X7l7mla7mzrX03V+ApLaZe1BPGDvtqYjI4lvIlrLIcPp+h0g1BKjz+a2S+yt++6WMTcMdY3Ggk4dH5uH1lfmfeZp9BSrbkybJg+F0yHJfHspSr2qbTdPa9afPvVrGeLu65iSMc3sacnpLzCuiAsdPCsFPjZ1vwX2ttrGwpjB5dvDtM44EZRx/+WSaNH74ERHADA3gTQ/HgUQM64+5vOojWtxn1u/RfgGr1cwSU4H9Q5WAsDRNlStLjKDBJuzuCly7m8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 10, 2024 at 11:03:08PM +0800, Zhang Yi wrote: > From: Zhang Yi > > Online defrag doesn't support iomap path yet, we have to fall back to > buffer_head path for the inode which has been using iomap. Changing > active inode is dangerous, before we start, we must hold the inode lock > and the mapping->invalidate_lock, and writeback all dirty folios and > drop the inode's pagecache. Even then, I don't think this is obviously safe. We went through this with DAX and we couldn't make it work safely. Just return EOPNOTSUPP to the online defrag ioctl if iomap is in use - that avoids all the excitement involved in doing dangerous things like swapping aops structures on actively referenced inodes... -Dave. -- Dave Chinner david@fromorbit.com